[{"id":19099,"web_url":"https://patchwork.libcamera.org/comment/19099/","msgid":"<216b4038-04c6-dc2e-c587-050520562fcf@ideasonboard.com>","date":"2021-08-26T13:23:00","subject":"Re: [libcamera-devel] [PATCH v1 0/3] Fix Gnome Cheese and multiple\n\tcamera","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Nicolas,\n\nOn 25/08/2021 22:18, Nicolas Dufresne wrote:\n> From: Nicolas Dufresne \n> \n> This patchset address issues seen when trying to stream from multiple\n> cameras at the same time or when using Gnome Cheese software. The core\n> of the issue was that multiple CameraManager instances were created.\n> Two deadlocks were encountered during testing and are fixed.\n> \n> Nicolas Dufresne (3):\n> gstreamer: Fix deadlock when last allocator ref is held by buffer\n> gstreamer: Fix concurrent access issues to CameraManager\n> libcamerasrc: Fix deadlock on EOS\n\nThank you for these,\n\nIndeed, this also fixes the hangs when shutting down I had experienced\n(but not yet reported)\n\nTested-by: Kieran Bingham \n\n\n> src/gstreamer/gstlibcamera-utils.cpp | 31 +++++++++++++++++++++++++\n> src/gstreamer/gstlibcamera-utils.h | 6 +++--\n> src/gstreamer/gstlibcameraallocator.cpp | 17 ++++++++------\n> src/gstreamer/gstlibcameraprovider.cpp | 22 ++----------------\n> src/gstreamer/gstlibcamerasrc.cpp | 23 +++++++++---------\n> 5 files changed, 58 insertions(+), 41 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ED631BD87C\n\tfor ;\n\tThu, 26 Aug 2021 13:23:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6BEF46890C;\n\tThu, 26 Aug 2021 15:23:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A5586888F\n\tfor ;\n\tThu, 26 Aug 2021 15:23:03 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DBDD0191F;\n\tThu, 26 Aug 2021 15:23:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XtpEBUk1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629984183;\n\tbh=XmbIhdoOtwVJYTEkdQAaFdGtEcoqn1MYbHbQfAfGj5E=;\n\th=To:Cc:References:From:Subject:Date:In-Reply-To:From;\n\tb=XtpEBUk1lcab+7fxhoPn2BD+Ls6KJqM2BOVcuE4UALwrBTfNxPwcjNeQJ0E6MXXm4\n\tQytmm6mcs0vlG3+CnUhGfoqTYvPk6D1gQjBpFB2FnveSIzlD2V9xZBuzOI4OLno3eB\n\t/4JlDZIzaLoJxgPv+MrZoDVksFSLoLAwzLmNaNRE=","To":"Nicolas Dufresne ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210825211852.1207168-1-nicolas@ndufresne.ca>","From":"Kieran Bingham ","Message-ID":"<216b4038-04c6-dc2e-c587-050520562fcf@ideasonboard.com>","Date":"Thu, 26 Aug 2021 14:23:00 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210825211852.1207168-1-nicolas@ndufresne.ca>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v1 0/3] Fix Gnome Cheese and multiple\n\tcamera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Nicolas Dufresne ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19100,"web_url":"https://patchwork.libcamera.org/comment/19100/","msgid":"","date":"2021-08-26T13:25:09","subject":"Re: [libcamera-devel] [PATCH v1 0/3] Fix Gnome Cheese and multiple\n\tcamera","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Le jeudi 26 août 2021 à 14:23 +0100, Kieran Bingham a écrit :\n> Hi Nicolas,\n> \n> On 25/08/2021 22:18, Nicolas Dufresne wrote:\n> > From: Nicolas Dufresne \n> > \n> > This patchset address issues seen when trying to stream from multiple\n> > cameras at the same time or when using Gnome Cheese software. The core\n> > of the issue was that multiple CameraManager instances were created.\n> > Two deadlocks were encountered during testing and are fixed.\n> > \n> > Nicolas Dufresne (3):\n> > gstreamer: Fix deadlock when last allocator ref is held by buffer\n> > gstreamer: Fix concurrent access issues to CameraManager\n> > libcamerasrc: Fix deadlock on EOS\n> \n> Thank you for these,\n> \n> Indeed, this also fixes the hangs when shutting down I had experienced\n> (but not yet reported)\n> \n> Tested-by: Kieran Bingham \n\nThanks for testing, I just sent v2 before noticing, if you are happy with v2,\nplease add Kieran Tb, otherwise it will be in v3.\n> \n> \n> > src/gstreamer/gstlibcamera-utils.cpp | 31 +++++++++++++++++++++++++\n> > src/gstreamer/gstlibcamera-utils.h | 6 +++--\n> > src/gstreamer/gstlibcameraallocator.cpp | 17 ++++++++------\n> > src/gstreamer/gstlibcameraprovider.cpp | 22 ++----------------\n> > src/gstreamer/gstlibcamerasrc.cpp | 23 +++++++++---------\n> > 5 files changed, 58 insertions(+), 41 deletions(-)\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23910BD87C\n\tfor ;\n\tThu, 26 Aug 2021 13:25:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D87E76891B;\n\tThu, 26 Aug 2021 15:25:21 +0200 (CEST)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FC3F6888F\n\tfor ;\n\tThu, 26 Aug 2021 15:25:21 +0200 (CEST)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nicolas) with ESMTPSA id 53C4C1F44334"],"Message-ID":"","From":"Nicolas Dufresne ","To":"Kieran Bingham , \n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 26 Aug 2021 09:25:09 -0400","In-Reply-To":"<216b4038-04c6-dc2e-c587-050520562fcf@ideasonboard.com>","References":"<20210825211852.1207168-1-nicolas@ndufresne.ca>\n\t<216b4038-04c6-dc2e-c587-050520562fcf@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.40.4 (3.40.4-1.fc34) ","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v1 0/3] Fix Gnome Cheese and multiple\n\tcamera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19101,"web_url":"https://patchwork.libcamera.org/comment/19101/","msgid":"<0e2a4c08-559c-3d30-4695-de3d00c2bc33@ideasonboard.com>","date":"2021-08-26T13:27:33","subject":"Re: [libcamera-devel] [PATCH v1 0/3] Fix Gnome Cheese and multiple\n\tcamera","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 26/08/2021 14:25, Nicolas Dufresne wrote:\n> Le jeudi 26 août 2021 à 14:23 +0100, Kieran Bingham a écrit :\n>> Hi Nicolas,\n>>\n>> On 25/08/2021 22:18, Nicolas Dufresne wrote:\n>>> From: Nicolas Dufresne \n>>>\n>>> This patchset address issues seen when trying to stream from multiple\n>>> cameras at the same time or when using Gnome Cheese software. The core\n>>> of the issue was that multiple CameraManager instances were created.\n>>> Two deadlocks were encountered during testing and are fixed.\n>>>\n>>> Nicolas Dufresne (3):\n>>> gstreamer: Fix deadlock when last allocator ref is held by buffer\n>>> gstreamer: Fix concurrent access issues to CameraManager\n>>> libcamerasrc: Fix deadlock on EOS\n>>\n>> Thank you for these,\n>>\n>> Indeed, this also fixes the hangs when shutting down I had experienced\n>> (but not yet reported)\n>>\n>> Tested-by: Kieran Bingham \n> \n> Thanks for testing, I just sent v2 before noticing, if you are happy with v2,\n> please add Kieran Tb, otherwise it will be in v3.\n\nNo worries, it looks like we hit send at the same time ;-)\n\n--\nKieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4B9BBD87D\n\tfor ;\n\tThu, 26 Aug 2021 13:27:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 594296890C;\n\tThu, 26 Aug 2021 15:27:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F5126888F\n\tfor ;\n\tThu, 26 Aug 2021 15:27:36 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B5834191F;\n\tThu, 26 Aug 2021 15:27:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"K/G34HH6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629984455;\n\tbh=+6msgx+RqypZ7zTB8sTYJ2pGqPNC2ZMqgCf/XYHF5J8=;\n\th=From:Subject:To:References:Date:In-Reply-To:From;\n\tb=K/G34HH6uOo5qcEwqn6PdF3h7Hwoq+67xT9FH/TLozRqjv0Z3qinSQ1J5CL2Sgnt6\n\t9zSmv43bTY4tws9r89kkkFCp6meUW3+YPawXle6RDcBBL0tNzdWsV0TVAHcss6YRnC\n\tzDLPWFC2gXLwtV58wbIrnas8s33DDo3nP85EeDWE=","From":"Kieran Bingham ","To":"Nicolas Dufresne ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210825211852.1207168-1-nicolas@ndufresne.ca>\n\t<216b4038-04c6-dc2e-c587-050520562fcf@ideasonboard.com>\n\t","Message-ID":"<0e2a4c08-559c-3d30-4695-de3d00c2bc33@ideasonboard.com>","Date":"Thu, 26 Aug 2021 14:27:33 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v1 0/3] Fix Gnome Cheese and multiple\n\tcamera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]