[{"id":19030,"web_url":"https://patchwork.libcamera.org/comment/19030/","msgid":"<20210825021744.GC968527@pyrite.rasen.tech>","date":"2021-08-25T02:17:44","subject":"Re: [libcamera-devel] [SimpleCam PATCH 0/4] Improve CameraManager\n\tusage and Doc","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, Aug 24, 2021 at 03:24:46PM +0100, Kieran Bingham wrote:\n> The CameraManager was not being released before the end of the\n> application. While this does not cause any direct issues, it counts as a\n> memory leak.\n> \n> Demonstrate a cleaner way to manage the CameraManager using a unique_ptr\n> to convey that the application is responsible for it's lifetime.\n> \n> Along the way, improve the documentation throughout.\n\nLooks good.\n\nReviewed-by: Paul Elder \n\n> \n> Kieran Bingham (4):\n> simple-cam: Use a unique_ptr for the CameraManager\n> simple-cam: Improve documentation of validate/configure\n> simple-cam: Fix the Buffer Allocation guidance\n> simple-cam: Correct the capitalisation of 'libcamera'\n> \n> simple-cam.cpp | 37 ++++++++++++++++++++++++++-----------\n> 1 file changed, 26 insertions(+), 11 deletions(-)\n> \n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A5C5BD87C\n\tfor ;\n\tWed, 25 Aug 2021 02:17:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6316F68892;\n\tWed, 25 Aug 2021 04:17:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 316476025B\n\tfor ;\n\tWed, 25 Aug 2021 04:17:52 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B98D24F;\n\tWed, 25 Aug 2021 04:17:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IxYFSc2w\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629857871;\n\tbh=ur6v/OVtLV/+m3AjtGjjSGrGLrFlb8CiU2ASs44GjGc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IxYFSc2w+8nWy5m4+OQsAaFEj0XqBlsV4QwwKfCf+MmPF0hl09oA2wirpgYmfM+iM\n\tX4r9ga3e7GgTDhppIFcxDJsuvLpcpPmRC3FvkAbgOGwbJGAoQH1tETcKOzS8hzOL9q\n\t/W4vfpFxBHJuXegIJGrJ0H0nw7u3Ya9zBJ8tEtEw=","Date":"Wed, 25 Aug 2021 11:17:44 +0900","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham ","Message-ID":"<20210825021744.GC968527@pyrite.rasen.tech>","References":"<20210824142450.3157833-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210824142450.3157833-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [SimpleCam PATCH 0/4] Improve CameraManager\n\tusage and Doc","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]