{"id":13459,"url":"https://patchwork.libcamera.org/api/covers/13459/?format=json","web_url":"https://patchwork.libcamera.org/cover/13459/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210824142450.3157833-1-kieran.bingham@ideasonboard.com>","date":"2021-08-24T14:24:46","name":"[libcamera-devel,SimpleCam,0/4] Improve CameraManager usage and Doc","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/13459/mbox/","series":[{"id":2388,"url":"https://patchwork.libcamera.org/api/series/2388/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2388","date":"2021-08-24T14:24:46","name":"Improve CameraManager usage and Doc","version":1,"mbox":"https://patchwork.libcamera.org/series/2388/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/13459/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8F2BABD87D\n\tfor ;\n\tTue, 24 Aug 2021 14:24:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D498B688A5;\n\tTue, 24 Aug 2021 16:24:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4612560505\n\tfor ;\n\tTue, 24 Aug 2021 16:24:55 +0200 (CEST)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C64252A5;\n\tTue, 24 Aug 2021 16:24:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ps929XYG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629815094;\n\tbh=ZrdCyUHl26EP6jauvgys3cq2459Ih5wcz+c8VRqHLAc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ps929XYG/LAHPXxnFD5FX5iPCb/oP5gvK+nm+g5zMc+IDyy2XKebTftpgXNRhDcCj\n\tNFd8FY2FRiCkdLVY+bLl+lEwBZZga2bnLGkwmE+dyILks5NXAHDSV6Nz3tKUsMTO1P\n\tQ7FOMI7KsQ9ldFhDfpCvkJFT6LLK6jFZ/tUUw98s=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Tue, 24 Aug 2021 15:24:46 +0100","Message-Id":"<20210824142450.3157833-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [SimpleCam PATCH 0/4] Improve CameraManager usage\n\tand Doc","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CameraManager was not being released before the end of the\napplication. While this does not cause any direct issues, it counts as a\nmemory leak.\n\nDemonstrate a cleaner way to manage the CameraManager using a unique_ptr\nto convey that the application is responsible for it's lifetime.\n\nAlong the way, improve the documentation throughout.\n\nKieran Bingham (4):\n simple-cam: Use a unique_ptr for the CameraManager\n simple-cam: Improve documentation of validate/configure\n simple-cam: Fix the Buffer Allocation guidance\n simple-cam: Correct the capitalisation of 'libcamera'\n\n simple-cam.cpp | 37 ++++++++++++++++++++++++++-----------\n 1 file changed, 26 insertions(+), 11 deletions(-)"}