{"id":13408,"url":"https://patchwork.libcamera.org/api/covers/13408/?format=json","web_url":"https://patchwork.libcamera.org/cover/13408/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210820065316.44343-1-jeanmichel.hautbois@ideasonboard.com>","date":"2021-08-20T06:53:07","name":"[libcamera-devel,v5,0/9] IPU3: Introduce modularity for algorithms","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/13408/mbox/","series":[{"id":2374,"url":"https://patchwork.libcamera.org/api/series/2374/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2374","date":"2021-08-20T06:53:07","name":"IPU3: Introduce modularity for algorithms","version":5,"mbox":"https://patchwork.libcamera.org/series/2374/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/13408/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0CDBBD87D\n\tfor ;\n\tFri, 20 Aug 2021 06:53:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AAF0168915;\n\tFri, 20 Aug 2021 08:53:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23FFA605A9\n\tfor ;\n\tFri, 20 Aug 2021 08:53:21 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:e43b:edb2:932:6b0a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9EF8D8C8;\n\tFri, 20 Aug 2021 08:53:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sZz62tfe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629442400;\n\tbh=BWoW02AJ9gSmxpl19bqNakoJqJFZLiXfOFotx4783AE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=sZz62tfeOx+n93vu+T76lvze+b273pybJwlp77vJaGTc6NL2LCMvJQ3Q0RDRpfSt0\n\toyBHQ9DIK2pNjgozXWLUzTtXEE0FhF/H/JXH8W7vqqkFNnQLnyqNd/MkKeC8U1ORfD\n\tXXYeMojL+yXGTBebixaCmV/rmy3NIjDZF/ul+bx4=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 20 Aug 2021 08:53:07 +0200","Message-Id":"<20210820065316.44343-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 0/9] IPU3: Introduce modularity for\n\talgorithms","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This patch series splits the algorithms in IPU3 into a modular form.\nWhen the Metadata class was discussed a proposal from Kieran was to have\na fully-defined structure which would be used to pass the context\nbetween algorithms and the IPAIPU3 class, as well as between the\nalgorithms themselves.\n\nThe algorithms are statically emplaced in a list for the moment, and a\nregistration system may be used later.\nIn order to demonstrate how to add a new algorithm, patch 5/9\nmoves the contrast algorithm from AWB into its own algorithm.\n\nPatch 6/9 and 7/9 change the AWB and AGC to use the new interface.\nAnd the two latest patches are indeed the usage of the new modular\ninterface applied to AWB and AGC.\n\nJean-Michel Hautbois (9):\n ipa: move libipa::Algorithm to ipa/ipu3/algorithms\n ipa: ipu3: Introduce a Context structure\n ipa: ipu3: Add the functions to the Algorithm class\n ipa: ipu3: Introduce modular algorithm\n ipa: ipu3: Introduce a modular tone mapping algorithm\n ipa: ipu3: convert AWB to the new algorithm interface\n ipa: ipu3: convert AGC to the new algorithm interface\n ipa: ipu3: Move IPU3 awb into algorithms\n ipa: ipu3: Move IPU3 agc into algorithms\n\n .../ipu3/{ipu3_agc.cpp => algorithms/agc.cpp} | 41 ++--\n src/ipa/ipu3/{ipu3_agc.h => algorithms/agc.h} | 32 ++--\n src/ipa/ipu3/algorithms/algorithm.cpp | 101 ++++++++++\n src/ipa/ipu3/algorithms/algorithm.h | 32 ++++\n .../ipu3/{ipu3_awb.cpp => algorithms/awb.cpp} | 168 +++++++----------\n src/ipa/ipu3/{ipu3_awb.h => algorithms/awb.h} | 26 +--\n src/ipa/ipu3/algorithms/meson.build | 8 +\n src/ipa/ipu3/algorithms/tone_mapping.cpp | 60 ++++++\n src/ipa/ipu3/algorithms/tone_mapping.h | 32 ++++\n src/ipa/ipu3/ipa_context.h | 54 ++++++\n src/ipa/ipu3/ipu3.cpp | 176 ++++++++++++++----\n src/ipa/ipu3/meson.build | 6 +-\n src/ipa/libipa/algorithm.cpp | 39 ----\n src/ipa/libipa/algorithm.h | 24 ---\n src/ipa/libipa/libipa.cpp | 22 +++\n src/ipa/libipa/meson.build | 5 +-\n 16 files changed, 566 insertions(+), 260 deletions(-)\n rename src/ipa/ipu3/{ipu3_agc.cpp => algorithms/agc.cpp} (87%)\n rename src/ipa/ipu3/{ipu3_agc.h => algorithms/agc.h} (51%)\n create mode 100644 src/ipa/ipu3/algorithms/algorithm.cpp\n create mode 100644 src/ipa/ipu3/algorithms/algorithm.h\n rename src/ipa/ipu3/{ipu3_awb.cpp => algorithms/awb.cpp} (66%)\n rename src/ipa/ipu3/{ipu3_awb.h => algorithms/awb.h} (77%)\n create mode 100644 src/ipa/ipu3/algorithms/meson.build\n create mode 100644 src/ipa/ipu3/algorithms/tone_mapping.cpp\n create mode 100644 src/ipa/ipu3/algorithms/tone_mapping.h\n create mode 100644 src/ipa/ipu3/ipa_context.h\n delete mode 100644 src/ipa/libipa/algorithm.cpp\n delete mode 100644 src/ipa/libipa/algorithm.h\n create mode 100644 src/ipa/libipa/libipa.cpp"}