[{"id":18688,"web_url":"https://patchwork.libcamera.org/comment/18688/","msgid":"<20210811015255.GX2167@pyrite.rasen.tech>","date":"2021-08-11T01:52:55","subject":"Re: [libcamera-devel] [RFC PATCH v2 0/4] pipeline: isp: The\n\tsoftware ISP Module","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Siyuan,\n\nOn Tue, Aug 10, 2021 at 01:17:38PM +0100, Siyuan Fan wrote:\n> From: Fan Siyuan \n> \n> This patch series fix some of issues raised last commits. Now the test module of\n> software isp can output the RGB888 format image.\n\nI see that this v2 is on top of v1. Your git history probably looks\nsomething like this:\n\nv2 4/4 <- HEAD\nv2 3/4\nv2 2/4\nv2 1/4\nv1 4/4\nv1 3/4\nv1 2/4\nv1 1/4\norigin/master\n\nThis won't work, as when we do merge the series we will only have the\nlatest version. We're also unable to review your patches at all, since\nwe're missing so much context. Your git history needs to be like:\n\nv2 4/4 <- HEAD\nv2 3/4\nv2 2/4\nv2 1/4\norigin/master\n\nI hope that makes sense. You can use git rebase -i to combine patches\nand modify history. Make sure to study up on it first though, so that\nyou don't destroy your git history (you can always recover by checking\nout your original HEAD).\n\n\nPaul\n\n> Patch 1/4 fixs the pipeline handler and make it more concise. Patch 2/4 moves the\n> previous ISP process to libcamera/swisp for general API interface. Patch 3/4 adds\n> the friend class CPU_ISP in class FrameBuffer to access the private member metadata_.\n> Patch 4/4 modifies the dependent file path.\n> \n> Fan Siyuan (4):\n> pipeline: isp: The software ISP-based pipeline handler\n> libcamera: swisp: Move the softawre ISP process to swisp\n> libcamera: framebuffer: Add the friend class CPU_ISP\n> pipeline: isp: Modify the dependent file path\n> \n> include/libcamera/framebuffer.h | 1 +\n> src/libcamera/pipeline/isp/isp.cpp | 81 +++++++----------\n> src/libcamera/pipeline/isp/meson.build | 4 +-\n> .../isp/isp_processing.cpp => swisp/isp.cpp} | 90 ++++++++++++++-----\n> .../isp/isp_processing.h => swisp/isp.h} | 52 ++++++++---\n> 5 files changed, 146 insertions(+), 82 deletions(-)\n> rename src/libcamera/{pipeline/isp/isp_processing.cpp => swisp/isp.cpp} (87%)\n> rename src/libcamera/{pipeline/isp/isp_processing.h => swisp/isp.h} (54%)\n> \n> -- \n> 2.20.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D74D1BD87D\n\tfor ;\n\tWed, 11 Aug 2021 01:53:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A8B960269;\n\tWed, 11 Aug 2021 03:53:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE87360269\n\tfor ;\n\tWed, 11 Aug 2021 03:53:02 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3942DEE;\n\tWed, 11 Aug 2021 03:53:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uonGJwg0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628646782;\n\tbh=WhHGSEq/18kMH4RDwKCNgKBYgnVpGASy8YoYBgb7cIc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uonGJwg0tDNrtUaUIOCFo9T1onyFJdzckZCkCtPxBSdkxvyptaf5bLPmVXl/oyUPR\n\tXBcNQp6NzaMorklPlS1n7twR7fweOLYrsksy4N9mCwgQWQ8+4aSgrC/VJuXdmBMJIl\n\tM5rH6/2cohioAzAK7MYxeMMx9TjXtgC6zv7ay7YU=","Date":"Wed, 11 Aug 2021 10:52:55 +0900","From":"paul.elder@ideasonboard.com","To":"Siyuan Fan ","Message-ID":"<20210811015255.GX2167@pyrite.rasen.tech>","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [RFC PATCH v2 0/4] pipeline: isp: The\n\tsoftware ISP Module","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]