{"id":13251,"url":"https://patchwork.libcamera.org/api/covers/13251/?format=json","web_url":"https://patchwork.libcamera.org/cover/13251/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210809092007.79067-1-jeanmichel.hautbois@ideasonboard.com>","date":"2021-08-09T09:20:02","name":"[libcamera-devel,RFC,0/5] IPU3: Introduce modularity for algorithms","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/13251/mbox/","series":[{"id":2320,"url":"https://patchwork.libcamera.org/api/series/2320/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2320","date":"2021-08-09T09:20:02","name":"IPU3: Introduce modularity for algorithms","version":1,"mbox":"https://patchwork.libcamera.org/series/2320/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/13251/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7BD70BD87D\n\tfor ;\n\tMon, 9 Aug 2021 09:20:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF8996884F;\n\tMon, 9 Aug 2021 11:20:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E3C2F687EB\n\tfor ;\n\tMon, 9 Aug 2021 11:20:15 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:14c5:c0eb:b1fb:db22])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 74B7EEE;\n\tMon, 9 Aug 2021 11:20:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JMHPJzTp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628500815;\n\tbh=Aw6BnvfWVlvq0fhzyT/EpqGFvb5wp7VoRtkmUgkhSgA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=JMHPJzTpZaNM0aVdYZwdnqPxdzhB5lRgc7lJPMSF9+z3tGk5DDuZJeo5tLjE/vgMc\n\tfOQ0QLC+AjcZcnKIGnApW4ta6gskDpqrq3SDDI3t+CKg60FhYMWH9iJ0TPhec7lJUI\n\ttuOeasCNqq02ryXLwPiSJSkijpKGEwsi01ePlr7c=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 9 Aug 2021 11:20:02 +0200","Message-Id":"<20210809092007.79067-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 0/5] IPU3: Introduce modularity for\n\talgorithms","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This patch series splits the algorithms in IPU3 into a modular form.\nWhen the Metadata class was discussed a proposal from Kieran was to have\na fully-defined structure which would be used to pass the context\nbetween algorithms and the IPAIPU3 class, as well as between the\nalgorithms themselves.\n\nThe algorithms are statically emplaced in a list for the moment, and a\nregistration system may be used later.\nIn order to demonstrate how to add a new algorithm, patch 3/5\ndemonstrates how the gamma table is calculated.\nPatch 4/5 and 5/5 move the AWB and AGC algorithms currently used.\n\nJean-Michel Hautbois (5):\n ipa: ipu3: Introduce a Context structure\n ipa: ipu3: Introduce modular algorithms\n ipa: ipu3: Introduce a modular contrast algorithm\n ipa: ipu3: Move IPU3 awb into algorithms\n ipa: ipu3: Move IPU3 agc into algorithms\n\n .../ipu3/{ipu3_agc.cpp => algorithms/agc.cpp} | 59 +++++----\n src/ipa/ipu3/{ipu3_agc.h => algorithms/agc.h} | 33 +++--\n src/ipa/ipu3/algorithms/algorithm.h | 30 +++++\n .../ipu3/{ipu3_awb.cpp => algorithms/awb.cpp} | 79 ++++--------\n src/ipa/ipu3/{ipu3_awb.h => algorithms/awb.h} | 28 +++--\n src/ipa/ipu3/algorithms/contrast.cpp | 52 ++++++++\n src/ipa/ipu3/algorithms/contrast.h | 32 +++++\n src/ipa/ipu3/algorithms/meson.build | 7 ++\n src/ipa/ipu3/ipa_context.h | 53 ++++++++\n src/ipa/ipu3/ipu3.cpp | 114 +++++++++++++-----\n src/ipa/ipu3/meson.build | 6 +-\n 11 files changed, 345 insertions(+), 148 deletions(-)\n rename src/ipa/ipu3/{ipu3_agc.cpp => algorithms/agc.cpp} (80%)\n rename src/ipa/ipu3/{ipu3_agc.h => algorithms/agc.h} (59%)\n create mode 100644 src/ipa/ipu3/algorithms/algorithm.h\n rename src/ipa/ipu3/{ipu3_awb.cpp => algorithms/awb.cpp} (78%)\n rename src/ipa/ipu3/{ipu3_awb.h => algorithms/awb.h} (77%)\n create mode 100644 src/ipa/ipu3/algorithms/contrast.cpp\n create mode 100644 src/ipa/ipu3/algorithms/contrast.h\n create mode 100644 src/ipa/ipu3/algorithms/meson.build\n create mode 100644 src/ipa/ipu3/ipa_context.h"}