[{"id":18638,"web_url":"https://patchwork.libcamera.org/comment/18638/","msgid":"<20210809165903.lbhwp3fppfqzdhjg@uno.localdomain>","date":"2021-08-09T16:59:03","subject":"Re: [libcamera-devel] [PATCH 0/4] ipu3: Change sensor size\n\tselection policy","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Umang,\n\nOn Tue, Aug 03, 2021 at 07:02:01PM +0530, Umang Jain wrote:\n> The series is geared towards addressing sensor selection constraints\n> on soraka and nautilus. 1/4 and 2/4 prepares the base to highlight\n> the change in selection policy. 3/4 and 4/4 is the actual change.\n>\n> The constraints are documented in the commit messages of 3/4 and 4/4.\n>\n> Jacopo Mondi (1):\n> ipu3: cio2: Change sensor size selection policy\n>\n> Umang Jain (3):\n> libcamera: camera_sensor: Transform CameraSensor::sizes()\n> ipu3: cio2: Replicate CameraSensor::getFormats() to a member function\n> ipu3: cio2: Tweak sensor size selection policy\n\nI've tested this series with applied on top the patch that has been\ncirculating around to use the 'optimal' sensor size instead of always\ndefaulting to the max resolution in the IPU3 pipeline handler.\n\nI've noticed no regressions in CTS due to size configuration issues,\nso you can add\n\nTested-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> include/libcamera/internal/camera_sensor.h | 2 +-\n> src/libcamera/camera_sensor.cpp | 36 +++++--\n> src/libcamera/pipeline/ipu3/cio2.cpp | 110 +++++++++++++++++++--\n> src/libcamera/pipeline/ipu3/cio2.h | 3 +\n> test/camera-sensor.cpp | 2 +-\n> 5 files changed, 135 insertions(+), 18 deletions(-)\n>\n> --\n> 2.31.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C948BD87D\n\tfor ;\n\tMon, 9 Aug 2021 16:58:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D99B968826;\n\tMon, 9 Aug 2021 18:58:15 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE53260269\n\tfor ;\n\tMon, 9 Aug 2021 18:58:14 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 4CF06240006;\n\tMon, 9 Aug 2021 16:58:13 +0000 (UTC)"],"Date":"Mon, 9 Aug 2021 18:59:03 +0200","From":"Jacopo Mondi ","To":"Umang Jain ","Message-ID":"<20210809165903.lbhwp3fppfqzdhjg@uno.localdomain>","References":"<20210803133205.6599-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210803133205.6599-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 0/4] ipu3: Change sensor size\n\tselection policy","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]