[{"id":18441,"web_url":"https://patchwork.libcamera.org/comment/18441/","msgid":"<20210730082832.152626-5-umang.jain@ideasonboard.com>","date":"2021-07-30T08:28:29","subject":"[libcamera-devel] [PATCH v2 0/3] android: Handle internal UVC\n\tcameras","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"libcamera-core all UVC cameras as 'external' (which makes sense\nas there is not much information to accurately determine location).\nHowever, in the HAL layer, we can probably determine accurately\nby looking at HAL config file camera entries.\n\nThis series addresses the handling of such cameras, where the libcamera\nreports properties::CameraLocationExternal, but we know one of the UVC\nis internal/integrated to the system. It should be treated as internal.\n\nTesting:\nWith nautilus, it has one UVC and one IPU3 cameras. With these patches\napplied, both these cameras have id as '0' & '1' (i.e. internal).\n\nWith camera service still running, I hotplugged a external UVC camera,\nand it got the camera numerical id as '1000'.\n\nChange in v2:\n- Introduce a re-factor patch 1/3\n- Change comments in 2/3\n\nUmang Jain (3):\n android: Instantiate CameraDevice after checking HAL config validity\n android: Override camera is \"Internal\" provided if found on HAL config\n android: nautilus: Add camera HAL configuration\n\n src/android/camera_device.cpp | 10 +++++++++-\n src/android/camera_hal_manager.cpp | 24 ++++++++++++++++++++---\n src/android/data/nautilus/camera_hal.yaml | 8 ++++++++\n 3 files changed, 38 insertions(+), 4 deletions(-)\n create mode 100644 src/android/data/nautilus/camera_hal.yaml","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FA9CC322E\n\tfor ;\n\tFri, 30 Jul 2021 08:28:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD183687BE;\n\tFri, 30 Jul 2021 10:28:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6A3A687BD\n\tfor ;\n\tFri, 30 Jul 2021 10:28:55 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CD8FE89B;\n\tFri, 30 Jul 2021 10:28:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SwLz9S92\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627633735;\n\tbh=O4jpMnBnzFzWjeObj3rlQZpR+hGm3UyhFF4U7yj12uE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SwLz9S92HVQfKvekmr7XMdFt16dED0nSGUHDLUTehw6dHluiFopdaBwnAbQiC0UCY\n\t95pBJ31j5EjK7XMW2A0/5Pjed1z1KrnDuzDjMK1SJx+Fqcw4cE9LEOWd0IHop8XUhu\n\tMD53K7wA4FeryujSzBLmrCN6S/znCZHI64CR1vQk=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Jul 2021 13:58:29 +0530","Message-Id":"<20210730082832.152626-5-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210730082832.152626-1-umang.jain@ideasonboard.com>","References":"<20210730082832.152626-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 0/3] android: Handle internal UVC\n\tcameras","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18442,"web_url":"https://patchwork.libcamera.org/comment/18442/","msgid":"<70d7eb51-6be7-6c65-5789-5fe5c4030d23@ideasonboard.com>","date":"2021-07-30T08:30:27","subject":"Re: [libcamera-devel] [PATCH v2 0/3] android: Handle internal UVC\n\tcameras","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Ouch, didn't delete patch dir before sending new series, please ignore!\n\nThanks!\n\nOn 7/30/21 1:58 PM, Umang Jain wrote:\n> libcamera-core all UVC cameras as 'external' (which makes sense\n> as there is not much information to accurately determine location).\n> However, in the HAL layer, we can probably determine accurately\n> by looking at HAL config file camera entries.\n>\n> This series addresses the handling of such cameras, where the libcamera\n> reports properties::CameraLocationExternal, but we know one of the UVC\n> is internal/integrated to the system. It should be treated as internal.\n>\n> Testing:\n> With nautilus, it has one UVC and one IPU3 cameras. With these patches\n> applied, both these cameras have id as '0' & '1' (i.e. internal).\n>\n> With camera service still running, I hotplugged a external UVC camera,\n> and it got the camera numerical id as '1000'.\n>\n> Change in v2:\n> - Introduce a re-factor patch 1/3\n> - Change comments in 2/3\n>\n> Umang Jain (3):\n> android: Instantiate CameraDevice after checking HAL config validity\n> android: Override camera is \"Internal\" provided if found on HAL config\n> android: nautilus: Add camera HAL configuration\n>\n> src/android/camera_device.cpp | 10 +++++++++-\n> src/android/camera_hal_manager.cpp | 24 ++++++++++++++++++++---\n> src/android/data/nautilus/camera_hal.yaml | 8 ++++++++\n> 3 files changed, 38 insertions(+), 4 deletions(-)\n> create mode 100644 src/android/data/nautilus/camera_hal.yaml\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8F2B3C322E\n\tfor ;\n\tFri, 30 Jul 2021 08:30:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49BB5687BD;\n\tFri, 30 Jul 2021 10:30:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 687DE687B1\n\tfor ;\n\tFri, 30 Jul 2021 10:30:32 +0200 (CEST)","from [192.168.1.104] (unknown [103.251.226.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C658089B\n\tfor ;\n\tFri, 30 Jul 2021 10:30:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Xdg9/GMY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627633832;\n\tbh=Zy6Eq3St8LD6vDryNDk2Tg1VcrZH/RxrtMPzZkysL2g=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Xdg9/GMYKxZgDN4EXDOLRChuNXV42Upaik6SM8YZIrpyuT8sNKlcTI1wGejZj1S3z\n\tYV5u/RayMppuWKf4XzWSO52zSSkzhtcyhspokB2GgxppeHwhgj70M8LvejRtcD0ofT\n\t0WZIPH58qDaMnZ3lnRKswFU7m5qZ4t55QOltGzzs=","To":"libcamera-devel@lists.libcamera.org","References":"<20210730082832.152626-1-umang.jain@ideasonboard.com>\n\t<20210730082832.152626-5-umang.jain@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<70d7eb51-6be7-6c65-5789-5fe5c4030d23@ideasonboard.com>","Date":"Fri, 30 Jul 2021 14:00:27 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210730082832.152626-5-umang.jain@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v2 0/3] android: Handle internal UVC\n\tcameras","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]