[{"id":18461,"web_url":"https://patchwork.libcamera.org/comment/18461/","msgid":"","date":"2021-08-01T23:17:43","subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: pipeline: Add internal\n\trequest queue","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nícolas,\n\nThank you for the series.\n\nOn Mon, Jul 19, 2021 at 04:14:35PM -0300, Nícolas F. R. A. Prado wrote:\n> This series adds an internal request queue for the rkisp1, uvcvideo and vimc\n> pipeline handlers. Each patch is independent of the others, but I've grouped\n> them in this series because they're very similar, so it should ease the review.\n> \n> The patches here are based on these patches that added the same functionality\n> for the ipu3 pipeline handler: 5a9d19210fad (\"libcamera: pipeline: ipu3: Try\n> queuing pending requests if a buffer is available\") and 89dae5844964\n> (\"libcamera: pipeline: ipu3: Store requests in the case a buffer shortage\").\n> \n> With these patches applied, the lc-compliance test from [1] passes in all three\n> pipeline handlers.\n\nGiven that this is a pattern that every pipeline handler needs to\nimplement, would you be able to document it in the pipeline handler\nwriter's guide ?\n\n> [1] https://lists.libcamera.org/pipermail/libcamera-devel/2021-July/022356.html\n> \n> Previous standalone versions of the patches: uvcvideo [2] and rkisp1 [3]\n> \n> [2] https://lists.libcamera.org/pipermail/libcamera-devel/2021-July/022029.html\n> [3] https://lists.libcamera.org/pipermail/libcamera-devel/2021-July/022135.html\n> \n> Nícolas F. R. A. Prado (3):\n> libcamera: pipeline: vimc: Add internal request queue\n> libcamera: pipeline: uvcvideo: Add internal request queue\n> libcamera: pipeline: rkisp1: Add internal request queue\n> \n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 73 ++++++++++++++++----\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 66 +++++++++++++++---\n> src/libcamera/pipeline/vimc/vimc.cpp | 65 ++++++++++++++---\n> 3 files changed, 170 insertions(+), 34 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1DBA1C3232\n\tfor ;\n\tSun, 1 Aug 2021 23:17:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E388687BD;\n\tMon, 2 Aug 2021 01:17:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BBE4C687B6\n\tfor ;\n\tMon, 2 Aug 2021 01:17:53 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 38BD787C;\n\tMon, 2 Aug 2021 01:17:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SAK4hjOV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627859873;\n\tbh=Mp42JctbTzWGlRyw4IIQ/buuwAQn6BF7C1aTPT12riQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SAK4hjOVwRp2nRFqW6l112NUdufDtyUWsD9PaElgC8X8hhgkpb81tbOQaKXf7gz6g\n\tLQ3hkrG2B5u/hTS5AP3MaZBhNbq3RLmnrIvjKc3ifJHXqbEor1jALlR2A4iHO79FXS\n\tp10+kyiUb7XekI+HXVkzPPpGOcRSl9O7XpgvxU9c=","Date":"Mon, 2 Aug 2021 02:17:43 +0300","From":"Laurent Pinchart ","To":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4=?= Prado ","Message-ID":"","References":"<20210719191438.189046-1-nfraprado@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20210719191438.189046-1-nfraprado@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: pipeline: Add internal\n\trequest queue","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org, kernel@collabora.com, =?utf-8?q?A?=\n\t=?utf-8?b?bmRyw6k=?= Almeida ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]