[{"id":1703,"web_url":"https://patchwork.libcamera.org/comment/1703/","msgid":"<20190525125333.GD6678@bigcity.dyn.berto.se>","date":"2019-05-25T12:53:33","subject":"Re: [libcamera-devel] [PATCH v3 0/2] cam: cleanup code structure","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi,\n\nI have pushed this series to master.\n\nOn 2019-05-24 10:23:31 +0200, Niklas Söderlund wrote:\n> Hi,\n> \n> Before adding new features to the cam utility there is a need to clean\n> up some of the organic growth that has happened.\n> \n> This series breaks out the capture logic to a new class and reduces the\n> mess in main.cpp.\n> \n> Niklas Söderlund (2):\n> cam: capture: Break out capture to a new class\n> cam: Add CamApp class\n> \n> src/cam/capture.cpp | 248 +++++++++++++++++++++++++++\n> src/cam/capture.h | 42 +++++\n> src/cam/main.cpp | 408 ++++++++++++++------------------------------\n> src/cam/main.h | 19 +++\n> src/cam/meson.build | 1 +\n> 5 files changed, 437 insertions(+), 281 deletions(-)\n> create mode 100644 src/cam/capture.cpp\n> create mode 100644 src/cam/capture.h\n> create mode 100644 src/cam/main.h\n> \n> -- \n> 2.21.0\n>","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84D2F60BBB\n\tfor ;\n\tSat, 25 May 2019 14:53:35 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id m15so10909999ljg.13\n\tfor ;\n\tSat, 25 May 2019 05:53:35 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tr27sm1145649lfp.73.2019.05.25.05.53.34\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 25 May 2019 05:53:34 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=boFAKyuYfLXlH6ZftuqUp39uwdJv+l45lvOsdiHnWAc=;\n\tb=NBCNVCW++k2vDslC1FYZsRZGkS39g83RERc+0ENwHHvOWRFOsdRm3tLKGS0nf866kr\n\tU4KSsRuO8+JCaZuu5tW2LtbwO9eG3spvOqP6gRmYpZsFce3dTZJN/Ezj1H91+iNltQP4\n\tASlSQk43hJSt52EWvipwtLte1b/swxsP/5zsmHN0L8ZyFJ5rFwlUdgSlkQPBbW0f/Ape\n\ttvaKypAdi1oC+xZilYE7L/7A5mxV9uaYtWxqJNX6vSwCqvcSp/kUS+gw4oO25xE7NxB/\n\tG27+r2OOn0W5cgnkHMLIi4nzPLL3c0sbvNJ4PqE+Js+n40qdvqaFgFhWLKSbKTg8WczE\n\trRdg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=boFAKyuYfLXlH6ZftuqUp39uwdJv+l45lvOsdiHnWAc=;\n\tb=gurnNPUjKVpHm/ONgxddW/zvdYGNllpqRl9M+xM3jKPgRrmUYYYojioRG8iTQf6PQm\n\tlRq6+5xeowuJ1OfDgZFIVc4rvaqQ+DTs9E5RIB5Hv0PT+wKPGtPeb4kPv5R29F03SVds\n\tmCUGyk+TlbJKzJA8c5uKX85VB4OMxBhFNGW3uBt3181dZunStem2VBrmLlUWKtdFEhm4\n\tri+pEE54S7RwCMI1Sv5MNonDW6GfAY9vNRputmjTioQpcuTHY9ZvKqLICbMpAqvxAwFS\n\tU1kNoonKluvKrrMuB4iQ9sEBpPtm4LVlc1ZTaYhe2znyZFWtlDyQTM87Rt8aKBve5plA\n\tkkrA==","X-Gm-Message-State":"APjAAAVhc+hGbcliUJ9o2dabr3EDyn/PwEyksj/lviE8OClFRwOwJjT+\n\tqMj20PpoVZcWqofZP+yizZ/i0UUpcwc=","X-Google-Smtp-Source":"APXvYqyaoozbRfX16G0SwxPHYnkRVjYUvz9oJ44qVIWfb1ympewBr06pakkgTU9zxiRMUswAFYg6qw==","X-Received":"by 2002:a2e:301a:: with SMTP id\n\tw26mr42161509ljw.153.1558788814843; \n\tSat, 25 May 2019 05:53:34 -0700 (PDT)","Date":"Sat, 25 May 2019 14:53:33 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190525125333.GD6678@bigcity.dyn.berto.se>","References":"<20190524082333.8974-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190524082333.8974-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.11.4 (2019-03-13)","Subject":"Re: [libcamera-devel] [PATCH v3 0/2] cam: cleanup code structure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 25 May 2019 12:53:35 -0000"}}]