[{"id":19791,"web_url":"https://patchwork.libcamera.org/comment/19791/","msgid":"","date":"2021-09-22T12:33:23","subject":"Re: [libcamera-devel] [PATCH 0/2] Application support for per-mode\n\tsensitivities","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi everyone\n\nThis seems to have become a rather forgotten patch set (also here:\nhttps://patchwork.libcamera.org/project/libcamera/list/?series=2183).\nIn fact it's so old I'd managed to lose the original email that I\nsent! So I was wondering if I might give folks a little nudge for some\nthoughts on this.\n\nThanks!\nDavid\n\nOn Wed, 22 Sept 2021 at 13:27, Naushir Patuck wrote:\n>\n>\n>\n> ---------- Forwarded message ---------\n> From: David Plowman \n> Date: Mon, 28 Jun 2021 at 09:56\n> Subject: [libcamera-devel] [PATCH 0/2] Application support for per-mode sensitivities\n> To: \n>\n>\n> Hi everyone\n>\n> Here's that potentially \"missing piece\" of support for per-mode\n> sensitivities. The question was how an application could get hold of\n> the selected mode's sensitivity before starting the camera, and\n> solution implemented here returns it in the CameraConfiguration\n> object.\n>\n> There are two patches, and they would need to be applied on top of the\n> first set of \"per-mode sensitivities\" patches.\n>\n> 1. The first patch merely adds a modeSensitivity field to the\n> CameraConfiguration and documents it.\n>\n> 2. The second patch returns the correct value from the Raspberry Pi\n> pipeline handler. I note that if CamHelpers move out of the IPA and\n> over to the pipeline handler, then this could become rather simpler.\n>\n> Thanks in advance for any feedback.\n>\n> Best regards\n> David\n>\n> David Plowman (2):\n> libcamera: camera: add a mode sensitivity field\n> libcamera: raspberrypi: fetch correct value for sensor's\n> modeSensitivity\n>\n> include/libcamera/camera.h | 2 ++\n> include/libcamera/ipa/raspberrypi.mojom | 7 ++++++-\n> src/ipa/raspberrypi/raspberrypi.cpp | 7 +++++--\n> src/libcamera/camera.cpp | 16 +++++++++++++++-\n> .../pipeline/raspberrypi/raspberrypi.cpp | 9 ++++++---\n> 5 files changed, 34 insertions(+), 7 deletions(-)\n>\n> --\n> 2.20.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93C24BDC71\n\tfor ;\n\tWed, 22 Sep 2021 12:33:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C50146918C;\n\tWed, 22 Sep 2021 14:33:35 +0200 (CEST)","from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B853E6917F\n\tfor ;\n\tWed, 22 Sep 2021 14:33:34 +0200 (CEST)","by mail-wr1-x434.google.com with SMTP id t7so6175913wrw.13\n\tfor ;\n\tWed, 22 Sep 2021 05:33:34 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"cTYWPwbW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=9sJAQIfyKGRaf1jIgYcawJD/s/uEF60ryakIQYcAVJk=;\n\tb=cTYWPwbWjOUKmYb8ZhVvUD0jqr4jombRnymHXu5qv9IBLm98WZI2gSmQCzs/zTA8cu\n\toLiSilOh6D6+v1G2XyTwwaUnEsNGmB9vYCZifK7HW8ihVe6Rlys1fvEMOm1c/jGCQji+\n\t2sDrG7rX2XICzp31cqHan5NcPiXr9pWzXqKTL0BqLEePBDw7ov9AJ2cJ+hvz9ZAaAmO2\n\tugl8xpDL2UWOIuCHdrnEWvCa2VWsKmSQvQcOA3az+snj+sSHQkFIm7CRy5QCvWIn9SWx\n\tdb42qaSrNAgjp18AxZeh97zipUNqJsk5uELVTuS//fOzi8B5+YyaeCFlAh235zwgTy1f\n\tTq7Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=9sJAQIfyKGRaf1jIgYcawJD/s/uEF60ryakIQYcAVJk=;\n\tb=Ndycs2GW90OI+yljDGhQinhTPbUivZEUIfD73sfeIrRX9igug4CgpuaaGWpPc5rO/6\n\txyfV7PdMdxS3xdUAFdTYXDIP7+Eh1vdlIqV2PdFUHIofOvp5KhFQRfcPGiIj3V6dKG7+\n\tRmrKyOymzBIh+CE5CCTpVohiyL4t692AWUQ1lDXtZ9l3J1nEqBt2NQz9tGHFCsISHqBk\n\tHq6oSaAFZyz1if1n3cUvpX3x2pyRay9iJ5PVg7+0hOOr17tdy/LWNIpjGaFEBM1+/xus\n\t+/deUxQKtM9ZZfv6IPGkJdW+TMS/36KoZynwo+vPm+aspsueM+Mndhcp/ukFqOczO2Op\n\t+o7w==","X-Gm-Message-State":"AOAM5311KUgefG3bjm7OfdqHCXnF5Beoz+k4OKYnEB/oEiliy/6TW+zj\n\tW0N0DHc0jDA/5r238g9Sa9Hrmigacnko5G2m6tPB/U8ifJx4sxWK","X-Google-Smtp-Source":"ABdhPJwEQSyLbmJ+uG0h07490eoQzVpNTOt8B/LrDFqGtGDIUwZPiBh5aqazaKeY/mSQMQhUrlU8L+PIg6wK2Lt03UI=","X-Received":"by 2002:a7b:c74b:: with SMTP id\n\tw11mr10236961wmk.21.1632314014327; \n\tWed, 22 Sep 2021 05:33:34 -0700 (PDT)","MIME-Version":"1.0","References":"<20210628085630.2081-1-david.plowman@raspberrypi.com>\n\t","In-Reply-To":"","From":"David Plowman ","Date":"Wed, 22 Sep 2021 13:33:23 +0100","Message-ID":"","To":"Naushir Patuck , \n\tlibcamera devel ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 0/2] Application support for per-mode\n\tsensitivities","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]