{"id":12684,"url":"https://patchwork.libcamera.org/api/covers/12684/?format=json","web_url":"https://patchwork.libcamera.org/cover/12684/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210622134652.1279260-1-andrey.konovalov@linaro.org>","date":"2021-06-22T13:46:43","name":"[libcamera-devel,v5,0/9] qcam: viewfinder_gl: add RAW8, RAW10P and RAW12P formats","submitter":{"id":25,"url":"https://patchwork.libcamera.org/api/people/25/?format=json","name":"Andrey Konovalov","email":"andrey.konovalov@linaro.org"},"mbox":"https://patchwork.libcamera.org/cover/12684/mbox/","series":[{"id":2168,"url":"https://patchwork.libcamera.org/api/series/2168/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2168","date":"2021-06-22T13:46:43","name":"qcam: viewfinder_gl: add RAW8, RAW10P and RAW12P formats","version":5,"mbox":"https://patchwork.libcamera.org/series/2168/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/12684/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C9CAC321B\n\tfor ;\n\tTue, 22 Jun 2021 13:47:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B29A60294;\n\tTue, 22 Jun 2021 15:47:01 +0200 (CEST)","from mail-lj1-x230.google.com (mail-lj1-x230.google.com\n\t[IPv6:2a00:1450:4864:20::230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66CF860292\n\tfor ;\n\tTue, 22 Jun 2021 15:46:59 +0200 (CEST)","by mail-lj1-x230.google.com with SMTP id z22so30196993ljh.8\n\tfor ;\n\tTue, 22 Jun 2021 06:46:59 -0700 (PDT)","from localhost.localdomain ([85.249.44.185])\n\tby smtp.googlemail.com with ESMTPSA id\n\tb19sm163125ljo.37.2021.06.22.06.46.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Jun 2021 06:46:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"cKYkjAMF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=ZTq8/06QldmiwIm3mjhHCMxENRg+Cvc3AeSeYmUdZlQ=;\n\tb=cKYkjAMF5QnALTn1NkFlS0DoRFk/xHjsw4XAg684UOvfafNM0WmMLxwxsQAimvIAL8\n\tWUUzZw4SasCTnDR1Nfy2xrAExmxRb3y8V0AVtOj7j/FPrRjv+9pGck3EuP0EbAxA1SFa\n\tD/qL3wEbKh+XgNEJk/WFOTn5CaXYznsGyna0Q+4ildOeubfRI34Hgi2TKilN/n0mJPJV\n\tzk+zJHXuPRIpDdy1X7dQOSdXJ3hn/BVIOKhx/e9jnANK+erpTAMZf7ETVELWkd99XJ5b\n\trtI3H9qKIcp4dSJNhQANhvj6MS1oBOxxwj3d+ddWaSsn7P+CmYJWiP1ixWw0F6i93eRR\n\tEMXg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=ZTq8/06QldmiwIm3mjhHCMxENRg+Cvc3AeSeYmUdZlQ=;\n\tb=Lp8DwUem6K2W2a/mFSKY1nyZVHrQafmAhNaKqZHG3PZfp9HTzfnywRW/0I1eJu7ATN\n\txfl+zK+nPzR2OMnGPx+gI/26/nEvLqItMHVImAvqr9h024ps9r/ZCoda/pfhQiY6ohrj\n\te0EJFxpuh8WRC0xPlSD3E5nSiRfQV3chzE2LvO/bac/O3IKen8eKPX+5lb9gW9d9mMbw\n\tQfNdUKOyqgKJSECu3ZSCEBdKEyklroEDal9YNf0IxbEqPJGzMFBKllEZzHsURu8HuB28\n\tu6ZZJhRFn6ocdfzq5+zdDF5r9HEWceuFQLsCQ8ceodpJLXITdC2iaSbSuIXp6zBFUrLj\n\tSRjg==","X-Gm-Message-State":"AOAM531+wrlSJWsTXGr0dkKVLIreUamKmSbq9WwGj+1q1WxlQzAGpp1N\n\tPRIejT+Tf2VuSwC5/xsOnTLIE8CenVWo2w==","X-Google-Smtp-Source":"ABdhPJynq4CnHpzDv5i+q/vV+jbdxw+VmWneKwhwKKRHd+tIfmnYUnRsJZfxpQvh5gdMHDM1LERhaw==","X-Received":"by 2002:a2e:9e17:: with SMTP id\n\te23mr3267440ljk.177.1624369618756; \n\tTue, 22 Jun 2021 06:46:58 -0700 (PDT)","From":"Andrey Konovalov ","To":"libcamera-devel@lists.libcamera.org,\n\tlaurent.pinchart@ideasonboard.com","Date":"Tue, 22 Jun 2021 16:46:43 +0300","Message-Id":"<20210622134652.1279260-1-andrey.konovalov@linaro.org>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 0/9] qcam: viewfinder_gl: add RAW8,\n\tRAW10P and RAW12P formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"morgan@casual-effects.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This patchset adds support for both 10-bit, and 12-bit raw Bayer packed\nand 8-bit raw Bayer formats. GL_RED texture is used to store the image data.\nNot only this allows to use the same shader code in 10-bit and 12-bit cases.\nBut it also turned out that sampling from GL_RED texture is easier (less\n\"patterns\") than from GL_RGB - even though we loose the \"auto-skipping the LS\nbytes of pixel values\" feature in the 12-bit case.\n\nChanges in v5 vs v4 [1]:\n* 8-bit raw Bayer format is back, but it is now split into several patches\n (4/9 to 8/9) to make it easier to see the particular changes done to\n the original shader code.\n With the first 8 of the total 9 patches applied I am seeing some\n artifacts (note the horizontal colour lines which change when the viewfinder\n window height is changed) [2].\n Patch 9/9 fixes that, but the root cause of the issue isn't currently known.\n That's why 9/9 comes as RFC, and the series can be merged without it.\n* s/tex_raw/tex_y in the shaders to match the uniform name used in the cpp\n code.\n\n[1] https://patchwork.libcamera.org/cover/12629/\n[2] https://people.linaro.org/~andrey.konovalov/cam-56/20210622.imx219-RAW8-artifacts.viewfinder_gl-add-RAW1xP-and-RAW8-support-v4.1-raw8.0.mp4"}