{"id":12681,"url":"https://patchwork.libcamera.org/api/covers/12681/?format=json","web_url":"https://patchwork.libcamera.org/cover/12681/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210622132014.949961-1-naush@raspberrypi.com>","date":"2021-06-22T13:20:12","name":"[libcamera-devel,v2,0/2] Raspberry Pi: Metadata parsing improvements (II)","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/12681/mbox/","series":[{"id":2167,"url":"https://patchwork.libcamera.org/api/series/2167/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2167","date":"2021-06-22T13:20:12","name":"Raspberry Pi: Metadata parsing improvements (II)","version":2,"mbox":"https://patchwork.libcamera.org/series/2167/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/12681/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1E7AC321B\n\tfor ;\n\tTue, 22 Jun 2021 13:20:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D02AF6893C;\n\tTue, 22 Jun 2021 15:20:22 +0200 (CEST)","from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FA5160292\n\tfor ;\n\tTue, 22 Jun 2021 15:20:20 +0200 (CEST)","by mail-wm1-x32c.google.com with SMTP id\n\tj21-20020a05600c1c15b02901dde2accccbso2238230wms.4\n\tfor ;\n\tTue, 22 Jun 2021 06:20:20 -0700 (PDT)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:28d:3aa5:c82:cbf1])\n\tby smtp.gmail.com with ESMTPSA id\n\tk5sm2632213wmk.11.2021.06.22.06.20.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Jun 2021 06:20:19 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"BWvF/0nd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=2tczdIYqHtHFR1mRHRjxoOQNwgzL1thwZCrJ3kNeMJs=;\n\tb=BWvF/0nd4P9uX6i/Qo2BK9oLaRepTbqfhaX3tR9zLFLBILZmNsrzwmbDkORPCyqI7P\n\ttAJVYPq59frjyTJqTGa9gyMv87n8tcwwmM4jWoXMA4M+lhDqwHIpranT8Dfm0Dvxn/RG\n\tWKzoyZML1k1TXr4ZSDKQPJnFFuS5Q6+8Ax6UXHRsJwIo8MvZbYzEKu4oQeJZPxcDzPu0\n\twP6SK63RswkMYRfVz8wvoz9gACYG8/CXSFvawFpCbEJ3Jr1wTvcOe2j7Es4H5HeV71pO\n\tYIZU5fHdlIIwafIwal7rOuoeV4b/Teikn7mVMq4L5lvJ/7S25BXlTJ7VLU53bjE6txSO\n\t4uxA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=2tczdIYqHtHFR1mRHRjxoOQNwgzL1thwZCrJ3kNeMJs=;\n\tb=Zg6SE2hV+OokT3ZSIwptmWl5jEyeeLfIMOQwksAhB9/vbUyrU1pCh4Y9ePYJZRYXjv\n\tg50C4Xrkjf6DlKO+ZH98Sl/NNnTeEbMN20Mv2e6ptuFO6e1PEc215HXSFszVNkJv+08N\n\t76E7C+/p6sTZ9aeicdN+OgUnbyfx8fMDJVan6AeL8/hGlOsmLS+0QXUmXOdzyK6dllye\n\t8HtjgT3QOHoQ0xTL+ofvYWlu42Gc6Jaj4DvRGwEGAEEc6JIm6D3eSVLHsHzKns4oYP6n\n\tNFD7c8fcxAneyatNHgE8ZQXQSuhgR17swNLtcqC3iRuDX9Q799FVdpYHKIeHeLpEn9Dz\n\t0TZQ==","X-Gm-Message-State":"AOAM531TviuEqeXIFmbW5ZFmsoTaNEX3NbLj7uReOGQfNwTAkrCuat7k\n\tAi85JNONsKl5ZpDKwRouDLfAhrrIIzLIWQ==","X-Google-Smtp-Source":"ABdhPJwdIUvRpZ4iqrB/bMzjjinKbje+1suVuKn6WHjsOhFLrm8loXCzYnc7MirL6I+dpDYGQdxZjw==","X-Received":"by 2002:a7b:cc10:: with SMTP id f16mr4437015wmh.24.1624368020354;\n\tTue, 22 Jun 2021 06:20:20 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 22 Jun 2021 14:20:12 +0100","Message-Id":"<20210622132014.949961-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 0/2] Raspberry Pi: Metadata parsing\n\timprovements (II)","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi,\n\nHere is version 2 of this series. The following changes have been introduced\nover v1:\n\n- Rework patch 1/2 to use a unique_ptr to store the parser object in the\nCamHelper class.\n- Switch to using std::initialiser_list in the constructor of MdParserSmia.\n- All suggestions from Laurent's feedback have been addressed in patch 2/2.\n\nThe constructor for the unique_ptr in patch 2/2 looks a bit\nawkward now since I have to explicitly write std::initialiser_list within\nstd::make_unique, but I cannot see nice way around this.\n\nI have removed all previous tags from 1/2, as this is a completely different\napproach to the previous revision.\n\nThanks,\nNaush\n\nNaushir Patuck (2):\n ipa: raspberrypi: Use a unique_ptr for the metadata parser\n ipa: raspberrypi: Generalise the SMIA metadata parser\n\n src/ipa/raspberrypi/cam_helper.cpp | 38 ++++---\n src/ipa/raspberrypi/cam_helper.hpp | 7 +-\n src/ipa/raspberrypi/cam_helper_imx219.cpp | 117 ++++----------------\n src/ipa/raspberrypi/cam_helper_imx290.cpp | 2 +-\n src/ipa/raspberrypi/cam_helper_imx477.cpp | 123 ++++------------------\n src/ipa/raspberrypi/cam_helper_ov5647.cpp | 2 +-\n src/ipa/raspberrypi/md_parser.hpp | 42 +++++---\n src/ipa/raspberrypi/md_parser_smia.cpp | 66 ++++++++++--\n 8 files changed, 155 insertions(+), 242 deletions(-)"}