[{"id":17673,"web_url":"https://patchwork.libcamera.org/comment/17673/","msgid":"","date":"2021-06-22T00:29:23","subject":"Re: [libcamera-devel] [PATCH 1/2] android: Sort source files\n\talphabetically","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo, thank you for the patch.\n\nOn Tue, Jun 22, 2021 at 12:29 AM Jacopo Mondi wrote:\n\n> Sort the list of the Android HAL source file alphabetically.\n>\n> Signed-off-by: Jacopo Mondi \n>\n\nI expect this is detected by the style check script, isn't it?\n\nReviewed-by: Hirokazu Honda \n\n> ---\n> src/android/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index 3893e5b5b832..f27fd5316705 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -44,9 +44,9 @@ subdir('cros')\n>\n> android_hal_sources = files([\n> 'camera3_hal.cpp',\n> - 'camera_hal_manager.cpp',\n> 'camera_device.cpp',\n> 'camera_hal_config.cpp',\n> + 'camera_hal_manager.cpp',\n> 'camera_metadata.cpp',\n> 'camera_ops.cpp',\n> 'camera_stream.cpp',\n> --\n> 2.31.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC8CEBE58C\n\tfor ;\n\tTue, 22 Jun 2021 00:29:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B8BD6893A;\n\tTue, 22 Jun 2021 02:29:37 +0200 (CEST)","from mail-ej1-x630.google.com (mail-ej1-x630.google.com\n\t[IPv6:2a00:1450:4864:20::630])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BDF86050B\n\tfor ;\n\tTue, 22 Jun 2021 02:29:35 +0200 (CEST)","by mail-ej1-x630.google.com with SMTP id nd37so31678460ejc.3\n\tfor ;\n\tMon, 21 Jun 2021 17:29:35 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"V2Ds5lqH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Uu5Gw0Kiq6iEqAEiPqthXevW67UTfZh3wkU+3xpi+hw=;\n\tb=V2Ds5lqH/vaWwHbr0cvTj45TPMDRA4K8IJ1j79AW6iwJ5mpqO8ikLoip/vzO2+spqE\n\teGtFo0/KTFeP/pcM60hKPyyZ9+oZOc+Aw3qotNU+bAnrj/GMf54ZzWDtCAFstqSJPaq5\n\tnswiKFi5EH2mzRaFR/OxoJciQsEn9bP05kmO8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Uu5Gw0Kiq6iEqAEiPqthXevW67UTfZh3wkU+3xpi+hw=;\n\tb=ViZUHVJscB16rdibyDTfJHXL28Wb+ftAjyy6lS3mhZqJfc+rYGA32MejADYHUNutZi\n\tCZ3sgP4xmuG9N6sHEjoJdVQSDjHaddmQigxPrgYaxCIdtkCfpowVQT6OJHXpdrYLNMUN\n\tXM8ZPfzh/XlnUhV3lZOy2EMYk9yGAbHqfscwJfuurb20Mz9ualhx97WkjfdV8yYjn5di\n\tGc5ZAWjAplf8cllhWaH+VYwwRxeVX7cJhpkeHSGch65xukvJniVXff0dP42bE6nOVCQg\n\t2P0mAKGmm2IbORETyyWSPe9O07P81gvvjJY4AMkVw2fgMnDBYle+RpIi4DnRSL0Y8lK6\n\tBVyg==","X-Gm-Message-State":"AOAM533ii6aWk/FQNA86bGT4GVG75yEmX2KRJ9cNFu1mvd/clFunLhBI\n\t9GPe0B/lnUr+N7bt6Lkj9vuWd0VrSeBDh2TpaWa9vRwPMhBTzA==","X-Google-Smtp-Source":"ABdhPJw+ioPA4QZSQapPh8L/kRXDBXB9PdzyfkqUDllq/Uo5hp6uHCB7ZKfPrDZs82Ixg8ymLrGs8kss4ZtbMdMHcO4=","X-Received":"by 2002:a17:906:a20b:: with SMTP id\n\tr11mr810811ejy.221.1624321773617; \n\tMon, 21 Jun 2021 17:29:33 -0700 (PDT)","MIME-Version":"1.0","References":"<20210621152954.40299-1-jacopo@jmondi.org>\n\t<20210621152954.40299-2-jacopo@jmondi.org>","In-Reply-To":"<20210621152954.40299-2-jacopo@jmondi.org>","From":"Hirokazu Honda ","Date":"Tue, 22 Jun 2021 09:29:23 +0900","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"multipart/alternative; boundary=\"0000000000005151f505c54fe2f4\"","Subject":"Re: [libcamera-devel] [PATCH 1/2] android: Sort source files\n\talphabetically","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17674,"web_url":"https://patchwork.libcamera.org/comment/17674/","msgid":"<20210622023505.GC1899306@pyrite.rasen.tech>","date":"2021-06-22T02:35:05","subject":"Re: [libcamera-devel] [PATCH 1/2] android: Sort source files\n\talphabetically","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Jun 21, 2021 at 05:29:53PM +0200, Jacopo Mondi wrote:\n> Sort the list of the Android HAL source file alphabetically.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index 3893e5b5b832..f27fd5316705 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -44,9 +44,9 @@ subdir('cros')\n> \n> android_hal_sources = files([\n> 'camera3_hal.cpp',\n> - 'camera_hal_manager.cpp',\n> 'camera_device.cpp',\n> 'camera_hal_config.cpp',\n> + 'camera_hal_manager.cpp',\n> 'camera_metadata.cpp',\n> 'camera_ops.cpp',\n> 'camera_stream.cpp',\n> -- \n> 2.31.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4044DC321B\n\tfor ;\n\tTue, 22 Jun 2021 02:35:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8250868939;\n\tTue, 22 Jun 2021 04:35:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8EAE368931\n\tfor ;\n\tTue, 22 Jun 2021 04:35:14 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EEF75A15;\n\tTue, 22 Jun 2021 04:35:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bb1skjlo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624329314;\n\tbh=9Nvr7VLMJ3bEcPWLHcQzRDVXko9rLZILe2nXLAkFMuU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bb1skjlojZINGQpPyOBejNFhT+iLImi7QYtFU48Rxl4tzk/VxuTU1nZdLAzfD+MIh\n\tYKIh3fBTS8gbAa5pgeDEFBpOUyfDMMKUqG+V83jEVlODAVcmVPbTsn32fTjiMGaNRD\n\tMuGU8LcLyiX4IMGs/F5q14MriQnyAoYTh64Ahvh4=","Date":"Tue, 22 Jun 2021 11:35:05 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20210622023505.GC1899306@pyrite.rasen.tech>","References":"<20210621152954.40299-1-jacopo@jmondi.org>\n\t<20210621152954.40299-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210621152954.40299-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 1/2] android: Sort source files\n\talphabetically","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17685,"web_url":"https://patchwork.libcamera.org/comment/17685/","msgid":"","date":"2021-06-22T09:54:55","subject":"Re: [libcamera-devel] [PATCH 1/2] android: Sort source files\n\talphabetically","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jun 22, 2021 at 09:29:23AM +0900, Hirokazu Honda wrote:\n> On Tue, Jun 22, 2021 at 12:29 AM Jacopo Mondi wrote:\n> \n> > Sort the list of the Android HAL source file alphabetically.\n> >\n> > Signed-off-by: Jacopo Mondi \n> \n> I expect this is detected by the style check script, isn't it?\n\nThis would be nice, but checkstyle.py doesn't have support for this yet,\nand it's a rabbit hole I'm not keen on exploring at this moment :-)\n\n> Reviewed-by: Hirokazu Honda \n\nReviewed-by: Laurent Pinchart \n\n> > ---\n> > src/android/meson.build | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/android/meson.build b/src/android/meson.build\n> > index 3893e5b5b832..f27fd5316705 100644\n> > --- a/src/android/meson.build\n> > +++ b/src/android/meson.build\n> > @@ -44,9 +44,9 @@ subdir('cros')\n> >\n> > android_hal_sources = files([\n> > 'camera3_hal.cpp',\n> > - 'camera_hal_manager.cpp',\n> > 'camera_device.cpp',\n> > 'camera_hal_config.cpp',\n> > + 'camera_hal_manager.cpp',\n> > 'camera_metadata.cpp',\n> > 'camera_ops.cpp',\n> > 'camera_stream.cpp',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB5F4C321B\n\tfor ;\n\tTue, 22 Jun 2021 09:55:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 650D668934;\n\tTue, 22 Jun 2021 11:55:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A69496050B\n\tfor ;\n\tTue, 22 Jun 2021 11:55:24 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 13EB5A66;\n\tTue, 22 Jun 2021 11:55:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tnn3phJD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624355724;\n\tbh=No5pQfdr+phl0aPA/L1soPQf58q8uWa3dtvjyjv+5K8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tnn3phJDJnDXSsIFHcfNFKtgLLtcfwraB4XxQN05YvLgkMTETCUVH7/cBc0DZDfKv\n\tdBXjhaJwcK1J3vM598+TphY5sE5PhOS4Gkf9CPy93SeRZO6dLcOvSraB3z6Y8YRcYo\n\toE3YRVQtZkqjgBTjgAaKtW1PKMt2tKVw/0anxdPk=","Date":"Tue, 22 Jun 2021 12:54:55 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210621152954.40299-1-jacopo@jmondi.org>\n\t<20210621152954.40299-2-jacopo@jmondi.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 1/2] android: Sort source files\n\talphabetically","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]