{"id":12580,"url":"https://patchwork.libcamera.org/api/covers/12580/?format=json","web_url":"https://patchwork.libcamera.org/cover/12580/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210614095340.3051816-1-naush@raspberrypi.com>","date":"2021-06-14T09:53:34","name":"[libcamera-devel,0/6] Raspberry Pi: Metadata parsing improvements","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/12580/mbox/","series":[{"id":2128,"url":"https://patchwork.libcamera.org/api/series/2128/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2128","date":"2021-06-14T09:53:34","name":"Raspberry Pi: Metadata parsing improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/2128/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/12580/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2686C3218\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 14 Jun 2021 09:53:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58CC368934;\n\tMon, 14 Jun 2021 11:53:47 +0200 (CEST)","from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 15F856029A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 14 Jun 2021 11:53:46 +0200 (CEST)","by mail-wr1-x433.google.com with SMTP id r9so13838846wrz.10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 14 Jun 2021 02:53:46 -0700 (PDT)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:fd93:d554:2dff:83ca])\n\tby smtp.gmail.com with ESMTPSA id\n\tc2sm19834891wmf.24.2021.06.14.02.53.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 14 Jun 2021 02:53:45 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"o4a1HSeg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=8ZEVK6qMZfrgVJ/LteXvQzQyZx98YGmbqkk/7A0s7RA=;\n\tb=o4a1HSeguYP8dMFITtyacmQKeWv+Ujku0OKFCZBVDCA3EtB2O0hJtCEKbMrro0Oyt3\n\tx2nAcjuHa53/hR+Z1IBQ2ubqtpgKmOv/aVgIUpG+RdtvQXfXjlUekM6TYzWPUmhZHzC7\n\tyTiS2nhZQe8/6gIZs6DWwB7OMu9GZVl9EVuvFg4l1sNMrGFQd4XReM0ccbmZ4I4l1UWo\n\t7zML4e3gGSriGO4aefTtNIRzhCSQDGStMYdIpvv9UWFMDJuziZJkBomO1SWPf72DSNOk\n\t+duY3yWh7xieEX8vMvp6C+2dsoVgfCRO4HcWHWXDaHamLV+R38QNE9nqqSZc8SQMj4HI\n\tZlhw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=8ZEVK6qMZfrgVJ/LteXvQzQyZx98YGmbqkk/7A0s7RA=;\n\tb=fhf5KNK0OCC0RfsnC7AN+48+sD7LjMHHnqN7aTuRxEAJDGk+VgFxWCvW+lCcVDUss9\n\teWbqFzhFzd/z2yEidNHHPWgN4HD7T2+RihMDbTt7tcoviP3PJT6KezfVdkvcKXfHunMJ\n\tYlMCEirkW6K/sVom3+LUHBSlrlYXu6AQii7CVNR1entZQwF2bNFw4rlj3deVdeSVCLfj\n\tOlix3C6dlLADGdRiMxAPEDuiS53BRth13+ekVvdUXF5/miGRwdW43XzugFVg7XsVlDEQ\n\tsTHMbnBs09PHCp7TjyCx7150zc7BhTYDclckcMBdxuXG51wuJ4fUV6uXJVtylaScGoKr\n\tdxoA==","X-Gm-Message-State":"AOAM531FS/Jx/1YN9ylpfNoOZSPftYR34DTj7nSFROIxuajq/1NtZIWi\n\tdUKDRGSQQnrRnxSinJ8i0jq3nLefT0OuhQ==","X-Google-Smtp-Source":"ABdhPJwvTJMaCchcWIs4LWpZOOjPbV2YE5caZ7iUUmTQo1PjaUvSKWmUykdrr4LKe7sXwSTal1PLHA==","X-Received":"by 2002:adf:f946:: with SMTP id\n\tq6mr17154566wrr.283.1623664425524; \n\tMon, 14 Jun 2021 02:53:45 -0700 (PDT)","From":"Naushir Patuck <naush@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 14 Jun 2021 10:53:34 +0100","Message-Id":"<20210614095340.3051816-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 0/6] Raspberry Pi: Metadata parsing\n\timprovements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hi,\n\nThis series of patches provide some improvements to our SMIA metadata parser\nthat were long on my todo list.\n\nPatches 1/6 to 4/6 are mostly formatting and syntactic changes to get us more\nin-line with libcamera formatting guidelines.\n\nPatch 5/6 inlines the SMIA parser in all CamHelpers that use time instead of\ndynamically allocating the object.\n\nPatch 6/6 makes the SMIA metadata parser code more generic so that it can\nbe directly used by the imx477 and imx219 CamHelpers instead of being subclassed.\n\nThanks,\nNaush\n\nNaushir Patuck (6):\n  ipa: raspberrypi: Non-functional formatting fixes to md_parser.hpp\n  ipa: raspberrypi: Set default values for member variables of MdParser\n  ipa: raspberrypi: Rename md_parser.cpp to md_parser_smia.cpp\n  ipa: raspberrypi: Non-functional formatting fixes to\n    md_parser_smia.cpp\n  ipa: raspberrypi: Embed the metadata parser in the sensor CamHelper\n    classes\n  ipa: raspberrypi: Generalise the SMIA metadata parser\n\n src/ipa/raspberrypi/cam_helper.cpp        |   5 +-\n src/ipa/raspberrypi/cam_helper.hpp        |   2 +-\n src/ipa/raspberrypi/cam_helper_imx219.cpp | 123 +++------------\n src/ipa/raspberrypi/cam_helper_imx290.cpp |   2 +-\n src/ipa/raspberrypi/cam_helper_imx477.cpp | 127 +++------------\n src/ipa/raspberrypi/cam_helper_ov5647.cpp |   2 +-\n src/ipa/raspberrypi/md_parser.cpp         | 102 -------------\n src/ipa/raspberrypi/md_parser.hpp         | 178 ++++++++++++++--------\n src/ipa/raspberrypi/md_parser_smia.cpp    | 171 +++++++++++++++++++++\n src/ipa/raspberrypi/meson.build           |   2 +-\n 10 files changed, 340 insertions(+), 374 deletions(-)\n delete mode 100644 src/ipa/raspberrypi/md_parser.cpp\n create mode 100644 src/ipa/raspberrypi/md_parser_smia.cpp"}