[{"id":17650,"web_url":"https://patchwork.libcamera.org/comment/17650/","msgid":"","date":"2021-06-21T08:14:14","subject":"Re: [libcamera-devel] [PATCH v3 0/2] Raspberrypi: support per-mode\n\tcamera sensitivities","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi everyone\n\nI was wondering if I might give this one a little prod?\n\nWhen I originally posted this I asked for opinions on how we might\ncommunicate mode sensitivities to an application, the difficulty being\nthat an application would, I expect, typically want to know it before\nstarting the camera. I think I proposed returning it in the\nconfiguration. What do people think? Perhaps I'll put together another\npatch which implements that.\n\nThanks\nDavid\n\nOn Fri, 11 Jun 2021 at 11:07, David Plowman\n wrote:\n>\n> Hi everyone\n>\n> No functional changes here over v2, just re-submitting because there\n> were conflicts after the std::chrono::Duration changes in the AGC.\n>\n> Comments eagerly anticipated, as always!\n>\n> Thanks\n> David\n>\n> David Plowman (2):\n> ipa: raspberrypi: Add sensitivity field to camera mode\n> ipa: raspberrypi: AGC: handle modes with different sensitivities\n>\n> src/ipa/raspberrypi/cam_helper.cpp | 11 +++++++++\n> src/ipa/raspberrypi/cam_helper.hpp | 3 +++\n> src/ipa/raspberrypi/controller/camera_mode.h | 2 ++\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 25 ++++++++++++++++----\n> src/ipa/raspberrypi/controller/rpi/agc.hpp | 1 +\n> src/ipa/raspberrypi/raspberrypi.cpp | 6 +++++\n> 6 files changed, 43 insertions(+), 5 deletions(-)\n>\n> --\n> 2.20.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79669C3218\n\tfor ;\n\tMon, 21 Jun 2021 08:14:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D162968935;\n\tMon, 21 Jun 2021 10:14:27 +0200 (CEST)","from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94FEB60295\n\tfor ;\n\tMon, 21 Jun 2021 10:14:25 +0200 (CEST)","by mail-wr1-x432.google.com with SMTP id a11so18548675wrt.13\n\tfor ;\n\tMon, 21 Jun 2021 01:14:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"UHrI6Z6R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=5D5rz2lUSAc5nxFus5oUt3jyFrUaN24O3aQqXztLAu8=;\n\tb=UHrI6Z6RDDZM7KjUZ0ImmyTMNhZCc5VQRzgLX93Cjevcjfd6jX2dtrAJkx+pyWzl7X\n\tKrE5D9+LlIwK4cRp+GgwA1moKWLP2Z9A0gpCEGiZpFjW/CrTKKibWgR/pBavOKpMUdW0\n\tAM22CeUc6/tu2c6W8nueGz6jEts+0eFb3G9lgrF3EwBweMFXL33qoqOG9fws4B0iLv34\n\tlLJOknxCf8X5WfUqpnoa4ByIsc/vfqD0191wvNbB5QGZVSFDmpstJ6dbs+KyR/6+/A/P\n\tEMNHvNC398Bh9rvGmmghOS0vhn2N1xoJxA4Q9ApzhyjStYvy/2rSKvtUdrqFQ19SUx4Y\n\tN8dA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=5D5rz2lUSAc5nxFus5oUt3jyFrUaN24O3aQqXztLAu8=;\n\tb=hp0mYjtXzqe2tXtqQYxZTtVS0HlOLXndHGamAtgUyP0dYQQ+Tt+DoVjs24ZH5iYCx1\n\txKFScPnpHg5U+x1pbegWSUk3Ag97B746gVB4+mjE0POfnO87CJfnCgnnHi1AzAWQZv7z\n\tmBc+zRJmqmCsYmtUr0jui8F90niJEbarq11gkxDxIDDWMfxX9hkGC9/oz4De2HkC9cVP\n\tmF3vENfeQXPRwqrAkWm24hUztubUnkYanpQ/Ub0n+saWsQomUnVkHb7KfX0Rjky/DLs7\n\tdq54qMTQmLw5gsqgIUwvIQ2OTRlQttbKp3ZzkcraCi5YrLMG92wu1o+JRkaH/88TRWrK\n\t6oyg==","X-Gm-Message-State":"AOAM533252RtVEy2S7vKZpuWWhuJUPY6HPKOSv0zODdrUAtHv0Znium9\n\tp51G1G8R1OIxJ0AMKUZOszoLuZ2/pgvQ1SrJhOyWdnZZPwOgnw==","X-Google-Smtp-Source":"ABdhPJxPAQj8mWbOoHHfiJlocNn2EI5YCkEK7h646QvULYc/QvXow0qIrWOLgEv2eriaD1efCUqq/o2+4gzeT6sXKZY=","X-Received":"by 2002:a5d:6412:: with SMTP id\n\tz18mr16859719wru.163.1624263265052; \n\tMon, 21 Jun 2021 01:14:25 -0700 (PDT)","MIME-Version":"1.0","References":"<20210611100703.2285-1-david.plowman@raspberrypi.com>","In-Reply-To":"<20210611100703.2285-1-david.plowman@raspberrypi.com>","From":"David Plowman ","Date":"Mon, 21 Jun 2021 09:14:14 +0100","Message-ID":"","To":"libcamera devel ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v3 0/2] Raspberrypi: support per-mode\n\tcamera sensitivities","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]