[{"id":17395,"web_url":"https://patchwork.libcamera.org/comment/17395/","msgid":"<20210603063951.GD156622@pyrite.rasen.tech>","date":"2021-06-03T06:39:51","subject":"Re: [libcamera-devel] [PATCH 0/4] IPAIPU3 drive-by improvements","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Umang,\n\nOn Wed, Jun 02, 2021 at 03:53:22PM +0530, Umang Jain wrote:\n> Here are few patches that might be considered as enhancements.\n> \n> The patches journey was led by the reviews from\n> \"[PATCH 0/2] frame-durations CTS fixups\", however this doesn't yet\n> fixup the frame-duration value for CTS, on my `nautilus` platform. But I\n> assume, it shall still relevant CTS tests on `soraka` (Can anyone\n> please help me confirm)?\n\nThey all pass CTS on soraka \\o/\n\nFor all (although I guess 1/4 has already been merged),\n\nTested-by: Paul Elder \n\n> \n> Patch 1/4: Addressed minor comments from original series\n> Patch 2/4: Replaces hard-coded line duration(enhancement) using real\n> values\n> \n> Patch 3/4: Caching IPACameraSensorInfo\n> Patch 4/4: Replace frame-duration with something better?!\n> \n> Umang Jain (4):\n> android: Make FRAME_DURATION result key available in static metadata\n> ipa: ipu3: Calculate line duration from IPACameraSensorInfo\n> ipa: ipu3: Copy IPACameraSensorInfo for future usage\n> ipa: ipu3: Calculate frame duration from minimum VBLANK value\n> \n> src/android/camera_device.cpp | 1 +\n> src/ipa/ipu3/ipu3.cpp | 22 ++++++++++++++++++----\n> src/ipa/ipu3/ipu3_agc.cpp | 22 +++++++++++-----------\n> src/ipa/ipu3/ipu3_agc.h | 7 ++++++-\n> 4 files changed, 36 insertions(+), 16 deletions(-)\n> \n> -- \n> 2.31.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21167C3206\n\tfor ;\n\tThu, 3 Jun 2021 06:40:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49DD96892B;\n\tThu, 3 Jun 2021 08:40:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACC90602A2\n\tfor ;\n\tThu, 3 Jun 2021 08:39:58 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0A07FAC3;\n\tThu, 3 Jun 2021 08:39:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bWSUluRX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622702398;\n\tbh=U6b1fehZG5fJ5rj2yLNbNy3O0cbRVy1wZnzOz19/EDw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bWSUluRXOLr59pvpRo2elhrlrNq7OAcaXOaw35IoY/cZFzBF9CzdrTDf5L8n/TqTX\n\tjZdpj6yrYdAKMl6lvEroXUy/L/e5Ax/tr5MWPBRvus4BhICXVbD0ZFonDsy/gSPt76\n\tQhHf57T+Yr5nDLHC0qOyzEHJ4w4ltsNcSvbKdVYA=","Date":"Thu, 3 Jun 2021 15:39:51 +0900","From":"paul.elder@ideasonboard.com","To":"Umang Jain ","Message-ID":"<20210603063951.GD156622@pyrite.rasen.tech>","References":"<20210602102326.106549-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210602102326.106549-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 0/4] IPAIPU3 drive-by improvements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17454,"web_url":"https://patchwork.libcamera.org/comment/17454/","msgid":"","date":"2021-06-07T22:32:10","subject":"Re: [libcamera-devel] [PATCH 0/4] IPAIPU3 drive-by improvements","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nOn Thu, Jun 03, 2021 at 03:39:51PM +0900, paul.elder@ideasonboard.com wrote:\n> On Wed, Jun 02, 2021 at 03:53:22PM +0530, Umang Jain wrote:\n> > Here are few patches that might be considered as enhancements.\n> > \n> > The patches journey was led by the reviews from\n> > \"[PATCH 0/2] frame-durations CTS fixups\", however this doesn't yet\n> > fixup the frame-duration value for CTS, on my `nautilus` platform. But I\n> > assume, it shall still relevant CTS tests on `soraka` (Can anyone\n> > please help me confirm)?\n> \n> They all pass CTS on soraka \\o/\n\nJust to make sure, does this only mean no regression, or do we have\nimprovements ?\n\n> For all (although I guess 1/4 has already been merged),\n> \n> Tested-by: Paul Elder \n> \n> > \n> > Patch 1/4: Addressed minor comments from original series\n> > Patch 2/4: Replaces hard-coded line duration(enhancement) using real\n> > values\n> > \n> > Patch 3/4: Caching IPACameraSensorInfo\n> > Patch 4/4: Replace frame-duration with something better?!\n> > \n> > Umang Jain (4):\n> > android: Make FRAME_DURATION result key available in static metadata\n> > ipa: ipu3: Calculate line duration from IPACameraSensorInfo\n> > ipa: ipu3: Copy IPACameraSensorInfo for future usage\n> > ipa: ipu3: Calculate frame duration from minimum VBLANK value\n> > \n> > src/android/camera_device.cpp | 1 +\n> > src/ipa/ipu3/ipu3.cpp | 22 ++++++++++++++++++----\n> > src/ipa/ipu3/ipu3_agc.cpp | 22 +++++++++++-----------\n> > src/ipa/ipu3/ipu3_agc.h | 7 ++++++-\n> > 4 files changed, 36 insertions(+), 16 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 511F8C3206\n\tfor ;\n\tMon, 7 Jun 2021 22:32:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93F346892B;\n\tTue, 8 Jun 2021 00:32:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 808B76891C\n\tfor ;\n\tTue, 8 Jun 2021 00:32:24 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E5EA0A24;\n\tTue, 8 Jun 2021 00:32:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qP9ynCzK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623105144;\n\tbh=1eEs1pEAFwecEC/Pp9vKe+nGZ3q1IpzEETwB04TwyWg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qP9ynCzKwZ7p/sBKiBUSuFNOrg3hLWWK9+/TXLbHOh77ItnVj2qW21K7jXz+KGOBU\n\tLZ4A1wI4+GpG6EpiJiReei/DP+dEKo6YLaOaDVdxxpSNV81Dzf9ndsF9wtQrIr8qAp\n\ts37c8pmJdMz3y3G/uBYDo5ujlU/KXwxKDxuAUC9g=","Date":"Tue, 8 Jun 2021 01:32:10 +0300","From":"Laurent Pinchart ","To":"paul.elder@ideasonboard.com","Message-ID":"","References":"<20210602102326.106549-1-umang.jain@ideasonboard.com>\n\t<20210603063951.GD156622@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210603063951.GD156622@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH 0/4] IPAIPU3 drive-by improvements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17461,"web_url":"https://patchwork.libcamera.org/comment/17461/","msgid":"<20210608030628.GH156622@pyrite.rasen.tech>","date":"2021-06-08T03:06:28","subject":"Re: [libcamera-devel] [PATCH 0/4] IPAIPU3 drive-by improvements","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Tue, Jun 08, 2021 at 01:32:10AM +0300, Laurent Pinchart wrote:\n> Hi Paul,\n> \n> On Thu, Jun 03, 2021 at 03:39:51PM +0900, paul.elder@ideasonboard.com wrote:\n> > On Wed, Jun 02, 2021 at 03:53:22PM +0530, Umang Jain wrote:\n> > > Here are few patches that might be considered as enhancements.\n> > > \n> > > The patches journey was led by the reviews from\n> > > \"[PATCH 0/2] frame-durations CTS fixups\", however this doesn't yet\n> > > fixup the frame-duration value for CTS, on my `nautilus` platform. But I\n> > > assume, it shall still relevant CTS tests on `soraka` (Can anyone\n> > > please help me confirm)?\n> > \n> > They all pass CTS on soraka \\o/\n> \n> Just to make sure, does this only mean no regression, or do we have\n> improvements ?\n\nNo regression.\n\n\nPaul\n\n> \n> > For all (although I guess 1/4 has already been merged),\n> > \n> > Tested-by: Paul Elder \n> > \n> > > \n> > > Patch 1/4: Addressed minor comments from original series\n> > > Patch 2/4: Replaces hard-coded line duration(enhancement) using real\n> > > values\n> > > \n> > > Patch 3/4: Caching IPACameraSensorInfo\n> > > Patch 4/4: Replace frame-duration with something better?!\n> > > \n> > > Umang Jain (4):\n> > > android: Make FRAME_DURATION result key available in static metadata\n> > > ipa: ipu3: Calculate line duration from IPACameraSensorInfo\n> > > ipa: ipu3: Copy IPACameraSensorInfo for future usage\n> > > ipa: ipu3: Calculate frame duration from minimum VBLANK value\n> > > \n> > > src/android/camera_device.cpp | 1 +\n> > > src/ipa/ipu3/ipu3.cpp | 22 ++++++++++++++++++----\n> > > src/ipa/ipu3/ipu3_agc.cpp | 22 +++++++++++-----------\n> > > src/ipa/ipu3/ipu3_agc.h | 7 ++++++-\n> > > 4 files changed, 36 insertions(+), 16 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08573C3206\n\tfor ;\n\tTue, 8 Jun 2021 03:06:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B9D86892D;\n\tTue, 8 Jun 2021 05:06:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE8B26029D\n\tfor ;\n\tTue, 8 Jun 2021 05:06:36 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E98863E6;\n\tTue, 8 Jun 2021 05:06:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g/X5F472\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623121596;\n\tbh=SWVGEY1CSX04FSeogBZClCKzown4tCJZDjChPr01s2M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=g/X5F472tj0w+5PlC2gyngu7Pj0dU8KX5jgnrAg10BkJY2ms4Zqi7131b39tQBPlt\n\tDtxcsnRgl/c5nxqDvKGBSLTsTBHpOO6SJtccIfYCZcd5jrzEe1a3TAsHQHGdY/RHqy\n\t71g4WmuxcOBw/g2bp8sd2Bxk85BMMPAYqpU1XFSY=","Date":"Tue, 8 Jun 2021 12:06:28 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210608030628.GH156622@pyrite.rasen.tech>","References":"<20210602102326.106549-1-umang.jain@ideasonboard.com>\n\t<20210603063951.GD156622@pyrite.rasen.tech>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 0/4] IPAIPU3 drive-by improvements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]