[{"id":17312,"web_url":"https://patchwork.libcamera.org/comment/17312/","msgid":"<451319cb-2ba3-2c40-adc9-d9ba81407a0d@ideasonboard.com>","date":"2021-05-27T07:35:28","subject":"Re: [libcamera-devel] [PATCH v3 2/5] meson: ipa: Use files() to\n\tlocate the mojom files","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Paul,\n\nThanks for the Patch\n\nOn 5/27/21 12:58 PM, Paul Elder wrote:\n> Use meson's files() to list the mojom files instead of the file names\n> directly. This is so that we can still access the files from\n> src/libcamera/ipa/meson.build later for building documentation cpp\n> files from the mojom files.\n>\n> While at it, fix some redundant string manipulation in building the\n> mojom modules.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \nReviewed-by: Umang Jain \n>\n> ---\n> Changes in v2:\n> - simplify the conversion\n> ---\n> include/libcamera/ipa/meson.build | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/include/libcamera/ipa/meson.build b/include/libcamera/ipa/meson.build\n> index eca4e9ee..729483ab 100644\n> --- a/include/libcamera/ipa/meson.build\n> +++ b/include/libcamera/ipa/meson.build\n> @@ -81,7 +81,7 @@ foreach file : ipa_mojom_files\n> endif\n> \n> # {pipeline}.mojom-module\n> - mojom = custom_target(file.split('.')[0] + '_mojom_module',\n> + mojom = custom_target(name + '_mojom_module',\n> input : file,\n> output : file + '-module',\n> depends : ipa_mojom_core,\n> @@ -143,3 +143,5 @@ foreach file : ipa_mojom_files\n> \n> libcamera_generated_ipa_headers += [header, serializer, proxy_header]\n> endforeach\n> +\n> +ipa_mojom_files = files(ipa_mojom_files)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F60FBDB80\n\tfor ;\n\tThu, 27 May 2021 07:35:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C414E68924;\n\tThu, 27 May 2021 09:35:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57E8968920\n\tfor ;\n\tThu, 27 May 2021 09:35:39 +0200 (CEST)","from localhost.localdomain (unknown [103.251.226.180])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 75AE48DE;\n\tThu, 27 May 2021 09:35:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iV9kKY3r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622100939;\n\tbh=WPu9lNhOZmijf6pbAZVJqCKHIy8uzC3hUsMNuFzHjYc=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=iV9kKY3rl7A9Jfu311d+jYkkt0vSRNRABonfhnG8GzhWQUFJ2fvAEcLJRAQ+2yXn8\n\teT3J82/rD99WeMSBsy4JWxWPVp4fdJ7ELr9rx70yVJ370rbbCAglO3pzyDu5cDFtFJ\n\t19Sw0HiaPvE5V6M90/Lj/NA7A9YcUJMleu6FkClI=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210527072805.1333870-1-paul.elder@ideasonboard.com>\n\t<20210527072805.1333870-3-paul.elder@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<451319cb-2ba3-2c40-adc9-d9ba81407a0d@ideasonboard.com>","Date":"Thu, 27 May 2021 13:05:28 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.11.0","MIME-Version":"1.0","In-Reply-To":"<20210527072805.1333870-3-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v3 2/5] meson: ipa: Use files() to\n\tlocate the mojom files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]