[{"id":17251,"web_url":"https://patchwork.libcamera.org/comment/17251/","msgid":"","date":"2021-05-26T06:50:49","subject":"Re: [libcamera-devel] [PATCH 2/2] android: Fix file system library\n\tusage on gcc 7 and 8","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":".Hi Laurent, thank you for the patch\n\nOn Wed, May 26, 2021 at 9:09 AM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> On gcc versions older than 9, the file system library, used by the\n> Android camera HAL configuration file parser, is implemented in a\n> separate static library. Furthermore, on gcc 7, it's provided in the\n> std::experimental namespace. This breaks compilation of the HAL on gcc\n> 7, and linking on gcc 8.\n>\n> Fix the compilation issue by conditionally including\n> and creating a namespace alias in std, and the\n> link issue by linking to libstdc++fs on gcc versions older than 9.\n>\n> The inclusion of is a bit of a hack, and when\n> we'll start using the file system library in another compilation unit,\n> we should then move all this to an internal helper to abstract the\n> compiler version.\n>\n> Signed-off-by: Laurent Pinchart \n>\n\nReviewed-by: Hirokazu Honda \n\n---\n> meson.build | 8 ++++++++\n> src/android/camera_hal_config.cpp | 7 +++++++\n> 2 files changed, 15 insertions(+)\n>\n> diff --git a/meson.build b/meson.build\n> index 6626fa7ed154..2e7dffb70acc 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -76,6 +76,14 @@ if cc.get_id() == 'gcc'\n> error('gcc version is too old, libcamera requires 7.0 or newer')\n> endif\n>\n> + # On gcc 7 and 8, the file system library is provided in a separate\n> static\n> + # library.\n> + if cc.version().version_compare('<9')\n> + cpp_arguments += [\n> + '-lstdc++fs',\n> + ]\n> + endif\n> +\n> # gcc 7.1 introduced processor-specific ABI breakages related to\n> parameter\n> # passing on ARM platforms. This generates a large number of messages\n> # during compilation with gcc >=7.1. Silence them.\n> diff --git a/src/android/camera_hal_config.cpp\n> b/src/android/camera_hal_config.cpp\n> index d15df2e30c2c..f33ba26935da 100644\n> --- a/src/android/camera_hal_config.cpp\n> +++ b/src/android/camera_hal_config.cpp\n> @@ -6,7 +6,14 @@\n> */\n> #include \"camera_hal_config.h\"\n>\n> +#if defined(_GLIBCXX_RELEASE) && _GLIBCXX_RELEASE < 8\n> +#include \n> +namespace std {\n> +namespace filesystem = std::experimental::filesystem;\n> +}\n> +#else\n> #include \n> +#endif\n> #include \n> #include \n> #include \n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30307C3203\n\tfor ;\n\tWed, 26 May 2021 06:51:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E12168924;\n\tWed, 26 May 2021 08:51:01 +0200 (CEST)","from mail-ej1-x634.google.com (mail-ej1-x634.google.com\n\t[IPv6:2a00:1450:4864:20::634])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B87176891B\n\tfor ;\n\tWed, 26 May 2021 08:51:00 +0200 (CEST)","by mail-ej1-x634.google.com with SMTP id k14so709092eji.2\n\tfor ;\n\tTue, 25 May 2021 23:51:00 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"J2HQhReK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=5xFxQRByVidwZgCsdGACnqLyNv+OuRFvbVx6lrsKCCs=;\n\tb=J2HQhReKGL5KAXupMqkV6cRXVQ8OYyjHLdfis1SmVmtCyEHGbk70n3c1RNBW1pz5iR\n\tL5QTd/erlNxGvWGPIbF8QlJY8qlSUv8wktdZ+rMRFuBcHMlycYMGvRc5GHKSPA3F2eIL\n\teDKNepTS0hb1mpHPEN8JZ033BWhCS94vdLecg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=5xFxQRByVidwZgCsdGACnqLyNv+OuRFvbVx6lrsKCCs=;\n\tb=ipM5YfHhzj/Zu2sAkutFFU1tRr7wj3Fr+prdjG5/29grURjDMWWneXz/vwP0DGnbgp\n\tl4W5dhf7/K0B04t3YM99DWVxSTmxdFwcfDcZkfKA/8hkDTBMHpXr2PZ3jd0CyyyawpW/\n\txxH4EfrL7bnRyfm6tjeTp5S4hhAqLeXRkvKg2bQ2uWouTIHInFenjwL28XaapHbrqnSA\n\ttF0R1lc1YkVT0+ac1KeXSKN+5o3NjXotu67sPM3/+hYnojnz38aulZhzr/fo6hakaoNM\n\tfKcapuQNo3+kkI3e76OU6rpecj8a5CdWansnDshdlKdHdEGid/5xPYONgRIHhDmCsLE8\n\tkYHQ==","X-Gm-Message-State":"AOAM531WtnBnXYfCXnZruE616fDlJ6QSKwIpgSpie9C4X2FRwU1nycJb\n\tfv9Wj/cMpiP0zQT2euhaeLDDko2PVzjb31AuoctdgFSmW2A=","X-Google-Smtp-Source":"ABdhPJzSH/wO0apszVuGtuZK3TvexIUIGYMFwQv81dylxrox/x0fCTTzADnC/jq6QGKJwRI2epwML66Nk9tkiyCqriQ=","X-Received":"by 2002:a17:907:3ea0:: with SMTP id\n\ths32mr32260650ejc.475.1622011860422; \n\tTue, 25 May 2021 23:51:00 -0700 (PDT)","MIME-Version":"1.0","References":"<20210526000855.17501-1-laurent.pinchart@ideasonboard.com>\n\t<20210526000855.17501-3-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20210526000855.17501-3-laurent.pinchart@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Wed, 26 May 2021 15:50:49 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000c329e005c33610c9\"","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: Fix file system library\n\tusage on gcc 7 and 8","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17255,"web_url":"https://patchwork.libcamera.org/comment/17255/","msgid":"<20210526075205.zwzm2zzdmlhlrkei@uno.localdomain>","date":"2021-05-26T07:52:05","subject":"Re: [libcamera-devel] [PATCH 0/2] Fix Android camera HAL\n\tcompilation on gcc 7 and 8","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n thanks for addressing this.\n\nOn Wed, May 26, 2021 at 03:08:53AM +0300, Laurent Pinchart wrote:\n> Hello,\n>\n> This patch series fixes a compilation breakage of the camera HAL with\n> gcc 7 and 8 (technically a link breakage with gcc 8), introduced by\n> usage of the file system library.\n>\n> The first patch is a small refactoring, the second patch includes the\n> real fix, details are included there.\n>\n> The compilation fix is a bit of a hack. If we need to use the file\n> system library in more places (and I think we will), we should either\n> drop support for gcc 7 completely, or abstract file system operations in\n> helper classes. Any opinion ?\n\nI think that's the real question. I had a look around, mostly on the\nembedded side of the moon, and I haven't found any big clue that gcc7\nis still a requirement. In particular I had a look at toolchains\nreleased by bootlin and linaro, and they ship 9 or 10 for all arch,\nexcept bootlin's one for blackfin which is stuck to 6 or 7.\n\nBuildroot has deprecated gcc versions below 8\nI can't really find it out for yocto though :(\n\nTrue that gcc 7.1 has been released only 4 years ago, and 7.5 has\nseen a release in 2019, so it's no ancient at all\n\nFor completeness, the linux distro panorama looks quite different\nthough:\n\nDebian 9 stretch still ships 6.3.0 and has moved to 8.3. in Buster.\nFedora has moved to gcc 8 since release 28\nUbuntu 18.04 ships gcc 7.3.0\n\nThe Ubuntu LTS has still 1 year before EOL, Debian 9 is not that\nancient (and requires gcc 6), same for fedora 28.\n\nAll in all I feel like it might be a bit early to drop support for gcc 7?\n\nThanks\n j\n\n>\n> Laurent Pinchart (2):\n> android: camera_hal_config: Move include to .cpp file\n> android: Fix file system library usage on gcc 7 and 8\n>\n> meson.build | 8 ++++++++\n> src/android/camera_hal_config.cpp | 8 ++++++++\n> src/android/camera_hal_config.h | 1 -\n> 3 files changed, 16 insertions(+), 1 deletion(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 10115C3203\n\tfor ;\n\tWed, 26 May 2021 07:51:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70F816891F;\n\tWed, 26 May 2021 09:51:21 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB59C6891E\n\tfor ;\n\tWed, 26 May 2021 09:51:19 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 4D359E0009;\n\tWed, 26 May 2021 07:51:18 +0000 (UTC)"],"Date":"Wed, 26 May 2021 09:52:05 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210526075205.zwzm2zzdmlhlrkei@uno.localdomain>","References":"<20210526000855.17501-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210526000855.17501-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 0/2] Fix Android camera HAL\n\tcompilation on gcc 7 and 8","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17257,"web_url":"https://patchwork.libcamera.org/comment/17257/","msgid":"<20210526075838.cmtpxuddzpkhenj3@uno.localdomain>","date":"2021-05-26T07:58:38","subject":"Re: [libcamera-devel] [PATCH 2/2] android: Fix file system library\n\tusage on gcc 7 and 8","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Wed, May 26, 2021 at 03:08:55AM +0300, Laurent Pinchart wrote:\n> On gcc versions older than 9, the file system library, used by the\n> Android camera HAL configuration file parser, is implemented in a\n> separate static library. Furthermore, on gcc 7, it's provided in the\n> std::experimental namespace. This breaks compilation of the HAL on gcc\n> 7, and linking on gcc 8.\n>\n> Fix the compilation issue by conditionally including\n> and creating a namespace alias in std, and the\n> link issue by linking to libstdc++fs on gcc versions older than 9.\n>\n> The inclusion of is a bit of a hack, and when\n> we'll start using the file system library in another compilation unit,\n> we should then move all this to an internal helper to abstract the\n> compiler version.\n\nUnfortunate, but there are not many ways around it\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> meson.build | 8 ++++++++\n> src/android/camera_hal_config.cpp | 7 +++++++\n> 2 files changed, 15 insertions(+)\n>\n> diff --git a/meson.build b/meson.build\n> index 6626fa7ed154..2e7dffb70acc 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -76,6 +76,14 @@ if cc.get_id() == 'gcc'\n> error('gcc version is too old, libcamera requires 7.0 or newer')\n> endif\n>\n> + # On gcc 7 and 8, the file system library is provided in a separate static\n> + # library.\n> + if cc.version().version_compare('<9')\n> + cpp_arguments += [\n> + '-lstdc++fs',\n> + ]\n> + endif\n> +\n> # gcc 7.1 introduced processor-specific ABI breakages related to parameter\n> # passing on ARM platforms. This generates a large number of messages\n> # during compilation with gcc >=7.1. Silence them.\n> diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\n> index d15df2e30c2c..f33ba26935da 100644\n> --- a/src/android/camera_hal_config.cpp\n> +++ b/src/android/camera_hal_config.cpp\n> @@ -6,7 +6,14 @@\n> */\n> #include \"camera_hal_config.h\"\n>\n> +#if defined(_GLIBCXX_RELEASE) && _GLIBCXX_RELEASE < 8\n> +#include \n> +namespace std {\n> +namespace filesystem = std::experimental::filesystem;\n> +}\n> +#else\n> #include \n> +#endif\n> #include \n> #include \n> #include \n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E86F0C3200\n\tfor ;\n\tWed, 26 May 2021 07:57:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6221C68922;\n\tWed, 26 May 2021 09:57:54 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4ECC56891E\n\tfor ;\n\tWed, 26 May 2021 09:57:53 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 91B3720000E;\n\tWed, 26 May 2021 07:57:52 +0000 (UTC)"],"Date":"Wed, 26 May 2021 09:58:38 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210526075838.cmtpxuddzpkhenj3@uno.localdomain>","References":"<20210526000855.17501-1-laurent.pinchart@ideasonboard.com>\n\t<20210526000855.17501-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210526000855.17501-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: Fix file system library\n\tusage on gcc 7 and 8","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17262,"web_url":"https://patchwork.libcamera.org/comment/17262/","msgid":"","date":"2021-05-26T08:16:32","subject":"Re: [libcamera-devel] [PATCH 2/2] android: Fix file system library\n\tusage on gcc 7 and 8","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2021-05-26 03:08:55 +0300, Laurent Pinchart wrote:\n> On gcc versions older than 9, the file system library, used by the\n> Android camera HAL configuration file parser, is implemented in a\n> separate static library. Furthermore, on gcc 7, it's provided in the\n> std::experimental namespace. This breaks compilation of the HAL on gcc\n> 7, and linking on gcc 8.\n> \n> Fix the compilation issue by conditionally including\n> and creating a namespace alias in std, and the\n> link issue by linking to libstdc++fs on gcc versions older than 9.\n> \n> The inclusion of is a bit of a hack, and when\n> we'll start using the file system library in another compilation unit,\n> we should then move all this to an internal helper to abstract the\n> compiler version.\n> \n> Signed-off-by: Laurent Pinchart \n\nThis solves my issues, thanks!\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> meson.build | 8 ++++++++\n> src/android/camera_hal_config.cpp | 7 +++++++\n> 2 files changed, 15 insertions(+)\n> \n> diff --git a/meson.build b/meson.build\n> index 6626fa7ed154..2e7dffb70acc 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -76,6 +76,14 @@ if cc.get_id() == 'gcc'\n> error('gcc version is too old, libcamera requires 7.0 or newer')\n> endif\n> \n> + # On gcc 7 and 8, the file system library is provided in a separate static\n> + # library.\n> + if cc.version().version_compare('<9')\n> + cpp_arguments += [\n> + '-lstdc++fs',\n> + ]\n> + endif\n> +\n> # gcc 7.1 introduced processor-specific ABI breakages related to parameter\n> # passing on ARM platforms. This generates a large number of messages\n> # during compilation with gcc >=7.1. Silence them.\n> diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\n> index d15df2e30c2c..f33ba26935da 100644\n> --- a/src/android/camera_hal_config.cpp\n> +++ b/src/android/camera_hal_config.cpp\n> @@ -6,7 +6,14 @@\n> */\n> #include \"camera_hal_config.h\"\n> \n> +#if defined(_GLIBCXX_RELEASE) && _GLIBCXX_RELEASE < 8\n> +#include \n> +namespace std {\n> +namespace filesystem = std::experimental::filesystem;\n> +}\n> +#else\n> #include \n> +#endif\n> #include \n> #include \n> #include \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3519CC3203\n\tfor ;\n\tWed, 26 May 2021 08:16:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E1E1768922;\n\tWed, 26 May 2021 10:16:34 +0200 (CEST)","from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com\n\t[IPv6:2a00:1450:4864:20::12e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 078E96891E\n\tfor ;\n\tWed, 26 May 2021 10:16:34 +0200 (CEST)","by mail-lf1-x12e.google.com with SMTP id a2so1218692lfc.9\n\tfor ;\n\tWed, 26 May 2021 01:16:33 -0700 (PDT)","from localhost (h-62-63-236-217.A463.priv.bahnhof.se.\n\t[62.63.236.217]) by smtp.gmail.com with ESMTPSA id\n\ty18sm1011418lfe.301.2021.05.26.01.16.32\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 May 2021 01:16:32 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"b/Vpz0F6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=F3BDBW/V79+x0ITuTb0ilg6T5f8u1Y+eGpKV1klPYXs=;\n\tb=b/Vpz0F6FDjD0cuPrXofIKh8YSNHwHKDunKYXkrwCcRfT6sqTJXqjsjmwsGDlnq9SX\n\t3uVL7asbVRUZglfdALHsowfFIADFFGzqBGo2M4h0GRi5kauRbtqA7ytU29wr3oFWXG9z\n\tOzEenggrhejfyQOuziAXU1DDo+adP5/38thlcZcrgsCr1XpQvvj7EWaTWngtbQi8Qg+e\n\tzWJr7ujk7bUwkYUhfabsNWL/QgfaWhYOB+vw/NTIaBGp+3w1KEeDIsXTQTHvofvhJ/re\n\tekdxZrPE6oGUthaxBww1kRhBiNulOhPIvLDu9mhR6nSCfbx1BI7FTyXrzKu7QYuE2/z2\n\t071w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=F3BDBW/V79+x0ITuTb0ilg6T5f8u1Y+eGpKV1klPYXs=;\n\tb=uSmd3BxsWYDougHIpukeYQCQ/7UUxD2at5A9OZc5caY6mz8x+yjOCD8bbzXlg1HuQq\n\t1de8i7+1siJOCaR1T1tsG5B/173VkO4zG7uvmwRJU5Vwm79yiD5HSuPjiwtXU11Q1T0D\n\tR6gC1JNknG2eCxBbAIfE4zeoJ2fzacwZnIh/0xhQx5+T3Z+/kRIPi1Wq9r9kQgDdmSS5\n\tUr58HH9lO0+5vpWmQGxvLkXy1bojLh2ha7Y8JXdKsLdv7rRQrqGyQpwQFSot/8le7OzK\n\tbbDj/N/7zbG3QmZjxQ6NyEBH18+j/UZgHSzvtiYZNPVxyucWDH/Sq1mtYgiq4KdA2+J4\n\tbt5w==","X-Gm-Message-State":"AOAM5301BmCMMlaqNm4hXbqKzMYUAF8K9i/5/lKUdd1W6ncOhQ+7oY5v\n\tb4c0pnfO/V+CpuXV3k9Ls0MHNq5IVQzf/w==","X-Google-Smtp-Source":"ABdhPJz+/wGPIti4OnA48tcdneje54XANrU/Bf/Ro9F+rZ4geZsa6KMt1jrsZNJokgowAoBTQAD6wQ==","X-Received":"by 2002:ac2:48b1:: with SMTP id\n\tu17mr1333493lfg.294.1622016993523; \n\tWed, 26 May 2021 01:16:33 -0700 (PDT)","Date":"Wed, 26 May 2021 10:16:32 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20210526000855.17501-1-laurent.pinchart@ideasonboard.com>\n\t<20210526000855.17501-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20210526000855.17501-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: Fix file system library\n\tusage on gcc 7 and 8","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]