[{"id":17239,"web_url":"https://patchwork.libcamera.org/comment/17239/","msgid":"","date":"2021-05-25T10:15:35","subject":"Re: [libcamera-devel] [PATCH v2 2/5] meson: ipa: Use files() to\n\tlocate the mojom files","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Tue, May 25, 2021 at 06:52:15PM +0900, Paul Elder wrote:\n> Use meson's files() to list the mojom files instead of the file names\n> directly. This is so that we can still access the files from\n> src/libcamera/ipa/meson.build later for building documentation cpp\n> files from the mojom files.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> Changes in v2:\n> - simplify the conversion\n> ---\n> include/libcamera/ipa/meson.build | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/ipa/meson.build b/include/libcamera/ipa/meson.build\n> index eca4e9ee..729483ab 100644\n> --- a/include/libcamera/ipa/meson.build\n> +++ b/include/libcamera/ipa/meson.build\n> @@ -81,7 +81,7 @@ foreach file : ipa_mojom_files\n> endif\n> \n> # {pipeline}.mojom-module\n> - mojom = custom_target(file.split('.')[0] + '_mojom_module',\n> + mojom = custom_target(name + '_mojom_module',\n\nA bit of a drive-by fix ? You may want to mention it in the commit\nmessage.\n\nReviewed-by: Laurent Pinchart \n\n> input : file,\n> output : file + '-module',\n> depends : ipa_mojom_core,\n> @@ -143,3 +143,5 @@ foreach file : ipa_mojom_files\n> \n> libcamera_generated_ipa_headers += [header, serializer, proxy_header]\n> endforeach\n> +\n> +ipa_mojom_files = files(ipa_mojom_files)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58C28C3200\n\tfor ;\n\tTue, 25 May 2021 10:15:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A9066891F;\n\tTue, 25 May 2021 12:15:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B22E66050E\n\tfor ;\n\tTue, 25 May 2021 12:15:40 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D36B880;\n\tTue, 25 May 2021 12:15:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TcNAeDhY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621937740;\n\tbh=80p3KzYZB4kTz+BoA0dyWvbMk0PrqSjf2wmAj16W7Yg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TcNAeDhYe/t8md8e4f+fZzbttZ2eUSC4fDdL6Z/yPh4CqosG9cccRHVgRpRGl6iEY\n\ta9nl/HLtN9kNwJVlKldDDEpKh379mDxjqTWRmRocaGm4Wvm4U7+WuBAo6GBLL4efhN\n\tqaq9t7ZOE2e8r46WS7TV5sebys0IYIFbevBJ0WFA=","Date":"Tue, 25 May 2021 13:15:35 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210525095218.1237140-1-paul.elder@ideasonboard.com>\n\t<20210525095218.1237140-3-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210525095218.1237140-3-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/5] meson: ipa: Use files() to\n\tlocate the mojom files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17274,"web_url":"https://patchwork.libcamera.org/comment/17274/","msgid":"","date":"2021-05-26T13:30:32","subject":"Re: [libcamera-devel] [PATCH v2 4/5] meson: ipa: Pass core.mojom to\n\tthe docs generator","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Paul\n\nOn 5/25/21 3:22 PM, Paul Elder wrote:\n> We don't want to generate the same functional files for core.mojom as\n> the other mojom files, but we do want to generate the documentation cpp\n> files. Add core.mojom to the mojom files list after the main generation\n> is complete, so that the documentation generator can pick it up.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n> ---\n> include/libcamera/ipa/meson.build | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/include/libcamera/ipa/meson.build b/include/libcamera/ipa/meson.build\n> index 729483ab..81fb69f0 100644\n> --- a/include/libcamera/ipa/meson.build\n> +++ b/include/libcamera/ipa/meson.build\n> @@ -145,3 +145,6 @@ foreach file : ipa_mojom_files\n> endforeach\n> \n> ipa_mojom_files = files(ipa_mojom_files)\n> +\n> +# Pass this to the documentation generator in src/libcamera/ipa\n> +ipa_mojom_files += files(['core.mojom'])\nnitpick: I would setup this as:\n\nipa_mojom_files += files([\n     'core.mojom',\n])\n\nReviewed-by: Umang Jain ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 45D31BDB80\n\tfor ;\n\tWed, 26 May 2021 13:30:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9DB4B6891D;\n\tWed, 26 May 2021 15:30:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C60E9602AB\n\tfor ;\n\tWed, 26 May 2021 15:30:38 +0200 (CEST)","from localhost.localdomain (unknown [103.251.226.203])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D4E31908;\n\tWed, 26 May 2021 15:30:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tJrMoTK5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622035838;\n\tbh=MR60Gn9SnaBBj/PUqGhuT40nljVzZHUWL6FCfNjqfm0=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=tJrMoTK5O3yAFu8RsxdV+TTpSuL6C2bMamv1cXrriTMk2MqHlRRuCA6qNILW0I+f0\n\tmglgu80Ltv4y65C8DWczCiKJJbzfgzINhaj+TdUiT3JoQYC/S9XbdAmmNSQ7OWkE/9\n\tGmat0uT1rro5hpU+GAH3q14VgZfpEw7nz0/CtaY0=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210525095218.1237140-1-paul.elder@ideasonboard.com>\n\t<20210525095218.1237140-5-paul.elder@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Wed, 26 May 2021 19:00:32 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.11.0","MIME-Version":"1.0","In-Reply-To":"<20210525095218.1237140-5-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"8bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v2 4/5] meson: ipa: Pass core.mojom to\n\tthe docs generator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17275,"web_url":"https://patchwork.libcamera.org/comment/17275/","msgid":"","date":"2021-05-26T13:31:33","subject":"Re: [libcamera-devel] [PATCH v2 5/5] meson: ipa: Build\n\tdocumentation cpp files from mojom files","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"On 5/25/21 3:22 PM, Paul Elder wrote:\n> Plumb meson to build the cpp files from the mojom files for the purpose\n> of containing the documentation for the IPA interfaces.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \nReviewed-by: Umang Jain \n> ---\n> src/libcamera/ipa/meson.build | 18 +++++++++++++++---\n> 1 file changed, 15 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/libcamera/ipa/meson.build b/src/libcamera/ipa/meson.build\n> index 560b2fdd..44695240 100644\n> --- a/src/libcamera/ipa/meson.build\n> +++ b/src/libcamera/ipa/meson.build\n> @@ -1,5 +1,17 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> -libcamera_ipa_interfaces = files([\n> - 'core_ipa_interface.cpp',\n> -])\n> +libcamera_ipa_interfaces = []\n> +\n> +foreach file : ipa_mojom_files\n> + name = '@0@'.format(file).split('/')[-1].split('.')[0]\n> +\n> + # {pipeline}_ipa_interface.cpp\n> + libcamera_ipa_interfaces += \\\n> + custom_target(name + '_ipa_interface_cpp',\n> + input : file,\n> + output : name + '_ipa_interface.cpp',\n> + command : [\n> + mojom_docs_extractor,\n> + '-o', '@OUTPUT@', '@INPUT@'\n> + ])\n> +endforeach","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96A71BDB80\n\tfor ;\n\tWed, 26 May 2021 13:31:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57C0E68924;\n\tWed, 26 May 2021 15:31:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B2DC602AE\n\tfor ;\n\tWed, 26 May 2021 15:31:38 +0200 (CEST)","from localhost.localdomain (unknown [103.251.226.203])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A4F94908;\n\tWed, 26 May 2021 15:31:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cgPh+/ym\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622035898;\n\tbh=urzxWpZYU2YFlxyt8DDUqmUvKG4dra0dzOrIJZHDLPU=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=cgPh+/ymTUJMM4Us0Xm9Xftoi0sJajDaa8SKXEqWLl9GSFCg5VJQUrIegaKv4pcvA\n\t7IEIzuA8iQ9iTxgIT4emAHv/g+HTHTqssrUlnMCQk3nAILyHOTmbDkNN1+ajKPRK8E\n\tzPkPZEoX+Vy04t2Q9FJofGK7yVQUSJMqQgbF/wuI=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210525095218.1237140-1-paul.elder@ideasonboard.com>\n\t<20210525095218.1237140-6-paul.elder@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Wed, 26 May 2021 19:01:33 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.11.0","MIME-Version":"1.0","In-Reply-To":"<20210525095218.1237140-6-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v2 5/5] meson: ipa: Build\n\tdocumentation cpp files from mojom files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17277,"web_url":"https://patchwork.libcamera.org/comment/17277/","msgid":"","date":"2021-05-26T13:36:09","subject":"Re: [libcamera-devel] [PATCH v2 4/5] meson: ipa: Pass core.mojom to\n\tthe docs generator","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Paul\n\nOn 5/26/21 7:00 PM, Umang Jain wrote:\n> Hi Paul\n>\n> On 5/25/21 3:22 PM, Paul Elder wrote:\n>> We don't want to generate the same functional files for core.mojom as\n>> the other mojom files, but we do want to generate the documentation cpp\n>> files. Add core.mojom to the mojom files list after the main generation\n>> is complete, so that the documentation generator can pick it up.\n>>\n>> Signed-off-by: Paul Elder \n>> Reviewed-by: Laurent Pinchart \n>> ---\n>>   include/libcamera/ipa/meson.build | 3 +++\n>>   1 file changed, 3 insertions(+)\n>>\n>> diff --git a/include/libcamera/ipa/meson.build \n>> b/include/libcamera/ipa/meson.build\n>> index 729483ab..81fb69f0 100644\n>> --- a/include/libcamera/ipa/meson.build\n>> +++ b/include/libcamera/ipa/meson.build\n>> @@ -145,3 +145,6 @@ foreach file : ipa_mojom_files\n>>   endforeach\n>>     ipa_mojom_files = files(ipa_mojom_files)\n>> +\n>> +# Pass this to the documentation generator in src/libcamera/ipa\n>> +ipa_mojom_files += files(['core.mojom'])\n> nitpick: I would setup this as:\n>\n> ipa_mojom_files += files([\n>     'core.mojom',\n> ])\nDidn't realize it's only core.mojom :S, Looks good as per the patch.\n>\n> Reviewed-by: Umang Jain \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88FCCC3203\n\tfor ;\n\tWed, 26 May 2021 13:36:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49BC468925;\n\tWed, 26 May 2021 15:36:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DAC9602AE\n\tfor ;\n\tWed, 26 May 2021 15:36:16 +0200 (CEST)","from localhost.localdomain (unknown [103.251.226.203])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 223EA908;\n\tWed, 26 May 2021 15:36:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZObBUQr/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622036175;\n\tbh=HVdtIHlvNKHRMUD65YDZpt9LdWHeE63/lyJU1+OsRDI=;\n\th=Subject:From:To:References:Date:In-Reply-To:From;\n\tb=ZObBUQr/F7kzuDu/1lYTtwuLmQro7i51+QZxj8RdpwGL6MgLr+6PFOlvBrWT+Pj0Q\n\tq761d4fRykaxxEK+RR+iBVCrJunWsaMsFJ3kh5C3ExlTFGU62KQm8VoWtfwH41AuNG\n\tPNhjLk+znUnvaWNV1cEEM1jM5+8w4mFlL5igIfs4=","From":"Umang Jain ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210525095218.1237140-1-paul.elder@ideasonboard.com>\n\t<20210525095218.1237140-5-paul.elder@ideasonboard.com>\n\t","Message-ID":"","Date":"Wed, 26 May 2021 19:06:09 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.11.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"8bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v2 4/5] meson: ipa: Pass core.mojom to\n\tthe docs generator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]