[{"id":17188,"web_url":"https://patchwork.libcamera.org/comment/17188/","msgid":"","date":"2021-05-24T11:24:26","subject":"Re: [libcamera-devel] [PATCH v4 6/6] meson: Add a configuration\n\toption to build IPAs","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Mon, May 24, 2021 at 02:50:23PM +0530, Umang Jain wrote:\n> There can be multiple IPAs per pipeline-handler or platform.\n> They can live in-tree or externally linked. It is upto the vendor\n\ns/upto/up to/\n\nI'll fix when applying.\n\n> whether to use in-tree IPA for a platform or provide it externally.\n> In the case of IPAs being external, building in-tree IPAs might be\n> futile hence, provide a clear and explicit mechanism to choose whether\n> to build the in-tree IPA for the platform or not.\n> \n> By default, all in-tree IPAs are built when a matching Pipeline handler\n> is also enabled.\n> \n> Signed-off-by: Umang Jain \n> Reviewed-by: Paul Elder \n> Reviewed-by: Jean-Michel Hautbois \n> Reviewed-by: Laurent Pinchart \n> ---\n> meson.build | 1 +\n> meson_options.txt | 5 +++++\n> src/ipa/meson.build | 5 +++--\n> 3 files changed, 9 insertions(+), 2 deletions(-)\n> \n> diff --git a/meson.build b/meson.build\n> index fa2a62cf..35c80c6a 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -167,6 +167,7 @@ py_mod.find_installation('python3', modules: py_modules)\n> ## Summarise Configurations\n> summary({\n> 'Enabled pipelines': pipelines,\n> + 'Enabled IPA modules': ipa_modules,\n> 'Android support': android_enabled,\n> 'GStreamer support': gst_enabled,\n> 'V4L2 emulation support': v4l2_enabled,\n> diff --git a/meson_options.txt b/meson_options.txt\n> index 69f11f85..2c80ad8b 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -25,6 +25,11 @@ option('gstreamer',\n> value : 'auto',\n> description : 'Compile libcamera GStreamer plugin')\n> \n> +option('ipas',\n> + type : 'array',\n> + choices : ['ipu3', 'raspberrypi', 'rkisp1', 'vimc'],\n> + description : 'Select which IPA modules to build')\n> +\n> option('lc-compliance',\n> type : 'feature',\n> value : 'auto',\n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index 5b5684a1..49245e5e 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -19,14 +19,15 @@ subdir('libipa')\n> \n> ipa_sign = files('ipa-sign.sh')\n> \n> -ipas = ['ipu3', 'raspberrypi', 'rkisp1', 'vimc']\n> ipa_names = []\n> \n> +ipa_modules = get_option('ipas')\n> +\n> # The ipa-sign-install.sh script which uses the ipa_names variable will itself\n> # prepend MESON_INSTALL_DESTDIR_PREFIX to each ipa module name, therefore we\n> # must not include the prefix string here.\n> foreach pipeline : pipelines\n> - if ipas.contains(pipeline)\n> + if ipa_modules.contains(pipeline)\n> subdir(pipeline)\n> ipa_names += ipa_install_dir / ipa_name + '.so'\n> endif","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1D07C3201\n\tfor ;\n\tMon, 24 May 2021 11:24:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3964268919;\n\tMon, 24 May 2021 13:24:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81663601AA\n\tfor ;\n\tMon, 24 May 2021 13:24:30 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D1C43ED;\n\tMon, 24 May 2021 13:24:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Bu4pc4J8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621855470;\n\tbh=LcnQ9w2+hySe+c1Ov1SE1DzK47IYulX/SfHyETmC60U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Bu4pc4J8W7K/GY1z6QtlNKX8fUldn3AOOp1uLvSn9esRsMSXr0nvgSIj6tVikxHar\n\t/MWcTARL59Sj5dY52Uew4pWRcjB0GZyxmximK382VSGm6VHxHXIt0Uz3QMCM2w76bA\n\tzu7kR1Alxdy/LbZJjqnZIwiF+t16h9K2dqcWcncM=","Date":"Mon, 24 May 2021 14:24:26 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210524092023.91779-1-umang.jain@ideasonboard.com>\n\t<20210524092023.91779-7-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210524092023.91779-7-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 6/6] meson: Add a configuration\n\toption to build IPAs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]