[{"id":16996,"web_url":"https://patchwork.libcamera.org/comment/16996/","msgid":"<20210518093244.GZ195599@pyrite.rasen.tech>","date":"2021-05-18T09:32:44","subject":"Re: [libcamera-devel] [PATCH 0/4] android: camera_metadata:\n\tMiscellaneous improvements","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hello Laurent,\n\nOn Sat, May 15, 2021 at 09:38:22PM +0300, Laurent Pinchart wrote:\n> Hello,\n> \n> These small improvements stem from the review of the CameraMetadata\n> dynamic allocations series. As the series has been merged already, it\n> was as fast to express the review comments as code as it would have been\n> to write them in English.\n> \n> The patches haven't been tested. Paul, would you be able to test them ?\n\nThank you for the nice improvements!\n\nLooks good to me (just one comment on 4/4 though).\n\nFor everything,\n\nReviewed-by: Paul Elder \nTested-by: Paul Elder \n\n> \n> Laurent Pinchart (4):\n> android: camera_metadata: Rename sizeofT argument to elementSize\n> android: camera_metadata: Constify argument to addEntry() and\n> updateEntry()\n> android: camera_metadata: Make internal functions private\n> android: camera_metadata: Add type sanity check to updateEntry()\n> \n> src/android/camera_metadata.cpp | 15 ++++++++++++---\n> src/android/camera_metadata.h | 22 +++++++++++++++-------\n> 2 files changed, 27 insertions(+), 10 deletions(-)\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 701D7C31FB\n\tfor ;\n\tTue, 18 May 2021 09:32:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BDFAB68919;\n\tTue, 18 May 2021 11:32:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99628602B1\n\tfor ;\n\tTue, 18 May 2021 11:32:53 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 268433EE;\n\tTue, 18 May 2021 11:32:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YLEQsME+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621330372;\n\tbh=jr/sIsoutn1pwfm109iv0Ow65KilONGgisJri59tXr4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YLEQsME+fluLkTZekrUwG88LQqzNt08YGW2YiW3QH+5AdKLKR2csHRnV6KImpeyQO\n\tRufYnZaxoiv5ewf1nk1eFLaBVUhWuU92CFZQ0oGH5Tc3HIhF407NDw5Gh1vsqLBBkZ\n\tfq80700Gv2W3B8nJfaOIRVOY2so3fjCDh/MgNS9E=","Date":"Tue, 18 May 2021 18:32:44 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210518093244.GZ195599@pyrite.rasen.tech>","References":"<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 0/4] android: camera_metadata:\n\tMiscellaneous improvements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]