{"id":12303,"url":"https://patchwork.libcamera.org/api/covers/12303/?format=json","web_url":"https://patchwork.libcamera.org/cover/12303/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>","date":"2021-05-15T18:38:22","name":"[libcamera-devel,0/4] android: camera_metadata: Miscellaneous improvements","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/12303/mbox/","series":[{"id":2033,"url":"https://patchwork.libcamera.org/api/series/2033/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2033","date":"2021-05-15T18:38:22","name":"android: camera_metadata: Miscellaneous improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/2033/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/12303/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14E0EC31FB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 15 May 2021 18:38:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 602A06891D;\n\tSat, 15 May 2021 20:38:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C18696891A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 15 May 2021 20:38:39 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C8FB436;\n\tSat, 15 May 2021 20:38:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"R4vWfzbF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621103919;\n\tbh=42aF5ArH59GAbxbkluixWl1xbL234e8A/+Su7nFLGE4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=R4vWfzbF1qF1+rXiTe4cV/lyjnW8e+kEmVSm4GtW04gvyKcjbWabcPwME8V3MaebB\n\t/T17/LcJorUTo9c2y0bAG3ui5T84QF7+U+AVrmgB06YWYOwUipnDG1+YSeP5rNAtvG\n\tUfP4lhvq/57SSmZ1EFb3cfy/INzNUbsQ/NaMIg8M=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 15 May 2021 21:38:22 +0300","Message-Id":"<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.28.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 0/4] android: camera_metadata:\n\tMiscellaneous improvements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hello,\n\nThese small improvements stem from the review of the CameraMetadata\ndynamic allocations series. As the series has been merged already, it\nwas as fast to express the review comments as code as it would have been\nto write them in English.\n\nThe patches haven't been tested. Paul, would you be able to test them ?\n\nLaurent Pinchart (4):\n  android: camera_metadata: Rename sizeofT argument to elementSize\n  android: camera_metadata: Constify argument to addEntry() and\n    updateEntry()\n  android: camera_metadata: Make internal functions private\n  android: camera_metadata: Add type sanity check to updateEntry()\n\n src/android/camera_metadata.cpp | 15 ++++++++++++---\n src/android/camera_metadata.h   | 22 +++++++++++++++-------\n 2 files changed, 27 insertions(+), 10 deletions(-)"}