{"id":12240,"url":"https://patchwork.libcamera.org/api/covers/12240/?format=json","web_url":"https://patchwork.libcamera.org/cover/12240/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210510105235.28319-1-jacopo@jmondi.org>","date":"2021-05-10T10:52:27","name":"[libcamera-devel,0/8] android: Implement flush() camera operation","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/12240/mbox/","series":[{"id":2016,"url":"https://patchwork.libcamera.org/api/series/2016/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2016","date":"2021-05-10T10:52:27","name":"android: Implement flush() camera operation","version":1,"mbox":"https://patchwork.libcamera.org/series/2016/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/12240/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05A5DBF831\n\tfor ;\n\tMon, 10 May 2021 10:51:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 88E3D68919;\n\tMon, 10 May 2021 12:51:56 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5811B602BE\n\tfor ;\n\tMon, 10 May 2021 12:51:55 +0200 (CEST)","from uno.homenet.telecomitalia.it\n\t(host-82-59-136-116.retail.telecomitalia.it [82.59.136.116])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 78088E01D2;\n\tMon, 10 May 2021 10:51:53 +0000 (UTC)"],"X-Originating-IP":"82.59.136.116","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 10 May 2021 12:52:27 +0200","Message-Id":"<20210510105235.28319-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 0/8] android: Implement flush() camera\n\toperation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Implement the flush() camera operation in Android CameraDevice class.\n\nThe series includes the already sent\n\"android: Rework request completion notification\" patch slightly modified:\n\n- set partial_results = 0 in case of error (as reported by cros_camera_test)\n- on fatal ERROR_DEVICE notify() to the framework first then call Fatal. Record\n with a \\todo the on-going discussion on the requirement to close the camera\n to handle failures gracefully.\n\nTo get to a successfull implementation of flush() a bit of preparatory work is\nrequired as currently Requests that fails to queue to the pipeline handler are\nnot returned to the application. Add Request::cancel() and call it in the\nPipelineHandler base class when calling queueRequestDevice() fails to allow\napplication to keep track of the queued requests.\n\nOn top of that, prepare the CameraDevice to support flush with a few clean-up\npatches, then implement the operation.\n\nNo regression detected when running CTS in LIMITED mode.\n\nTested with cros_camera_test:\n\n # cros_camera_test --gtest_filter=\"Camera3FrameTest/Camera3FlushRequestsTest*\"\n [==========] 12 tests from 1 test suite ran. (1380 ms total)\n [ PASSED ] 12 tests.\n\nThanks\n j\n\nJacopo Mondi (8):\n android: Rework request completion notification\n libcamera: request: Add Request::cancel()\n libcamera: pipeline_handler: Notify Request queueing failure\n android: camera_device: Replace running_ with CameraState\n android: Replace scoped_lock<> with libcamera::MutexLocker\n android: Guard access to the camera state\n android: Rename CameraDevice::mutex_\n android: Implement flush() camera operation\n\n include/libcamera/request.h | 1 +\n src/android/camera_device.cpp | 235 ++++++++++++++++++++---------\n src/android/camera_device.h | 21 ++-\n src/android/camera_ops.cpp | 8 +-\n src/libcamera/pipeline_handler.cpp | 15 +-\n src/libcamera/request.cpp | 30 ++++\n 6 files changed, 237 insertions(+), 73 deletions(-)\n\n--\n2.31.1"}