{"id":12233,"url":"https://patchwork.libcamera.org/api/covers/12233/?format=json","web_url":"https://patchwork.libcamera.org/cover/12233/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210510095814.3732400-1-naush@raspberrypi.com>","date":"2021-05-10T09:58:09","name":"[libcamera-devel,v6,0/6] ipa: raspberrypi: Rate-limit the controller algorithms","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/12233/mbox/","series":[{"id":2015,"url":"https://patchwork.libcamera.org/api/series/2015/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2015","date":"2021-05-10T09:58:09","name":"ipa: raspberrypi: Rate-limit the controller algorithms","version":6,"mbox":"https://patchwork.libcamera.org/series/2015/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/12233/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4E59BF829\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 10 May 2021 09:59:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 301B868918;\n\tMon, 10 May 2021 11:59:07 +0200 (CEST)","from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5F6C6890C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 May 2021 11:59:05 +0200 (CEST)","by mail-wm1-x332.google.com with SMTP id\n\tu5-20020a7bc0450000b02901480e40338bso9362380wmc.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 May 2021 02:59:05 -0700 (PDT)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:e710:3ec:6dad:dc2])\n\tby smtp.gmail.com with ESMTPSA id\n\ty17sm24767917wrw.90.2021.05.10.02.59.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 10 May 2021 02:59:04 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"YctkrrV7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Vj7Fotv2LsXW2UTlcbNv8AXStZrYNWCXx+RiUpq6wPw=;\n\tb=YctkrrV7ZK8iPly2ARtOqSSUzfbc/Dki2djUCX8kZfiodLXfpXUMq0bduxoOpYuT4Q\n\tLY7aHkh2h2YcwQypI9PgmxcDQY5eeHsCdI/RzKBHsuv5GMkjeRk8M60GcTCula0XT7Mf\n\tbpRuThcbL7weLfPr7yzn8JRYw24tUK56HBX6Ow1OBmAwsmh17u9+TJ90Jv4BUfapQkhd\n\t9iHKwT6ZDQAcgwAHSGOK43IdWkhNBAjf3dX0gjpTOhz88N5AxUJ1uTWCl7XK7WvimQkX\n\twUfOBwWMLkPP7MdLHJyzVraqXHogBznkj+kqNk73D1TRzB8IDcYEgtghZWcV0K5nOo8Y\n\tNxCA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Vj7Fotv2LsXW2UTlcbNv8AXStZrYNWCXx+RiUpq6wPw=;\n\tb=JlQChUfzzG6MiS5LBE6+NyLzQjgX3QbiScUaM4nrCiIVaHHhbTb6HolA5r9OSgR2h8\n\tWG68XeEHRR/rUx5FmRZc3WarsOWsjA7a5I1FJM+17YlF8udgA/jzVohAM468fcSeg7Xj\n\tCVbTrMlh0UOuvsyx4JuxgapZ9YnNLWegZ8MqWjalKOB4J6md/owDiJ9DOeoi5sR5YZOi\n\tXzoilEj0hO6ozb0Ykk85qTcwOO+MW774WsLBIumGNDh4Lk6+D366HtkbHQfn3+R452FD\n\tE7IurEfEXNA8ZvSfYv5R95gwR0XSc93b5YU6QRyJ8DlEXMVyOEbJIHVGjTOCFfR5cJtT\n\texWA==","X-Gm-Message-State":"AOAM531M8JI8cREMskH0+6/lJNRZyU4NZYx9kux4VntknwYOvGw7UxcX\n\tqRHHbMI8nqrQBgmmV5gwe/VrbXdqaqwt1g==","X-Google-Smtp-Source":"ABdhPJx6zyLyZGkyjwf9nKly6+ifg3fafAcxSCCHDESdJfsOz0HDs7wJ+BZmG2n9HUsOwrdZVfzjcA==","X-Received":"by 2002:a7b:c1da:: with SMTP id\n\ta26mr24628439wmj.40.1620640745145; \n\tMon, 10 May 2021 02:59:05 -0700 (PDT)","From":"Naushir Patuck <naush@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 10 May 2021 10:58:09 +0100","Message-Id":"<20210510095814.3732400-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v6 0/6] ipa: raspberrypi: Rate-limit the\n\tcontroller algorithms","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hi,\n\nVersion 6 of this patch series introduces the following changes:\n\n1) Switch from RPiController::Metadata::Overwrite() back to RPiController::Metadata::Merge().  This simplifies the logic in the IPA.\n\n2) Introduce a new change in patch 3/6.  This replaces our use of std::lock_guard with std::scoped_lock to mitigate deadlock when locking multiple mutexes.\n\n3) SensorTimestamp is no longer a draft control.\n\nDavid, I have removed your R-b tag from 6/6 because of the scope of change.  When you get a chance, could you re-review please?\n\nThanks,\nNaush\n\nNaushir Patuck (6):\n  ipa: raspberrypi: Store dropped frame count in a member variable\n  ipa: raspberrypi: Reformat RPiController::Metadata class header\n  ipa: raspberrypi: Switch to std::scoped_lock in the Metadata class\n  ipa: raspberrypi: Add move/copy ctors and operators to Metadata class\n  ipa: raspberrypi: Add a Merge method to RPiController::Metadata\n  ipa: raspberrypi: Rate-limit the controller algorithms\n\n src/ipa/raspberrypi/controller/metadata.hpp   | 61 +++++++++++++++----\n src/ipa/raspberrypi/raspberrypi.cpp           | 56 ++++++++++++++---\n .../pipeline/raspberrypi/raspberrypi.cpp      |  5 ++\n 3 files changed, 100 insertions(+), 22 deletions(-)"}