{"id":12217,"url":"https://patchwork.libcamera.org/api/covers/12217/?format=json","web_url":"https://patchwork.libcamera.org/cover/12217/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210507021727.1848611-1-hiroh@chromium.org>","date":"2021-05-07T02:17:25","name":"[libcamera-devel,0/2] Remove V4L2Control classes","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"mbox":"https://patchwork.libcamera.org/cover/12217/mbox/","series":[{"id":2007,"url":"https://patchwork.libcamera.org/api/series/2007/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2007","date":"2021-05-07T02:17:25","name":"Remove V4L2Control classes","version":1,"mbox":"https://patchwork.libcamera.org/series/2007/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/12217/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BCD0DBF831\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  7 May 2021 02:17:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 182C7602BD;\n\tFri,  7 May 2021 04:17:36 +0200 (CEST)","from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com\n\t[IPv6:2607:f8b0:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 188CD602BA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  7 May 2021 04:17:35 +0200 (CEST)","by mail-pf1-x42f.google.com with SMTP id c17so6563453pfn.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 06 May 2021 19:17:34 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:2f2e:9aad:9133:6283])\n\tby smtp.gmail.com with ESMTPSA id\n\ta190sm3299542pfb.185.2021.05.06.19.17.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 06 May 2021 19:17:32 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"DEClPX7G\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=YtYD8qMWxPDfXBFuhGlgfvDEwJMtTGR/T1IwULmvSTw=;\n\tb=DEClPX7GmZAymyMfN6PMXGIg14a5Nfg4WEikdp9Z4rfVE5+DPpl7bUS4BxqNUovEq/\n\th0v6P724nd6+J5w5WZdgyOKUTFxoyCj24kK2CYoJC8dLl1QBIuewu0K1V73DIzqvsRMY\n\tdc3ZJvgaDrHxpJCjnrCNRs0oIcFELOnjdzLYU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=YtYD8qMWxPDfXBFuhGlgfvDEwJMtTGR/T1IwULmvSTw=;\n\tb=QvObVdngrzbBzzr2To7fAAHJd64WkcmCKPq57PbpMNWtI8aVMthcjrWHFoYGdLVza5\n\t25PyM317W4lLhB/WqWDRS0gICai8DagjPuPZuO65DMm+EA2ZESHtSiopHgKORhB5AvDY\n\turhaPJX6iFwCGlrBPSsN9+FK1ImAsDwIYquYmLihkVaxAniHZ4NToRR6Kb+tYkeg+JLe\n\tZxIzsGtrPC7j/b1vAVI2y1k6DXw4V57dEMhckuD7L39eQv5qpSDxC9St6gVPvGxmG7dv\n\tvd5uhvPv9cpPff7ph92COFmwf+lEkgvpHwVcQSb+979BEHqQaJtS3JU9hTaftVLBfz8R\n\tEsvA==","X-Gm-Message-State":"AOAM530BDo8TaXU0svyRHFeRvLE2J88MVxz4knm0alxkjh5wFEF8oz77\n\tzRNVWMEfxex2zGqHPqiB6t8grHM6LRsDSw==","X-Google-Smtp-Source":"ABdhPJyoNgP0qZeDy22+rQpvO6bdMC1rj7VDnj0tJAYJl1rH2y95tqNSikNRaRUjxFXNNYl3ZSHy+A==","X-Received":"by 2002:a63:1064:: with SMTP id 36mr7514717pgq.164.1620353853360;\n\tThu, 06 May 2021 19:17:33 -0700 (PDT)","From":"Hirokazu Honda <hiroh@chromium.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri,  7 May 2021 11:17:25 +0900","Message-Id":"<20210507021727.1848611-1-hiroh@chromium.org>","X-Mailer":"git-send-email 2.31.1.607.g51e8a6a459-goog","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 0/2] Remove V4L2Control classes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"V4l2ControlId and V4L2ControlInfo has no additional member\nvariables or functions to ControlId and ControlInfo, and just\nconvenient classes to create ControlId and ControlInfo with\nv4l2_query_ext_control. Therefore, they are unnecessary and\nrather just introduce confusion. This patch series removes them.\n\nHirokazu Honda (2):\n  libcamera: pipeline: Remove unnecessary v4l2_controls.h includes\n  libcamera: V4L2Control: remove V4L2Control classes\n\n include/libcamera/internal/meson.build        |   1 -\n include/libcamera/internal/v4l2_controls.h    |  31 ----\n include/libcamera/internal/v4l2_device.h      |   4 +-\n src/libcamera/meson.build                     |   1 -\n src/libcamera/pipeline/ipu3/ipu3.cpp          |   1 -\n .../pipeline/raspberrypi/raspberrypi.cpp      |   1 -\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |   1 -\n src/libcamera/pipeline/vimc/vimc.cpp          |   1 -\n src/libcamera/v4l2_controls.cpp               | 151 ------------------\n src/libcamera/v4l2_device.cpp                 |  72 ++++++++-\n 10 files changed, 71 insertions(+), 193 deletions(-)\n delete mode 100644 include/libcamera/internal/v4l2_controls.h\n delete mode 100644 src/libcamera/v4l2_controls.cpp\n\n--\n2.31.1.607.g51e8a6a459-goog"}