[{"id":16545,"web_url":"https://patchwork.libcamera.org/comment/16545/","msgid":"","date":"2021-04-26T02:02:37","subject":"Re: [libcamera-devel] [PATCH v6 0/3] libcamera: V4L2Device: VLA\n\tremoval","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent, thanks for the patches.\n\nThey look good to me.\n\nOn Mon, Apr 26, 2021 at 9:12 AM Laurent Pinchart\n wrote:\n>\n> Hello,\n>\n> This patch series is a part of the v5 of V4L2 device control\n> improvements posted by Hiro. I've split the VLA removal from the rest of\n> the series, in order to merge those fixes while continue the discussion\n> on the rest of the rework.\n>\n> Patch 1/3 has seen the most extensive rework, as it was very intertwined\n> with 1/4 and 2/4 of v5. Patches 2/3 and 3/3 have just been rebased.\n> Hiro, could you please have a look ? If everything is fine to you I'll\n> merge the series. We can then discuss the rest of the changes rebased on\n> top.\n>\n> Hirokazu Honda (3):\n> libcamera: V4L2Device: Replace VLA with std::vector in getControls()\n> libcamera: V4L2Device: Replace VLA with std::vector in setControls()\n> libcamera: V4L2Device: Use Span in updateControls()\n>\n> include/libcamera/internal/v4l2_device.h | 4 +-\n> src/libcamera/v4l2_device.cpp | 73 +++++++++++-------------\n> 2 files changed, 36 insertions(+), 41 deletions(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27017BDC92\n\tfor ;\n\tMon, 26 Apr 2021 02:02:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E005D6887B;\n\tMon, 26 Apr 2021 04:02:49 +0200 (CEST)","from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n\t[IPv6:2a00:1450:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ADF9F6884B\n\tfor ;\n\tMon, 26 Apr 2021 04:02:47 +0200 (CEST)","by mail-ej1-x632.google.com with SMTP id w3so82073314ejc.4\n\tfor ;\n\tSun, 25 Apr 2021 19:02:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"oA3Nhpz0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=KawcgxKsxNOfsfNxgwS3/Y92Pc/X4gbJOytTkFJcKeQ=;\n\tb=oA3Nhpz0qBL6W/b7b2YNd7aW0Ev+UoXRip9M87JtquuJmkuXc2PjJnFaWyhuMs1mLG\n\thcfebYr5oSmokhJTlCj0N70iIjQxBerVlTe+o86G3NXwE8as6LVGH+Apt0NKT23PHGFZ\n\t/ZP4q71XcEtWyapdXoB7EurmazRHPi7/p3r4Y=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=KawcgxKsxNOfsfNxgwS3/Y92Pc/X4gbJOytTkFJcKeQ=;\n\tb=WqE25y1oi5faC3hu1gGgZK49TaWwXmuhJMvYDjev+N9cZkBG3tg46Rh6c0yHyFIomV\n\tyWgSHX3eNXZpXCmI/pkRFgmLysQynA8ykzfIOtLAAVqPmqZvsoO7Xg/kEivXTb2HCPxi\n\tNbpLGRczrZ0ZigEV3BgCS7ioYwx2GwodnVXsvNpZHuuzpDsJkvUfnb0Su7FZQn4PbQBC\n\tSn7iH9eLyxNkUGUT/mzn/AlJHhNxySGKQXf5zg36b3kiu9qsqZKTlVJoQPGZWvHGjmV/\n\t2HgSU7HjUN4fvXqaMv//HlTnsg2dorYqI8D8gq+nIjBaJIXu4hkLjF4tzwvlIgCE5nS8\n\t5loA==","X-Gm-Message-State":"AOAM530dlfyWk4Mt35S05zV07jtI47ABOH0kdciXZ9tXhbslZB2pN7RP\n\tGWuJOaFG0Di5ktiwa6h1qGS4tIprKUvBAQbRkUtFVYqyrZw=","X-Google-Smtp-Source":"ABdhPJzfxBQh488gVfcPgZFYtMWOY9X9iKa/hxJ+fnD7yei9IlYXm8hMkWqs8tx3rYgqCtRZ0FFs9xqK2BT+Lsqd6cA=","X-Received":"by 2002:a17:906:80d1:: with SMTP id\n\ta17mr16309692ejx.55.1619402567484; \n\tSun, 25 Apr 2021 19:02:47 -0700 (PDT)","MIME-Version":"1.0","References":"<20210426001220.15599-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20210426001220.15599-1-laurent.pinchart@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Mon, 26 Apr 2021 11:02:37 +0900","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v6 0/3] libcamera: V4L2Device: VLA\n\tremoval","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16582,"web_url":"https://patchwork.libcamera.org/comment/16582/","msgid":"<20210426102942.pws2rcmju7p422qg@uno.localdomain>","date":"2021-04-26T10:29:42","subject":"Re: [libcamera-devel] [PATCH v6 0/3] libcamera: V4L2Device: VLA\n\tremoval","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hello,\n\nOn Mon, Apr 26, 2021 at 03:12:17AM +0300, Laurent Pinchart wrote:\n> Hello,\n>\n> This patch series is a part of the v5 of V4L2 device control\n> improvements posted by Hiro. I've split the VLA removal from the rest of\n> the series, in order to merge those fixes while continue the discussion\n> on the rest of the rework.\n>\n> Patch 1/3 has seen the most extensive rework, as it was very intertwined\n> with 1/4 and 2/4 of v5. Patches 2/3 and 3/3 have just been rebased.\n> Hiro, could you please have a look ? If everything is fine to you I'll\n> merge the series. We can then discuss the rest of the changes rebased on\n> top.\n>\n> Hirokazu Honda (3):\n> libcamera: V4L2Device: Replace VLA with std::vector in getControls()\n> libcamera: V4L2Device: Replace VLA with std::vector in setControls()\n> libcamera: V4L2Device: Use Span in updateControls()\n\nAll patches looks good and all tests are passed\n\nTested-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> include/libcamera/internal/v4l2_device.h | 4 +-\n> src/libcamera/v4l2_device.cpp | 73 +++++++++++-------------\n> 2 files changed, 36 insertions(+), 41 deletions(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E27ABBDC9C\n\tfor ;\n\tMon, 26 Apr 2021 10:29:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43DAC68882;\n\tMon, 26 Apr 2021 12:29:03 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4F12605BE\n\tfor ;\n\tMon, 26 Apr 2021 12:29:01 +0200 (CEST)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 475044000F;\n\tMon, 26 Apr 2021 10:29:00 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","Date":"Mon, 26 Apr 2021 12:29:42 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210426102942.pws2rcmju7p422qg@uno.localdomain>","References":"<20210426001220.15599-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210426001220.15599-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v6 0/3] libcamera: V4L2Device: VLA\n\tremoval","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]