[{"id":16508,"web_url":"https://patchwork.libcamera.org/comment/16508/","msgid":"<20210422095127.GD195599@pyrite.rasen.tech>","date":"2021-04-22T09:51:27","subject":"Re: [libcamera-devel] [RFC PATCH v2 00/12] FULL hardware level fixes","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Apr 22, 2021 at 06:40:50PM +0900, Paul Elder wrote:\n> This patchset switches to hardware level FULL, fixes many failures, and\n> sets up the infrastructure for pipeline handlers to get and set the\n> metadata. The tests that this patchset fixes are (in alphabetical order):\n> - android.hardware.camera2.cts.CameraDeviceTest#testCameraDeviceCreateCaptureBuilder\n> - android.hardware.camera2.cts.CameraDeviceTest#testCameraDeviceManualTemplate\n> - android.hardware.camera2.cts.CameraDeviceTest#testCameraDevicePreviewTemplate\n> - android.hardware.camera2.cts.CameraDeviceTest#testCameraDeviceRecordingTemplate\n> - android.hardware.camera2.cts.CameraDeviceTest#testCameraDeviceStillTemplate\n> - android.hardware.camera2.cts.CameraDeviceTest#testCameraDeviceVideoSnapShotTemplate\n> - android.hardware.camera2.cts.CaptureRequestTest#testAeModeAndLock\n> - android.hardware.camera2.cts.CaptureRequestTest#testAntiBandingModes\n> - android.hardware.camera2.cts.CaptureRequestTest#testAwbModeAndLock\n> - android.hardware.camera2.cts.CaptureRequestTest#testBlackLevelLock\n> - android.hardware.camera2.cts.CaptureRequestTest#testEdgeModeControlFastFps\n> - android.hardware.camera2.cts.CaptureRequestTest#testNoiseReductionModeControlFastFps\n> - android.hardware.camera2.cts.CaptureRequestTest#testToneMapControl\n> - android.hardware.camera2.cts.CaptureResultTest#testCameraCaptureResultAllKeys\n> - android.hardware.camera2.cts.ImageReaderTest#testDiscardFreeBuffers\n> - android.hardware.camera2.cts.ImageReaderTest#testFlexibleYuv\n> - android.hardware.camera2.cts.ImageReaderTest#testJpeg\n> - android.hardware.camera2.cts.ImageReaderTest#testLongProcessingRepeatingFlexibleYuv\n> - android.hardware.camera2.cts.ImageReaderTest#testRepeatingJpeg\n> - android.hardware.camera2.cts.StaticMetadataTest#testCapabilities\n> - android.hardware.camera2.cts.StaticMetadataTest#testHwSupportedLevel\n> \n> The following tests are mostly fixed, but fail one and only one frame\n> (frame duration is too short):\n> - android.hardware.camera2.cts.CaptureRequestTest#testEdgeModeControl\n> - android.hardware.camera2.cts.CaptureRequestTest#testNoiseReductionModeControl\n> - android.hardware.camera2.cts.SurfaceViewPreviewTest#testPreviewFpsRange\n> \n\nI forgot to mention that this patch series depends on Jacopo's patch\nseries: \"libcamera: Add sensor timestamp support \".\n\n\nPaul\n\n> Patch 1 fixes a typo.\n> \n> Patches 2 to 7 set up FULL hardware level, and hardcode values to pass\n> the CTS tests. Patches 8 to 12 then lay down infrastructure for the\n> pipeline handlers to set the metadata values, and make the ipu3 pipeline\n> handler do so to pass the aforementioned CTS tests.\n> \n> Paul Elder (12):\n> android: camera_device: Fix typo in result metadata allocation error\n> android: Switch to FULL\n> android: CameraDevice: Report proper min and max frame durations\n> android: jpeg: get ISO from SENSOR_SENSITIVITY\n> android: camera_device: Set static metadata for FULL requirements\n> android: camera_device: Set templates for FULL requirements\n> android: camera_device: Set result metadata for FULL requirements\n> controls: Add controls necessary for FULL compliance\n> pipeline: ipu3: Add controls for FULL compliance\n> android: camera_device: Translate android controls to libcamera\n> controls\n> pipeline: ipu3: Set request metadata for FULL compliance\n> android camera_device: Set result metadata from libcamera metadata\n> \n> src/android/camera_device.cpp | 421 +++++++++++++++++++++--\n> src/android/camera_device.h | 2 +\n> src/android/jpeg/post_processor_jpeg.cpp | 5 +-\n> src/libcamera/control_ids.yaml | 78 ++++-\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 86 ++++-\n> 5 files changed, 551 insertions(+), 41 deletions(-)\n> \n> -- \n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0B1BBDB15\n\tfor ;\n\tThu, 22 Apr 2021 09:51:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2788468862;\n\tThu, 22 Apr 2021 11:51:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4E0268852\n\tfor ;\n\tThu, 22 Apr 2021 11:51:33 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ADFE23EE\n\tfor ;\n\tThu, 22 Apr 2021 11:51:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"trMkHZbg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619085093;\n\tbh=+XmN1pmylkDqpwfgMvy7nn+rerUXJ0WnFr1Iw2FVQuE=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=trMkHZbg2manMlp31T1sbfv77E1g4RX54qmyGR8Al+uDhRezyoi5ds5lw9DvN3yWy\n\tH+hBFG3In8RC8Xb2B2rYkjQVZZ6Db1Fh+REIgh+uhs7ztR8PqNcUm1vZyCVLK/qWLM\n\twDloZiK9HpLB6fhoCsDBJki7BQN9Fg3fOHzallMQ=","Date":"Thu, 22 Apr 2021 18:51:27 +0900","From":"paul.elder@ideasonboard.com","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20210422095127.GD195599@pyrite.rasen.tech>","References":"<20210422094102.371772-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210422094102.371772-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH v2 00/12] FULL hardware level fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]