[{"id":16507,"web_url":"https://patchwork.libcamera.org/comment/16507/","msgid":"<1e9771f8-e2e3-4966-eb7f-6ad3f583a8c8@ideasonboard.com>","date":"2021-04-22T08:36:37","subject":"Re: [libcamera-devel] [PATCH v2 0/2] Fix support for core.mojom\n\tstructs","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Paul,\n\nOn 4/22/21 1:38 PM, Paul Elder wrote:\n> This patch series fixes support for structs defined in core.mojom with\n> skipHeader only.\n>\n> Previously these structs were only supported (tested) for use in custom\n> function parameters, but not as members of other structs. This patch\n> series fixed that.\n>\n> Paul Elder (2):\n>    utils: ipc: Support types defined in core.mojom with skipHeader only\n>    utils: ipc: Include instead of forward-declare CameraSensorInfo\n>\n>   include/libcamera/ipa/ipa_interface.h         |  6 +--\n>   .../module_ipa_serializer.h.tmpl              |  6 +++\n>   .../libcamera_templates/serializer.tmpl       | 38 +++++++++----------\n>   3 files changed, 27 insertions(+), 23 deletions(-)\n>\nYes, this version works as expected.\n\nTested-by: Umang Jain <umang.jain@ideasonboard.com>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B80BBDB17\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Apr 2021 08:36:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D685D6884C;\n\tThu, 22 Apr 2021 10:36:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32E1B68843\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Apr 2021 10:36:44 +0200 (CEST)","from localhost.localdomain (unknown [103.251.226.21])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DC50F3EE;\n\tThu, 22 Apr 2021 10:36:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rZuE70Q6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619080603;\n\tbh=j5zzCIOtsI6EUBY03d08/wlYsaMvj1w2xM+UB+wPMiI=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=rZuE70Q6hUcZAA5WLpK9bYZUDfjgVblYUsZ+rPG65SL21uYxPO7wwtWJ+xfVR14CI\n\tQ2ANxs886QsMTY3xZl7G3Kqo6dttNFEPEN+TKYjbBKpHpC4GmQlBmoWHisPgHYimp8\n\tXlUhfQwSHawEwwIpuq3RkMqo26qLC/Z1K1D0KT44=","To":"Paul Elder <paul.elder@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210422080816.364948-1-paul.elder@ideasonboard.com>","From":"Umang Jain <umang.jain@ideasonboard.com>","Message-ID":"<1e9771f8-e2e3-4966-eb7f-6ad3f583a8c8@ideasonboard.com>","Date":"Thu, 22 Apr 2021 14:06:37 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.11.0","MIME-Version":"1.0","In-Reply-To":"<20210422080816.364948-1-paul.elder@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v2 0/2] Fix support for core.mojom\n\tstructs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]