{"id":12059,"url":"https://patchwork.libcamera.org/api/covers/12059/?format=json","web_url":"https://patchwork.libcamera.org/cover/12059/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210422051857.20594-1-jeanmichel.hautbois@ideasonboard.com>","date":"2021-04-22T05:18:53","name":"[libcamera-devel,v6,0/4] Implement IPA algorithms and demo with IPU3","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/12059/mbox/","series":[{"id":1960,"url":"https://patchwork.libcamera.org/api/series/1960/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1960","date":"2021-04-22T05:18:53","name":"Implement IPA algorithms and demo with IPU3","version":6,"mbox":"https://patchwork.libcamera.org/series/1960/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/12059/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2DB6BDB15\n\tfor ;\n\tThu, 22 Apr 2021 05:19:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24B336884C;\n\tThu, 22 Apr 2021 07:19:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9993F60516\n\tfor ;\n\tThu, 22 Apr 2021 07:18:59 +0200 (CEST)","from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:e96c:3f42:9018:e1b2])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D4973EE;\n\tThu, 22 Apr 2021 07:18:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nQ7/V49D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619068739;\n\tbh=+Mn42RixfH1QfAKi2zftEkldL32+XhHCK0Fymn7pyw8=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=nQ7/V49DsGyuC2QE27kqz8s38XWhvQG+w5xmGqC/5RDjEHH28obPNiMHgwg1qcWex\n\t4Dfe1cGnJzkZ3KqVDuyX6/6V+xQtgd49jAbfHfP2VDBPbJxN9PN0nKE6TTQHhOl7rq\n\t0/2ZBCc6Zz6S21v2FUFenbLbC5r7ESKveXXtNkB4=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 22 Apr 2021 07:18:53 +0200","Message-Id":"<20210422051857.20594-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v6 0/4] Implement IPA algorithms and demo\n\twith IPU3","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Here is v6 of the IPA demonstration on IPU3.\nIt demonstrates a conjunction of automatic exposure (AGC)\nand automatic white balance (AWB).\n\nThe skeleton are extracted from RPi controller and probably subject to\nmodifications and discussions :\n- are the mandatory methods really those ?\n- how to exchange data between algorithms ?\n - metadata like RPi?\n - IPC ?\n - public methods?\n - controller API ?\n- is the controller needed at all ?\n\nThe implementation in IPU3 is tested on SGo2.\nIt is not perfect but shows a really better behaviour than default.\nRight now, the AGC algorithm is part of the RPi one, adapted to the\nstats and parameters we have in IPU3 on SGo2.\n\nChanges in v6:\n- rework to use ipa::ipu3 namespace\n- some comments adressed\n\nChanges in v5:\n- adress multiple issues found at review time\n- use RPi grey-world AWB algorithm and correct gains\n- prepare for a more generic ISP stat usage\n\nChanges in v4:\n- removed unneeded patch setting exposure and gains\n- improve documentation of Histogram class\n- take review comments \n\nChanges in v3:\n- introduce histogram class (for AGC)\n- add a patch to introduce parameter context saving\n- changes in AGC to simplify it using part of RPi work\n- changes in the AWB loop\n- calculate the grid for the parameters using the BDS size from pipeline\n handler\n\nIn v2:\n- splits AWB and AEC/AGC algorithms.\n- remove unused Controller\n- remove unused variables/methods\n- rename most of the class members\n\nJean-Michel Hautbois (4):\n ipa: Add a common interface for algorithm objects\n ipa: ipu3: Add a histogram class\n ipa: ipu3: Add support for IPU3 AWB algorithm\n ipa: ipu3: Add support for IPU3 AEC/AGC algorithm\n\n src/ipa/ipu3/ipu3.cpp | 96 +++++++++-\n src/ipa/ipu3/ipu3_agc.cpp | 202 ++++++++++++++++++++\n src/ipa/ipu3/ipu3_agc.h | 62 ++++++\n src/ipa/ipu3/ipu3_awb.cpp | 356 +++++++++++++++++++++++++++++++++++\n src/ipa/ipu3/ipu3_awb.h | 91 +++++++++\n src/ipa/ipu3/meson.build | 8 +-\n src/ipa/libipa/algorithm.cpp | 39 ++++\n src/ipa/libipa/algorithm.h | 24 +++\n src/ipa/libipa/histogram.cpp | 153 +++++++++++++++\n src/ipa/libipa/histogram.h | 40 ++++\n src/ipa/libipa/meson.build | 6 +-\n 11 files changed, 1067 insertions(+), 10 deletions(-)\n create mode 100644 src/ipa/ipu3/ipu3_agc.cpp\n create mode 100644 src/ipa/ipu3/ipu3_agc.h\n create mode 100644 src/ipa/ipu3/ipu3_awb.cpp\n create mode 100644 src/ipa/ipu3/ipu3_awb.h\n create mode 100644 src/ipa/libipa/algorithm.cpp\n create mode 100644 src/ipa/libipa/algorithm.h\n create mode 100644 src/ipa/libipa/histogram.cpp\n create mode 100644 src/ipa/libipa/histogram.h"}