[{"id":16852,"web_url":"https://patchwork.libcamera.org/comment/16852/","msgid":"","date":"2021-05-10T06:13:48","subject":"Re: [libcamera-devel] [PATCH v4 0/2] ipu3: Enable to handle a\n\tnumber of concurrent requests","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Gentle ping for review.\n\nOn Wed, Apr 21, 2021 at 3:48 PM Hirokazu Honda wrote:\n\n> PipelineHandler originally discards a request with ENOBUFS or\n> ENOMEM when a buffer is not available. The request will be\n> successful if enough buffers are available. This patch series\n> enables to process requests even if no buffer is available then\n> by storing the requests and retry queuing later.\n>\n> Change in v4:\n> - Squash 1/3 and 3/3\n> - Use FrameBuffer::cancel() introduced by Kieran's patch series\n> - Address comments by Laurent\n>\n> Change in v3:\n> - Cancel pending buffers correctly upon PipelineHandlerIPU3::stop()\n>\n> Change in v2:\n> - Move a queue of pending requests to IPU3CameraData\n> - Pass queuePendingRequests() as signal to CIO2Device and\n> IPU3Frame and invoke it from them.\n>\n> Hirokazu Honda (2):\n> pipeline: ipu3: Store requests in the case a buffer shortage\n> libcamera: ipu3: Try queuing pending requests if a buffer is available\n>\n> src/libcamera/pipeline/ipu3/cio2.cpp | 4 +-\n> src/libcamera/pipeline/ipu3/cio2.h | 2 +\n> src/libcamera/pipeline/ipu3/frames.cpp | 6 +-\n> src/libcamera/pipeline/ipu3/frames.h | 4 ++\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 77 +++++++++++++++++++-------\n> 5 files changed, 70 insertions(+), 23 deletions(-)\n>\n> --\n> 2.31.1.368.gbe11c130af-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F1ECBF829\n\tfor ;\n\tMon, 10 May 2021 06:14:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66C15688E4;\n\tMon, 10 May 2021 08:14:01 +0200 (CEST)","from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com\n\t[IPv6:2a00:1450:4864:20::52d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B2B896153C\n\tfor ;\n\tMon, 10 May 2021 08:13:59 +0200 (CEST)","by mail-ed1-x52d.google.com with SMTP id r11so2458621edt.13\n\tfor ;\n\tSun, 09 May 2021 23:13:59 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"hFAn86XN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=ZQc8DijF2NEQOEeZDDb9Ik2S/8mPD7WB/vS0Xyf2gqg=;\n\tb=hFAn86XNEqRCDrxR3Uo/MN4XAqy+aw1eW49zVAxXrB3HfItxO8pm93pZceqOxA9ncS\n\tT0WnUOQmf+tyuhik/Qy7fnK615BRIYDm+1J6YeUg7nPvrd3IOw0FNtZkoCfWYSARsLs9\n\tCR8cnpT8WqKVXv9oP0Q6rMwy0uLuMsr7qLREI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=ZQc8DijF2NEQOEeZDDb9Ik2S/8mPD7WB/vS0Xyf2gqg=;\n\tb=QnIR//mzP8GbNLH1CPp+rGhK+hOIPKVCA60CykiGO7M/dJJ/sBfEwG+1YG6X7f7h4G\n\tq/3eT0//9qQY9JERvu5+2LeJyOcOWcxqT66fQFeA1/GEPi6/SJKfmrk+j2NUHTB2vOW4\n\trORY7C8K1pvqC/09mULPlOWyfLzZ/C3g2DbPIpsqg/Ru3GEYitzNeqdPmWFEapiTF+yI\n\tRRZptwZP0PuL+2mew9OuKzyF9eLrPHrr3jJchrMPd0bgub69Kq6p6yCsH45lUCbyIjlU\n\tNVc4LoPNGbUFhqjAervUAfVekRtPRHQzMTfkhm9rWLprMDboxmKdOrJqmfPBjhFOAyMT\n\tMmVQ==","X-Gm-Message-State":"AOAM530EPT3tbO8Wkh0OmvPdCdGZU2+Ywc3WP3CwbOyIgAXnXEQMbpOm\n\taGLvVDzCXxRJHFQsg+0QDZExQRQNDaYL1BR4WsTpyUUXAUo=","X-Google-Smtp-Source":"ABdhPJxZsw4MsxYLv4lfK/XenXM3pOhF25jarUw+wbIvwI4RfGWh48jn/zSAV1OxvgikHuHoheMbIuN21jm+fVkGVPY=","X-Received":"by 2002:a50:8e44:: with SMTP id 4mr27537339edx.244.1620627239249;\n\tSun, 09 May 2021 23:13:59 -0700 (PDT)","MIME-Version":"1.0","References":"<20210421064847.324118-1-hiroh@chromium.org>","In-Reply-To":"<20210421064847.324118-1-hiroh@chromium.org>","From":"Hirokazu Honda ","Date":"Mon, 10 May 2021 15:13:48 +0900","Message-ID":"","To":"libcamera devel ","Subject":"Re: [libcamera-devel] [PATCH v4 0/2] ipu3: Enable to handle a\n\tnumber of concurrent requests","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============7578442766957242774==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]