[{"id":16349,"web_url":"https://patchwork.libcamera.org/comment/16349/","msgid":"<33679f14-9c3f-d226-1ef3-e54bccb81cef@ideasonboard.com>","date":"2021-04-19T13:31:42","subject":"Re: [libcamera-devel] [PATCH 00/13] Support SensorTimestamp metadata","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 19/04/2021 14:14, Jacopo Mondi wrote:\n> Hello,\n>   v2 grow quite significatively compared to v1 :/\n> \n> Reason is that now all the pipeline handlers report SensorTimestamp, each\n> one with its own specificities.\n> \n> Here and there a few drive-by fixes, and two patches for cam to add support\n> for listing all the metadata associated with a completed Request.\n> \n> v1->v2:\n> - controls: Refer to CLOCK_BOOTTIME explicitely\n> - pipeline:\n>   - Add support for SensorTimestamp in all pipelines\n> - HAL\n>   - Assume SensorTimestamp is always available.\n> \n> In future, it might be beneficial to add to lc-compliance a test to make\n> sure SensorTimestamp is reported. Maybe a 'mandatory' flag can be added to\n> the controls definition for that purpose.\n\nAha, I came here specifically to say ... shouldn't we add a test to\nlc-compliance to make sure the timestamp is set ...\n\n:-)\n\nI'm not sure if a mandatory flag makes sense yet - but perhaps it could\nsimplify things.\n\nAre there other expected mandatory metadata values in requests?\n\n--\nKieran\n\n\n> Thanks\n>    j\n> \n> Jacopo Mondi (13):\n>   libcamera: controls: Destage 'SensorTimestamp'\n>   libcamera: ipu3: Report sensor timestamp\n>   libcamera: uvc: Report sensor timestamp\n>   libcamera: rkisp1: Do not over-write metadata\n>   libcamera: rkisp1: Report sensor timestamp\n>   libcamera: simple: Report sensor timestamp\n>   libcamera: vimc: Report sensor timestamp\n>   libcamera: buffer: Re-work setRequest() documentation\n>   libcamera: raspberrypi: Do not over-write metadata\n>   libcamera: raspberry: Report sensor timestamp\n>   cam: Add option to print the Request metadata\n>   cam: Implement OptMetadata\n>   android: camera_device: Use controls::SensorTimestamp\n> \n>  src/android/camera_device.cpp                 | 19 +++++-----------\n>  src/android/camera_device.h                   |  3 +--\n>  src/cam/capture.cpp                           | 15 ++++++++++++-\n>  src/cam/capture.h                             |  1 +\n>  src/cam/main.cpp                              |  3 +++\n>  src/cam/main.h                                |  1 +\n>  src/libcamera/buffer.cpp                      | 11 ++++++++--\n>  src/libcamera/control_ids.yaml                | 21 ++++++++++++------\n>  src/libcamera/pipeline/ipu3/ipu3.cpp          |  9 ++++++++\n>  .../pipeline/raspberrypi/raspberrypi.cpp      | 22 +++++++++++++++++--\n>  src/libcamera/pipeline/rkisp1/rkisp1.cpp      | 13 ++++++++++-\n>  src/libcamera/pipeline/simple/simple.cpp      | 11 ++++++++++\n>  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  3 +++\n>  src/libcamera/pipeline/vimc/vimc.cpp          |  4 ++++\n>  14 files changed, 108 insertions(+), 28 deletions(-)\n> \n> --\n> 2.31.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30E5BBD814\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 19 Apr 2021 13:31:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE7A668831;\n\tMon, 19 Apr 2021 15:31:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8E1F602CD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Apr 2021 15:31:44 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7AAA9D4A;\n\tMon, 19 Apr 2021 15:31:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BlzkZLkx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618839104;\n\tbh=vhCNvHvtz3wfvY6bYNtw7LhUUe6y7c8veBwHZ+ebBJk=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=BlzkZLkxxg1TM9MhPmfsGAXW60nPPVdAfyivUnINt1gG8J+S1DDo9u50/Yltvk99r\n\tqCPUL29YJxaUhihhKdzzqFAjv0UWEiz+gggruWy3bbSMPGyeAJdik8jJiQFzXhVDfb\n\tQvmaP3uoZg/nPRqnV3UZd2gxVTt8zaI/udMppIhI=","To":"Jacopo Mondi <jacopo@jmondi.org>, libcamera-devel@lists.libcamera.org","References":"<20210419131433.22920-1-jacopo@jmondi.org>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Organization":"Ideas on Board","Message-ID":"<33679f14-9c3f-d226-1ef3-e54bccb81cef@ideasonboard.com>","Date":"Mon, 19 Apr 2021 14:31:42 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<20210419131433.22920-1-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 00/13] Support SensorTimestamp metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":16399,"web_url":"https://patchwork.libcamera.org/comment/16399/","msgid":"<YH8+LQcjzozqe4DD@pendragon.ideasonboard.com>","date":"2021-04-20T20:48:45","subject":"Re: [libcamera-devel] [PATCH 00/13] Support SensorTimestamp metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Apr 19, 2021 at 03:14:20PM +0200, Jacopo Mondi wrote:\n> Hello,\n>   v2 grow quite significatively compared to v1 :/\n> \n> Reason is that now all the pipeline handlers report SensorTimestamp, each\n> one with its own specificities.\n> \n> Here and there a few drive-by fixes, and two patches for cam to add support\n> for listing all the metadata associated with a completed Request.\n> \n> v1->v2:\n> - controls: Refer to CLOCK_BOOTTIME explicitely\n> - pipeline:\n>   - Add support for SensorTimestamp in all pipelines\n> - HAL\n>   - Assume SensorTimestamp is always available.\n> \n> In future, it might be beneficial to add to lc-compliance a test to make\n> sure SensorTimestamp is reported. Maybe a 'mandatory' flag can be added to\n> the controls definition for that purpose.\n\nThat's a good idea. I foresee that libcamera will define device profiles\nin the future, similar to the Android camera HAL hardware levels, and\ncontrols will then be documented as optional/mandatory for the different\nprofiles. We can start with a simple mandatory/required flag.\n\n> Jacopo Mondi (13):\n>   libcamera: controls: Destage 'SensorTimestamp'\n>   libcamera: ipu3: Report sensor timestamp\n>   libcamera: uvc: Report sensor timestamp\n>   libcamera: rkisp1: Do not over-write metadata\n>   libcamera: rkisp1: Report sensor timestamp\n>   libcamera: simple: Report sensor timestamp\n>   libcamera: vimc: Report sensor timestamp\n>   libcamera: buffer: Re-work setRequest() documentation\n>   libcamera: raspberrypi: Do not over-write metadata\n>   libcamera: raspberry: Report sensor timestamp\n>   cam: Add option to print the Request metadata\n>   cam: Implement OptMetadata\n>   android: camera_device: Use controls::SensorTimestamp\n> \n>  src/android/camera_device.cpp                 | 19 +++++-----------\n>  src/android/camera_device.h                   |  3 +--\n>  src/cam/capture.cpp                           | 15 ++++++++++++-\n>  src/cam/capture.h                             |  1 +\n>  src/cam/main.cpp                              |  3 +++\n>  src/cam/main.h                                |  1 +\n>  src/libcamera/buffer.cpp                      | 11 ++++++++--\n>  src/libcamera/control_ids.yaml                | 21 ++++++++++++------\n>  src/libcamera/pipeline/ipu3/ipu3.cpp          |  9 ++++++++\n>  .../pipeline/raspberrypi/raspberrypi.cpp      | 22 +++++++++++++++++--\n>  src/libcamera/pipeline/rkisp1/rkisp1.cpp      | 13 ++++++++++-\n>  src/libcamera/pipeline/simple/simple.cpp      | 11 ++++++++++\n>  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  3 +++\n>  src/libcamera/pipeline/vimc/vimc.cpp          |  4 ++++\n>  14 files changed, 108 insertions(+), 28 deletions(-)","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8307DBDB15\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Apr 2021 20:48:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DFC4168842;\n\tTue, 20 Apr 2021 22:48:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7E7368839\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Apr 2021 22:48:49 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4515A411;\n\tTue, 20 Apr 2021 22:48:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tEeCkYCg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618951729;\n\tbh=jzL/DI6Qe4nZLZmtpc/iSaXHJ4F8rCqTlwbNtOblAw4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tEeCkYCgyi+IKme1mVMd6nUO71wBObYiid92MOjCVS77D0UsjijUi50IF/U7w1xGa\n\tOcLmkxZmqIm3NEXLbnPNmtb8GS5x2OcpbVgkCkAiLb4dU9kpi6fX3n0u38A6Hfxa61\n\tx95ScekISU6pr+aBQ9fjyQlh3BYKPP29+kSXfFEw=","Date":"Tue, 20 Apr 2021 23:48:45 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Message-ID":"<YH8+LQcjzozqe4DD@pendragon.ideasonboard.com>","References":"<20210419131433.22920-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210419131433.22920-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 00/13] Support SensorTimestamp metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":16400,"web_url":"https://patchwork.libcamera.org/comment/16400/","msgid":"<YH8+hMTUdXK3EA5V@pendragon.ideasonboard.com>","date":"2021-04-20T20:50:12","subject":"Re: [libcamera-devel] [PATCH 00/13] Support SensorTimestamp metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Apr 19, 2021 at 02:31:42PM +0100, Kieran Bingham wrote:\n> On 19/04/2021 14:14, Jacopo Mondi wrote:\n> > Hello,\n> >   v2 grow quite significatively compared to v1 :/\n> > \n> > Reason is that now all the pipeline handlers report SensorTimestamp, each\n> > one with its own specificities.\n> > \n> > Here and there a few drive-by fixes, and two patches for cam to add support\n> > for listing all the metadata associated with a completed Request.\n> > \n> > v1->v2:\n> > - controls: Refer to CLOCK_BOOTTIME explicitely\n> > - pipeline:\n> >   - Add support for SensorTimestamp in all pipelines\n> > - HAL\n> >   - Assume SensorTimestamp is always available.\n> > \n> > In future, it might be beneficial to add to lc-compliance a test to make\n> > sure SensorTimestamp is reported. Maybe a 'mandatory' flag can be added to\n> > the controls definition for that purpose.\n> \n> Aha, I came here specifically to say ... shouldn't we add a test to\n> lc-compliance to make sure the timestamp is set ...\n\nCould you file a feature request for lc-compliance in bugs.libcamera.org\n?\n\n> :-)\n> \n> I'm not sure if a mandatory flag makes sense yet - but perhaps it could\n> simplify things.\n> \n> Are there other expected mandatory metadata values in requests?\n> \n> --\n> Kieran\n> \n> \n> > Thanks\n> >    j\n> > \n> > Jacopo Mondi (13):\n> >   libcamera: controls: Destage 'SensorTimestamp'\n> >   libcamera: ipu3: Report sensor timestamp\n> >   libcamera: uvc: Report sensor timestamp\n> >   libcamera: rkisp1: Do not over-write metadata\n> >   libcamera: rkisp1: Report sensor timestamp\n> >   libcamera: simple: Report sensor timestamp\n> >   libcamera: vimc: Report sensor timestamp\n> >   libcamera: buffer: Re-work setRequest() documentation\n> >   libcamera: raspberrypi: Do not over-write metadata\n> >   libcamera: raspberry: Report sensor timestamp\n> >   cam: Add option to print the Request metadata\n> >   cam: Implement OptMetadata\n> >   android: camera_device: Use controls::SensorTimestamp\n> > \n> >  src/android/camera_device.cpp                 | 19 +++++-----------\n> >  src/android/camera_device.h                   |  3 +--\n> >  src/cam/capture.cpp                           | 15 ++++++++++++-\n> >  src/cam/capture.h                             |  1 +\n> >  src/cam/main.cpp                              |  3 +++\n> >  src/cam/main.h                                |  1 +\n> >  src/libcamera/buffer.cpp                      | 11 ++++++++--\n> >  src/libcamera/control_ids.yaml                | 21 ++++++++++++------\n> >  src/libcamera/pipeline/ipu3/ipu3.cpp          |  9 ++++++++\n> >  .../pipeline/raspberrypi/raspberrypi.cpp      | 22 +++++++++++++++++--\n> >  src/libcamera/pipeline/rkisp1/rkisp1.cpp      | 13 ++++++++++-\n> >  src/libcamera/pipeline/simple/simple.cpp      | 11 ++++++++++\n> >  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  3 +++\n> >  src/libcamera/pipeline/vimc/vimc.cpp          |  4 ++++\n> >  14 files changed, 108 insertions(+), 28 deletions(-)","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B985EBDB15\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Apr 2021 20:50:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7AED468842;\n\tTue, 20 Apr 2021 22:50:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF13168839\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Apr 2021 22:50:16 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 767CA411;\n\tTue, 20 Apr 2021 22:50:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Me/fo7s7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618951816;\n\tbh=c9vnQZWwuXMYKOitbyzNqoJaT8/+fbeVQ11uxTY0dqY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Me/fo7s7EE7SFR7BX1LffGnX5LAXEvjZrva/6AWtTWK4irQiuAoUpwKieY7+5xFE6\n\t8at6gzfFUDm+aOHu0MwKwvhjYxzqrj7fRStIDMw9tzRffPOYDTbZaW4nb8gN/uEgfx\n\tJDdVbCXFPsCbRenkq6MQATleOcdlU3YrpmzRKh+0=","Date":"Tue, 20 Apr 2021 23:50:12 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Message-ID":"<YH8+hMTUdXK3EA5V@pendragon.ideasonboard.com>","References":"<20210419131433.22920-1-jacopo@jmondi.org>\n\t<33679f14-9c3f-d226-1ef3-e54bccb81cef@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<33679f14-9c3f-d226-1ef3-e54bccb81cef@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 00/13] Support SensorTimestamp metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":16460,"web_url":"https://patchwork.libcamera.org/comment/16460/","msgid":"<20210421144419.ayjirpkhxafardzq@uno.localdomain>","date":"2021-04-21T14:44:19","subject":"Re: [libcamera-devel] [PATCH 00/13] Support SensorTimestamp metadata","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hello,\n\nOn Tue, Apr 20, 2021 at 11:50:12PM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> On Mon, Apr 19, 2021 at 02:31:42PM +0100, Kieran Bingham wrote:\n> > On 19/04/2021 14:14, Jacopo Mondi wrote:\n> > > Hello,\n> > >   v2 grow quite significatively compared to v1 :/\n> > >\n> > > Reason is that now all the pipeline handlers report SensorTimestamp, each\n> > > one with its own specificities.\n> > >\n> > > Here and there a few drive-by fixes, and two patches for cam to add support\n> > > for listing all the metadata associated with a completed Request.\n> > >\n> > > v1->v2:\n> > > - controls: Refer to CLOCK_BOOTTIME explicitely\n> > > - pipeline:\n> > >   - Add support for SensorTimestamp in all pipelines\n> > > - HAL\n> > >   - Assume SensorTimestamp is always available.\n> > >\n> > > In future, it might be beneficial to add to lc-compliance a test to make\n> > > sure SensorTimestamp is reported. Maybe a 'mandatory' flag can be added to\n> > > the controls definition for that purpose.\n> >\n> > Aha, I came here specifically to say ... shouldn't we add a test to\n> > lc-compliance to make sure the timestamp is set ...\n>\n> Could you file a feature request for lc-compliance in bugs.libcamera.org\n> ?\n>\n\nDone\nhttps://bugs.libcamera.org/show_bug.cgi?id=27\n\n> > :-)\n> >\n> > I'm not sure if a mandatory flag makes sense yet - but perhaps it could\n> > simplify things.\n> >\n> > Are there other expected mandatory metadata values in requests?\n> >\n> > --\n> > Kieran\n> >\n> >\n> > > Thanks\n> > >    j\n> > >\n> > > Jacopo Mondi (13):\n> > >   libcamera: controls: Destage 'SensorTimestamp'\n> > >   libcamera: ipu3: Report sensor timestamp\n> > >   libcamera: uvc: Report sensor timestamp\n> > >   libcamera: rkisp1: Do not over-write metadata\n> > >   libcamera: rkisp1: Report sensor timestamp\n> > >   libcamera: simple: Report sensor timestamp\n> > >   libcamera: vimc: Report sensor timestamp\n> > >   libcamera: buffer: Re-work setRequest() documentation\n> > >   libcamera: raspberrypi: Do not over-write metadata\n> > >   libcamera: raspberry: Report sensor timestamp\n> > >   cam: Add option to print the Request metadata\n> > >   cam: Implement OptMetadata\n> > >   android: camera_device: Use controls::SensorTimestamp\n> > >\n> > >  src/android/camera_device.cpp                 | 19 +++++-----------\n> > >  src/android/camera_device.h                   |  3 +--\n> > >  src/cam/capture.cpp                           | 15 ++++++++++++-\n> > >  src/cam/capture.h                             |  1 +\n> > >  src/cam/main.cpp                              |  3 +++\n> > >  src/cam/main.h                                |  1 +\n> > >  src/libcamera/buffer.cpp                      | 11 ++++++++--\n> > >  src/libcamera/control_ids.yaml                | 21 ++++++++++++------\n> > >  src/libcamera/pipeline/ipu3/ipu3.cpp          |  9 ++++++++\n> > >  .../pipeline/raspberrypi/raspberrypi.cpp      | 22 +++++++++++++++++--\n> > >  src/libcamera/pipeline/rkisp1/rkisp1.cpp      | 13 ++++++++++-\n> > >  src/libcamera/pipeline/simple/simple.cpp      | 11 ++++++++++\n> > >  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  3 +++\n> > >  src/libcamera/pipeline/vimc/vimc.cpp          |  4 ++++\n> > >  14 files changed, 108 insertions(+), 28 deletions(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B1E9BDB16\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Apr 2021 14:43:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B2696884A;\n\tWed, 21 Apr 2021 16:43:40 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1554068835\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Apr 2021 16:43:39 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 788EB40003;\n\tWed, 21 Apr 2021 14:43:38 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 21 Apr 2021 16:44:19 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20210421144419.ayjirpkhxafardzq@uno.localdomain>","References":"<20210419131433.22920-1-jacopo@jmondi.org>\n\t<33679f14-9c3f-d226-1ef3-e54bccb81cef@ideasonboard.com>\n\t<YH8+hMTUdXK3EA5V@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<YH8+hMTUdXK3EA5V@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 00/13] Support SensorTimestamp metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]