{"id":11970,"url":"https://patchwork.libcamera.org/api/covers/11970/?format=json","web_url":"https://patchwork.libcamera.org/cover/11970/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210416222830.335755-1-nfraprado@collabora.com>","date":"2021-04-16T22:28:28","name":"[libcamera-devel,v2,0/2] lc-compliance: Add test to queue more requests than hardware depth","submitter":{"id":84,"url":"https://patchwork.libcamera.org/api/people/84/?format=json","name":"Nícolas F. R. A. Prado","email":"nfraprado@collabora.com"},"mbox":"https://patchwork.libcamera.org/cover/11970/mbox/","series":[{"id":1943,"url":"https://patchwork.libcamera.org/api/series/1943/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1943","date":"2021-04-16T22:28:28","name":"lc-compliance: Add test to queue more requests than hardware depth","version":2,"mbox":"https://patchwork.libcamera.org/series/1943/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/11970/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 312D5BD237\n\tfor ;\n\tFri, 16 Apr 2021 22:29:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4FE96880C;\n\tSat, 17 Apr 2021 00:29:18 +0200 (CEST)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B2B3687F3\n\tfor ;\n\tSat, 17 Apr 2021 00:29:17 +0200 (CEST)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nfraprado) with ESMTPSA id B44F81F43A4A"],"From":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 16 Apr 2021 19:28:28 -0300","Message-Id":"<20210416222830.335755-1-nfraprado@collabora.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 0/2] lc-compliance: Add test to queue\n\tmore requests than hardware depth","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This series adds a new test to lc-compliance that tests queuing a lot of\nrequests at once and hopefully exposing the issue described in [1].\n\nI hardcoded the amount of buffers to allocate at once to 8 since more than that\nwould cause errors when allocating.\n\nHirokazu,\nsince you have a patch series addressing this issue on the IPU3\npipeline [2], could you test this series? If both my and your patch series are\nworking, lc-compliance should crash before applying your series but run through\ncompletion after applying it.\n\nChanges in v2:\n- Renamed and reworded commits and series\n- Dropped patches 2 and 3, which were hacks to test, and added patch 1 to add\n count to FrameBufferAllocator\n- Thanks to Niklas:\n - Created new standalone test instead of looping over the other tests\n\n[1] https://bugs.libcamera.org/show_bug.cgi?id=24\n[2] https://lists.libcamera.org/pipermail/libcamera-devel/2021-April/019108.html\n\nv1: https://lists.libcamera.org/pipermail/libcamera-devel/2021-April/019139.html\n\nNícolas F. R. A. Prado (2):\n libcamera: framebuffer_allocator: Make allocate() accept count\n lc-compliance: Add test to queue more requests than hardware depth\n\n include/libcamera/camera.h | 3 +-\n include/libcamera/framebuffer_allocator.h | 2 +-\n include/libcamera/internal/pipeline_handler.h | 3 +-\n src/cam/capture.cpp | 2 +-\n src/lc-compliance/simple_capture.cpp | 69 +++++++++++++++++--\n src/lc-compliance/simple_capture.h | 16 ++++-\n src/lc-compliance/single_stream.cpp | 28 +++++++-\n src/libcamera/camera.cpp | 5 +-\n src/libcamera/framebuffer_allocator.cpp | 5 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 9 ++-\n .../pipeline/raspberrypi/raspberrypi.cpp | 9 ++-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++-\n src/libcamera/pipeline/simple/simple.cpp | 9 ++-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 9 ++-\n src/libcamera/pipeline/vimc/vimc.cpp | 9 ++-\n src/libcamera/pipeline_handler.cpp | 1 +\n src/qcam/main_window.cpp | 2 +-\n test/camera/capture.cpp | 2 +-\n test/camera/statemachine.cpp | 2 +-\n test/mapped-buffer.cpp | 2 +-\n 20 files changed, 160 insertions(+), 36 deletions(-)"}