{"id":11949,"url":"https://patchwork.libcamera.org/api/covers/11949/?format=json","web_url":"https://patchwork.libcamera.org/cover/11949/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210415135213.94511-1-jacopo@jmondi.org>","date":"2021-04-15T13:52:08","name":"[libcamera-devel,v6,0/5] android: Introduce HAL configuration file","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/11949/mbox/","series":[{"id":1936,"url":"https://patchwork.libcamera.org/api/series/1936/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1936","date":"2021-04-15T13:52:08","name":"android: Introduce HAL configuration file","version":6,"mbox":"https://patchwork.libcamera.org/series/1936/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/11949/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7FF1BD22F\n\tfor ;\n\tThu, 15 Apr 2021 13:51:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7DD0B68814;\n\tThu, 15 Apr 2021 15:51:39 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE7EF605AE\n\tfor ;\n\tThu, 15 Apr 2021 15:51:37 +0200 (CEST)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 6E50E240011\n\tfor ;\n\tThu, 15 Apr 2021 13:51:37 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 15 Apr 2021 15:52:08 +0200","Message-Id":"<20210415135213.94511-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v6 0/5] android: Introduce HAL\n\tconfiguration file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A new iteration to address Laurent's and Kieran's comments:\n- Configuration:\n - call open() (now parseConfigurationFile()) at construction time\n - s/Fatal/Error\n - search configuration file only in sysconfdir\n - s/CameraProps/CameraConfigData/\n - s/valid/isValid()\n\n- Integration\n - Take Laurent's suggestion in in camera_hal_manager.cpp\n - Drop default = nullptr in CameraDevice::initialize()\n\n=== I have not run this version === (I'm physically away from Soraka today)\nThe only thing that can fail compared to previous version is the path lookup.\n\nI'm sending it out anyway, mostly to comment on patch 6/6... will follow up\nthere...\n\nThanks\n j\n\nJacopo Mondi (4):\n libcamera: List dependency for Android Camera3 HAL\n android: Add CameraHalConfig class\n android: camera_device: Get properties from configuration\n android: soraka: Add camera HAL configuration\n\nKieran Bingham (1):\n src: meson: Define system paths\n\n README.rst | 3 +\n src/android/camera_device.cpp | 56 +++-\n src/android/camera_device.h | 3 +-\n src/android/camera_hal_config.cpp | 400 ++++++++++++++++++++++++\n src/android/camera_hal_config.h | 40 +++\n src/android/camera_hal_manager.cpp | 33 +-\n src/android/camera_hal_manager.h | 3 +\n src/android/data/soraka/camera_hal.yaml | 8 +\n src/android/meson.build | 2 +\n src/ipa/meson.build | 17 +-\n src/meson.build | 9 +\n 11 files changed, 557 insertions(+), 17 deletions(-)\n create mode 100644 src/android/camera_hal_config.cpp\n create mode 100644 src/android/camera_hal_config.h\n create mode 100644 src/android/data/soraka/camera_hal.yaml\n\n--\n2.31.1"}