[{"id":16260,"web_url":"https://patchwork.libcamera.org/comment/16260/","msgid":"<20210414033717.zrj3ldd2dgrkgh7y@basti-TUXEDO-Book-XA1510>","date":"2021-04-14T03:37:17","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: log: Small improvements","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hey Laurent,\n\nOn 14.04.2021 00:51, Laurent Pinchart wrote:\n>Hello,\n>\n>This small patch series is a drive-by change the improves the logging\n\ns/ the improves/, that improves/\n\n>implementation a little bit.\n>\n>I was hoping that builtins could give us pretty function names, but\n>that's not the case, so I'm not entirely sure that 2/2 is worth it.\n>\n>Laurent Pinchart (2):\n> libcamera: log: De-duplicate _log() functions and LogMessage\n> constructor\n> libcamera: log: Use compiler builtins to retrieve file and line number\n>\n> include/libcamera/internal/log.h | 20 ++++-----\n> src/libcamera/log.cpp | 75 +++++---------------------------\n> 2 files changed, 20 insertions(+), 75 deletions(-)\n>\n>-- \n>Regards,\n>\n>Laurent Pinchart\n>\n>_______________________________________________\n>libcamera-devel mailing list\n>libcamera-devel@lists.libcamera.org\n>https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06E6BBD224\n\tfor ;\n\tWed, 14 Apr 2021 03:37:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 748FA687EC;\n\tWed, 14 Apr 2021 05:37:20 +0200 (CEST)","from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB6E8602CD\n\tfor ;\n\tWed, 14 Apr 2021 05:37:18 +0200 (CEST)","from submission (posteo.de [89.146.220.130]) \n\tby mout01.posteo.de (Postfix) with ESMTPS id 7DC911A022B\n\tfor ;\n\tWed, 14 Apr 2021 05:37:18 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4FKp7f0Sh7z9rxK;\n\tWed, 14 Apr 2021 05:37:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"fGipodfP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1618371438; bh=1zghbT5EZ2weKKMSZjoSlMj3uQhEwyYUNqZWBzxsnK0=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=fGipodfPJYwTfMXkOK5oEdE77IHNOYoShxofBBDuoowRmDoXyHQn2JELHOHdNUyFv\n\tcqVsWz3qGHmljctfD3/7rLQW7Gj47oIoF52nif3wiwIJSxYG87h/K305xJuoDBqX70\n\tE12nboZVyfZbX9uFANqR0yXG7Q/9MqSzbg+RA+uWKLL+ie3F05AlZKc0hkfeeB2xTK\n\t3fhJbuUyY5AXqwFfWEqPTARAWxHk1Nr99kFzOVXIq/dEMud4aviMirjSheB+4yhhJL\n\tFBt3RLhD6lBwUzVHhr6VVcYj1ltskOHazTfOjBG/yIsNflu2NyJBfOisYxIUffFcwq\n\tuKW6HTwu7thpg==","Date":"Wed, 14 Apr 2021 05:37:17 +0200","From":"Sebastian Fricke ","To":"Laurent Pinchart ","Message-ID":"<20210414033717.zrj3ldd2dgrkgh7y@basti-TUXEDO-Book-XA1510>","References":"<20210413215121.15538-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210413215121.15538-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: log: Small improvements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]