{"id":11921,"url":"https://patchwork.libcamera.org/api/covers/11921/?format=json","web_url":"https://patchwork.libcamera.org/cover/11921/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210413215121.15538-1-laurent.pinchart@ideasonboard.com>","date":"2021-04-13T21:51:19","name":"[libcamera-devel,0/2] libcamera: log: Small improvements","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/11921/mbox/","series":[{"id":1924,"url":"https://patchwork.libcamera.org/api/series/1924/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1924","date":"2021-04-13T21:51:19","name":"libcamera: log: Small improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/1924/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/11921/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 311E6BD224\n\tfor ;\n\tTue, 13 Apr 2021 21:52:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E2805687D6;\n\tTue, 13 Apr 2021 23:52:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFD79602D1\n\tfor ;\n\tTue, 13 Apr 2021 23:52:15 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 950B59F0\n\tfor ;\n\tTue, 13 Apr 2021 23:52:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"niwHgGA4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618350734;\n\tbh=Iq0GV2J/Jm+UYS3dZyeHbVrIkgixaj/v/OPdQ0sYbv4=;\n\th=From:To:Subject:Date:From;\n\tb=niwHgGA40ttj+3hS95iSHIgU2cahBdj8CFyuPB99J5pCU5lRFHonp6yfezb2USkgV\n\t6Zib45Xo78IEjTVza/J67R90XhKDnnhRRnFWn5WC2dqY3AY/C873wGS7IR5Sga/dey\n\tjL6lAmTcwk7cXo+fkwWyZnXyu7eV+ED8UNlVgkYA=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 14 Apr 2021 00:51:19 +0300","Message-Id":"<20210413215121.15538-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.28.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 0/2] libcamera: log: Small improvements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis small patch series is a drive-by change the improves the logging\nimplementation a little bit.\n\nI was hoping that builtins could give us pretty function names, but\nthat's not the case, so I'm not entirely sure that 2/2 is worth it.\n\nLaurent Pinchart (2):\n libcamera: log: De-duplicate _log() functions and LogMessage\n constructor\n libcamera: log: Use compiler builtins to retrieve file and line number\n\n include/libcamera/internal/log.h | 20 ++++-----\n src/libcamera/log.cpp | 75 +++++---------------------------\n 2 files changed, 20 insertions(+), 75 deletions(-)"}