[{"id":16509,"web_url":"https://patchwork.libcamera.org/comment/16509/","msgid":"<20210422095334.GE195599@pyrite.rasen.tech>","date":"2021-04-22T09:53:34","subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Add sensor timestamp\n\tsupport","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Wed, Apr 07, 2021 at 06:06:41PM +0200, Jacopo Mondi wrote:\n> Hello,\n> we have an issue with reporting sensor timestamps correctly to android.\n> \n> We currently use one of the buffers timestamps, which fails some CTS tests that\n> verify that the reported SENSOR_TIMESTAMP is in the frame duration range\n> reported as static metadata\n> Ie. android.hardware.camera2.cts.CaptureRequestTest#testNoiseReductionModeControl\n> when run in FULL mode.\n> \n> This series de-stages the SensorTimestamp control we had defined as draft\n> control and populates it in the IPU3 pipeline handler with the timestamp\n> of the CIO2 raw buffer. It then reports it to Android.\n> \n> Paul: I didn't manage to reproduce the error on you in-development CTS patches\n> so I can't say this series fixes the test. But I've manually collected the\n> reported duration and run them through a little script and verified they all\n> fall in the expected range. Could you test your failing test with this series\n> on top ?\n\nIt practically fixes the issue, thanks! As mentioned before, there's\njust one single frame that's still too fast, but other than that I think\nit's fine.\n\nTested-by: Paul Elder \n\n> \n> Thanks\n> j\n> \n> Jacopo Mondi (3):\n> libcamera: controls: Destage 'SensorTimestamp'\n> libcamera: ipu3: Report sensor timestamp\n> android: camera_device: Use controls::SensorTimestamp\n> \n> src/android/camera_device.cpp | 33 +++++++++++++++++-----------\n> src/android/camera_device.h | 3 +--\n> src/libcamera/control_ids.yaml | 21 ++++++++++++------\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 9 ++++++++\n> 4 files changed, 44 insertions(+), 22 deletions(-)\n> \n> --\n> 2.31.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B9C9BDB17\n\tfor ;\n\tThu, 22 Apr 2021 09:53:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 597CB6885E;\n\tThu, 22 Apr 2021 11:53:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 740E368852\n\tfor ;\n\tThu, 22 Apr 2021 11:53:41 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 13D453EE;\n\tThu, 22 Apr 2021 11:53:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Cq89RbHb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619085221;\n\tbh=9Iq1Ef9aDEKzsfMMdTQ5XhCKZLqSIRqGRa/ngfmOrLg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Cq89RbHbW0I9sKhXMQv9vztoxwI+96T9GnkjIMpjM9OXAcobmutWyoqr9XTP8tFoK\n\t+ryxFWlI2qe2iR5iPn7VFKp6t72AT3uZM9faxbSOgRwNgsXENX3n1AvrdBEjwv7eQO\n\tcJ9bAlmUfpfgqCu2NCtzDvzQYZH9rDYHq/bx9n8o=","Date":"Thu, 22 Apr 2021 18:53:34 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20210422095334.GE195599@pyrite.rasen.tech>","References":"<20210407160644.58326-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210407160644.58326-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Add sensor timestamp\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16514,"web_url":"https://patchwork.libcamera.org/comment/16514/","msgid":"<20210422124431.6vmvcrknsv62jucz@uno.localdomain>","date":"2021-04-22T12:44:31","subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Add sensor timestamp\n\tsupport","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Thu, Apr 22, 2021 at 06:53:34PM +0900, paul.elder@ideasonboard.com wrote:\n> Hi Jacopo,\n>\n> On Wed, Apr 07, 2021 at 06:06:41PM +0200, Jacopo Mondi wrote:\n> > Hello,\n> > we have an issue with reporting sensor timestamps correctly to android.\n> >\n> > We currently use one of the buffers timestamps, which fails some CTS tests that\n> > verify that the reported SENSOR_TIMESTAMP is in the frame duration range\n> > reported as static metadata\n> > Ie. android.hardware.camera2.cts.CaptureRequestTest#testNoiseReductionModeControl\n> > when run in FULL mode.\n> >\n> > This series de-stages the SensorTimestamp control we had defined as draft\n> > control and populates it in the IPU3 pipeline handler with the timestamp\n> > of the CIO2 raw buffer. It then reports it to Android.\n> >\n> > Paul: I didn't manage to reproduce the error on you in-development CTS patches\n> > so I can't say this series fixes the test. But I've manually collected the\n> > reported duration and run them through a little script and verified they all\n> > fall in the expected range. Could you test your failing test with this series\n> > on top ?\n>\n> It practically fixes the issue, thanks! As mentioned before, there's\n> just one single frame that's still too fast, but other than that I think\n> it's fine.\n>\n> Tested-by: Paul Elder \n>\n\nThanks, be aware that v3 is out :)\n\n> >\n> > Thanks\n> > j\n> >\n> > Jacopo Mondi (3):\n> > libcamera: controls: Destage 'SensorTimestamp'\n> > libcamera: ipu3: Report sensor timestamp\n> > android: camera_device: Use controls::SensorTimestamp\n> >\n> > src/android/camera_device.cpp | 33 +++++++++++++++++-----------\n> > src/android/camera_device.h | 3 +--\n> > src/libcamera/control_ids.yaml | 21 ++++++++++++------\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 9 ++++++++\n> > 4 files changed, 44 insertions(+), 22 deletions(-)\n> >\n> > --\n> > 2.31.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D15C1BDB15\n\tfor ;\n\tThu, 22 Apr 2021 12:43:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 539CA68858;\n\tThu, 22 Apr 2021 14:43:52 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1824F68806\n\tfor ;\n\tThu, 22 Apr 2021 14:43:51 +0200 (CEST)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id A1165FF810;\n\tThu, 22 Apr 2021 12:43:50 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","Date":"Thu, 22 Apr 2021 14:44:31 +0200","From":"Jacopo Mondi ","To":"paul.elder@ideasonboard.com","Message-ID":"<20210422124431.6vmvcrknsv62jucz@uno.localdomain>","References":"<20210407160644.58326-1-jacopo@jmondi.org>\n\t<20210422095334.GE195599@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210422095334.GE195599@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Add sensor timestamp\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]