{"id":11860,"url":"https://patchwork.libcamera.org/api/covers/11860/?format=json","web_url":"https://patchwork.libcamera.org/cover/11860/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210407160644.58326-1-jacopo@jmondi.org>","date":"2021-04-07T16:06:41","name":"[libcamera-devel,0/3] libcamera: Add sensor timestamp support","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/11860/mbox/","series":[{"id":1902,"url":"https://patchwork.libcamera.org/api/series/1902/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1902","date":"2021-04-07T16:06:41","name":"libcamera: Add sensor timestamp support","version":1,"mbox":"https://patchwork.libcamera.org/series/1902/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/11860/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 760A7BD1F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  7 Apr 2021 16:06:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC6BC687DF;\n\tWed,  7 Apr 2021 18:06:14 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73E68687A1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  7 Apr 2021 18:06:13 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id BED2AE000E;\n\tWed,  7 Apr 2021 16:06:12 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed,  7 Apr 2021 18:06:41 +0200","Message-Id":"<20210407160644.58326-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 0/3] libcamera: Add sensor timestamp\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hello,\n   we have an issue with reporting sensor timestamps correctly to android.\n\nWe currently use one of the buffers timestamps, which fails some CTS tests that\nverify that the reported SENSOR_TIMESTAMP is in the frame duration range\nreported as static metadata\nIe. android.hardware.camera2.cts.CaptureRequestTest#testNoiseReductionModeControl\nwhen run in FULL mode.\n\nThis series de-stages the SensorTimestamp control we had defined as draft\ncontrol and populates it in the IPU3 pipeline handler with the timestamp\nof the CIO2 raw buffer. It then reports it to Android.\n\nPaul: I didn't manage to reproduce the error on you in-development CTS patches\nso I can't say this series fixes the test. But I've manually collected the\nreported duration and run them through a little script and verified they all\nfall in the expected range. Could you test your failing test with this series\non top ?\n\nThanks\n  j\n\nJacopo Mondi (3):\n  libcamera: controls: Destage 'SensorTimestamp'\n  libcamera: ipu3: Report sensor timestamp\n  android: camera_device: Use controls::SensorTimestamp\n\n src/android/camera_device.cpp        | 33 +++++++++++++++++-----------\n src/android/camera_device.h          |  3 +--\n src/libcamera/control_ids.yaml       | 21 ++++++++++++------\n src/libcamera/pipeline/ipu3/ipu3.cpp |  9 ++++++++\n 4 files changed, 44 insertions(+), 22 deletions(-)\n\n--\n2.31.1"}