[{"id":1564,"web_url":"https://patchwork.libcamera.org/comment/1564/","msgid":"<672a60c5-7e23-2908-e654-a155b5a875bd@ideasonboard.com>","date":"2019-05-09T08:34:44","subject":"Re: [libcamera-devel] [PATCH 0/5] test: v4l2_device: Cleanups and a\n\tsmall speed increase","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 08/05/2019 17:58, Niklas Söderlund wrote:\n> Hi,\n> \n> This series started as an itch to speed up the tests as I run them quiet \n> often and find them useful, and resulted in a bit of a clean up as well. \n> It depends on [1].\n> \n> With this applied I shave almost 7 seconds of the v4l2 device tests \n> which is nice!\n\n\\o/ Ship it... wait - you didn't just remove the tests did you ? :-D\n\n> \n> 1. [PATCH v2 00/11] libcamerea: Add support for exclusive access to \n> cameras between processes\n> \n> Niklas Söderlund (5):\n> test: v4l2_device: Order class sections\n> test: v4l2_device: Implement functions inside class definition in cpp\n> files\n> test: v4l2_device: Allow each test to specify which device and entity\n> to test\n> test: v4l2_device: Reset media links and set a resolution\n> test: v4l2_device: Switch most tests to vimc\n> \n> test/v4l2_device/buffer_sharing.cpp | 21 +++++----\n> test/v4l2_device/capture_async.cpp | 2 +-\n> test/v4l2_device/double_open.cpp | 3 ++\n> test/v4l2_device/formats.cpp | 61 ++++++++++++++-------------\n> test/v4l2_device/request_buffers.cpp | 4 ++\n> test/v4l2_device/stream_on_off.cpp | 3 ++\n> test/v4l2_device/v4l2_device_test.cpp | 25 +++++++++--\n> test/v4l2_device/v4l2_device_test.h | 6 ++-\n> 8 files changed, 77 insertions(+), 48 deletions(-)\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25A7560E50\n\tfor ;\n\tThu, 9 May 2019 10:34:48 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D4B1529;\n\tThu, 9 May 2019 10:34:47 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1557390887;\n\tbh=RKIRugtRNFqDc+7f4NxgoHtiEB7U9zFAz9ynnW/7Qvo=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=CexOR9ikKHG9tnQZAnvkO3gLj+XhM4DCWvImMRUWsI6k2hbkZ5w8zjXCt6Dr7/ROZ\n\tNxpU8ZApGzZpD41Eq7c7nk2bmcHtDSgffJob0AC6W+R43B3yAk9NMUgu1BhqGHqaY9\n\tKutFn84uj0OH0hWR7wMdwbkkNW3h2Ea3OECdIdhQ=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190508165814.26201-1-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<672a60c5-7e23-2908-e654-a155b5a875bd@ideasonboard.com>","Date":"Thu, 9 May 2019 09:34:44 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.6.1","MIME-Version":"1.0","In-Reply-To":"<20190508165814.26201-1-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 0/5] test: v4l2_device: Cleanups and a\n\tsmall speed increase","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 09 May 2019 08:34:48 -0000"}},{"id":1565,"web_url":"https://patchwork.libcamera.org/comment/1565/","msgid":"<20190509084314.GB28561@bigcity.dyn.berto.se>","date":"2019-05-09T08:43:14","subject":"Re: [libcamera-devel] [PATCH 0/5] test: v4l2_device: Cleanups and a\n\tsmall speed increase","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2019-05-09 09:34:44 +0100, Kieran Bingham wrote:\n> Hi Niklas,\n> \n> On 08/05/2019 17:58, Niklas Söderlund wrote:\n> > Hi,\n> > \n> > This series started as an itch to speed up the tests as I run them quiet \n> > often and find them useful, and resulted in a bit of a clean up as well. \n> > It depends on [1].\n> > \n> > With this applied I shave almost 7 seconds of the v4l2 device tests \n> > which is nice!\n> \n> \\o/ Ship it... wait - you didn't just remove the tests did you ? :-D\n\nWhy yes! It solved two of my issues, now the test suite runs faster \n_and_ my code no longer fails ;-)\n\n> \n> > \n> > 1. [PATCH v2 00/11] libcamerea: Add support for exclusive access to \n> > cameras between processes\n> > \n> > Niklas Söderlund (5):\n> > test: v4l2_device: Order class sections\n> > test: v4l2_device: Implement functions inside class definition in cpp\n> > files\n> > test: v4l2_device: Allow each test to specify which device and entity\n> > to test\n> > test: v4l2_device: Reset media links and set a resolution\n> > test: v4l2_device: Switch most tests to vimc\n> > \n> > test/v4l2_device/buffer_sharing.cpp | 21 +++++----\n> > test/v4l2_device/capture_async.cpp | 2 +-\n> > test/v4l2_device/double_open.cpp | 3 ++\n> > test/v4l2_device/formats.cpp | 61 ++++++++++++++-------------\n> > test/v4l2_device/request_buffers.cpp | 4 ++\n> > test/v4l2_device/stream_on_off.cpp | 3 ++\n> > test/v4l2_device/v4l2_device_test.cpp | 25 +++++++++--\n> > test/v4l2_device/v4l2_device_test.h | 6 ++-\n> > 8 files changed, 77 insertions(+), 48 deletions(-)\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F7CF60E50\n\tfor ;\n\tThu, 9 May 2019 10:43:16 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id u27so930585lfg.10\n\tfor ;\n\tThu, 09 May 2019 01:43:16 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tb15sm215537ljj.1.2019.05.09.01.43.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 09 May 2019 01:43:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=ABndFP5Ujdc+qNaU67octVhD5UCDSCw5L6I99s8WKOQ=;\n\tb=PBiSlQs06PN/r8qszHRDpwEXpvzILz6TERkk/tv/1xgjMkZ0ia+iVjYKsp3rNHt/Jf\n\tehw4rekthN0NHroddL2o4Txi6cLXNHhMhvAuebsSjhT/Ee0Nm6UETsXL49GkwUlJL2Vf\n\tmxXb2QiGuaicxt3l/yL0zfn7RSneFOTRO1KcNFJ8RraxO/41vvaAXRQohUhDgBoWByNY\n\t7rd7kX0nNCC9iieJWM373NaDT3EHNdGL6Q6ecNheGERHnQVmpIzvAwR0RemikcqFtqGH\n\ti/3OH3z2n7YnfuKqwuNmBDGdUyyn/5HJflIxV9FbflDZbtec8nyYoEEE12mrulK2peEg\n\t038g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=ABndFP5Ujdc+qNaU67octVhD5UCDSCw5L6I99s8WKOQ=;\n\tb=PhiyHtxS6zuK5+84XwYwWxoBeUf+WEHW1hexvudINcLRRa2ChdHhVDaaEJyG63LH3r\n\tN0a/o6vf+BTyoeAvfPKgg62FeB/5y6UIgjuYj5ysxUQkjw9urGR9wZpbMbv1fE+MizG+\n\txy464s8vZgUApDhApZLI2VW0YDnZDZ2oSZ/n3Fw+k39hc35f1OS5fKGkblZwHz0NsbCU\n\tSrOrVAK0JR4aNBE52njlOZ8WV/kGHMlZzLHYau5lG9vr9uyqKNT4FIkJXPoHH50bAtDh\n\tTuQ1hSC67Df2JAF0FXRi2aGbO8ErqD+HdpaG5RDXmiJzmpAv21eXXVY55WWewSok3gCB\n\tSj5A==","X-Gm-Message-State":"APjAAAV1Gyhda3ogAeCiizkD+R0gtZKlD4yzDinXXKJyr3xCjuTbgsJ9\n\tpmO28Yq19OJdnMJc5ZwE42yhdWnL8AA=","X-Google-Smtp-Source":"APXvYqwAkTBXzEjfat1HwyrQQ+Cu9Cx4NbqeFV/hYjoP2CO/Sl122Ic4S+RPW0U608/r9+oXX3+Xkg==","X-Received":"by 2002:a19:a412:: with SMTP id\n\tq18mr1697405lfc.142.1557391395487; \n\tThu, 09 May 2019 01:43:15 -0700 (PDT)","Date":"Thu, 9 May 2019 10:43:14 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190509084314.GB28561@bigcity.dyn.berto.se>","References":"<20190508165814.26201-1-niklas.soderlund@ragnatech.se>\n\t<672a60c5-7e23-2908-e654-a155b5a875bd@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<672a60c5-7e23-2908-e654-a155b5a875bd@ideasonboard.com>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH 0/5] test: v4l2_device: Cleanups and a\n\tsmall speed increase","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 09 May 2019 08:43:16 -0000"}}]