{"id":11761,"url":"https://patchwork.libcamera.org/api/covers/11761/?format=json","web_url":"https://patchwork.libcamera.org/cover/11761/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210329091552.157208-1-hiroh@chromium.org>","date":"2021-03-29T09:15:49","name":"[libcamera-devel,v2,0/3] Add RequestError to Request::Status","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"mbox":"https://patchwork.libcamera.org/cover/11761/mbox/","series":[{"id":1860,"url":"https://patchwork.libcamera.org/api/series/1860/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1860","date":"2021-03-29T09:15:49","name":"Add RequestError to Request::Status","version":2,"mbox":"https://patchwork.libcamera.org/series/1860/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/11761/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C4C2C32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Mar 2021 09:16:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4BFF68784;\n\tMon, 29 Mar 2021 11:16:01 +0200 (CEST)","from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com\n\t[IPv6:2607:f8b0:4864:20::102b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 171EE6877E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Mar 2021 11:16:00 +0200 (CEST)","by mail-pj1-x102b.google.com with SMTP id ha17so5708715pjb.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Mar 2021 02:15:59 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:1db7:ae60:9288:b906])\n\tby smtp.gmail.com with ESMTPSA id\n\tn2sm15818122pga.57.2021.03.29.02.15.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 29 Mar 2021 02:15:57 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"GCHTuj3K\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=NaLzW1I6NLg1Brc1SEPiEs2f6Tkgnasb+zkTLW23CUI=;\n\tb=GCHTuj3KehBhl2DMwxdq/s6LvVRSSgFv3OShBpGPBEkKLooluOOae1C/WKb5GT3oVd\n\t1mhQjkUixlD43A6nfsfH7Qrc/MrTj2OIDqnqUhWwgNQ+DOsMFZZpiGv0SB8Sm1eMAJ2w\n\tsC2mmCYFcrtD3loFEVGVfgqlacHkgu6g6vClo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=NaLzW1I6NLg1Brc1SEPiEs2f6Tkgnasb+zkTLW23CUI=;\n\tb=d9R5PHRybeeaFon+xvNlNeLssEFfKimQBnS+CWX+t8BkGN5H3acl5Uuf2uC+PF03Mm\n\tlm/icyXmLvMIU15aCXvHo491E1CTOjP70cxelJOJcVdpUMvm32Mv41cwJj80gR/QAdV4\n\tFMJIWwvvUp1v3yehqMxwswl3kiQqNaGR7mb/ZkK12Yf+gW7OiIukbyi+cdbEji58Tloj\n\tfUrhinCFnqQH1C8ZZGdmyesMkoFqbV5yBnXJ4x1Fng0xsXfzVbeolI6N8nD7lQNYW6Vv\n\twHJtCyBlxT1SH0Kg8Mt3yqNzN+PvVwWfV0M4mwZZaFv3YSKE1G3Rara1gETJgYzGFk4Z\n\t+2bg==","X-Gm-Message-State":"AOAM530Gs6a1BnokG5Ln7ndgoehdEkjlXGDzFi3z8lwSSbLSmL3fEFv5\n\tHkEKqUrndAdGbDioyOpTWQP8UiAF3qQv/g==","X-Google-Smtp-Source":"ABdhPJzt/bA5XHa6PJnItxqesBnRU4LI46ajrH/0zOjax9oP6Yw/XZDALvZER/d+0zTYiDZms9+09w==","X-Received":"by 2002:a17:902:c1c4:b029:e6:7bc9:71fd with SMTP id\n\tc4-20020a170902c1c4b02900e67bc971fdmr26989874plc.5.1617009358150; \n\tMon, 29 Mar 2021 02:15:58 -0700 (PDT)","From":"Hirokazu Honda <hiroh@chromium.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 29 Mar 2021 18:15:49 +0900","Message-Id":"<20210329091552.157208-1-hiroh@chromium.org>","X-Mailer":"git-send-email 2.31.0.291.g576ba9dcdaf-goog","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 0/3] Add RequestError to Request::Status","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"PipelineHandler doesn't notify a client an error during\nprocessing a capture request. This addresses the issue by adding\nthe new enum value to Request::Status, so that each Camera client\ncan know whether the error happens by Request::status().\n\nChange in v2:\n- Adopt adding RequestError to Request::Status rather than adding an error code to Request\n- Handle RequestCancelled and RequestError differently in a request completion.\n\nHirokazu Honda (3):\n  libcamera: PipelineHandler: Make queueRequest() void function\n  libcamera: Request: Add RequestError to Status\n  Regard a request error in the request completion\n\n Documentation/guides/application-developer.rst |  2 ++\n include/libcamera/internal/pipeline_handler.h  |  2 +-\n include/libcamera/request.h                    |  2 ++\n src/cam/capture.cpp                            |  5 +++++\n src/gstreamer/gstlibcamerasrc.cpp              |  6 +++++-\n src/libcamera/camera.cpp                       |  6 ++++--\n src/libcamera/pipeline_handler.cpp             | 11 +++++------\n src/libcamera/request.cpp                      | 17 +++++++++++------\n src/qcam/main_window.cpp                       |  4 ++++\n src/v4l2/v4l2_camera.cpp                       |  5 +++++\n 10 files changed, 44 insertions(+), 16 deletions(-)\n\n--\n2.31.0.291.g576ba9dcdaf-goog"}