{"id":11676,"url":"https://patchwork.libcamera.org/api/covers/11676/?format=json","web_url":"https://patchwork.libcamera.org/cover/11676/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210324070757.3530377-1-hiroh@chromium.org>","date":"2021-03-24T07:07:49","name":"[libcamera-devel,v2,0/8] Improve pointer types in android HAL adaptation layer","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"mbox":"https://patchwork.libcamera.org/cover/11676/mbox/","series":[{"id":1825,"url":"https://patchwork.libcamera.org/api/series/1825/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1825","date":"2021-03-24T07:07:51","name":"Improve pointer types in android HAL adaptation layer","version":2,"mbox":"https://patchwork.libcamera.org/series/1825/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/11676/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B887C32E7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Mar 2021 07:08:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6EC6A68D58;\n\tWed, 24 Mar 2021 08:08:14 +0100 (CET)","from mail-pl1-x632.google.com (mail-pl1-x632.google.com\n\t[IPv6:2607:f8b0:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0865B68D58\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Mar 2021 08:08:12 +0100 (CET)","by mail-pl1-x632.google.com with SMTP id v23so7423290ple.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Mar 2021 00:08:11 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:7c07:24cd:c637:7fab])\n\tby smtp.gmail.com with ESMTPSA id\n\te63sm1246860pfe.208.2021.03.24.00.08.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 24 Mar 2021 00:08:04 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"WNHYBZpj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=kGOIpyVb8rLtevdPcAnClUbOQz6sMO+W84Zf7wBl4hw=;\n\tb=WNHYBZpj/Yi6aK6qaEFB5EUU8fGogkBG+ZPCqVYcSaEMJn8fGqPdpPJZYmiPcNi3ip\n\tT+L6UHHcIuYgiTy+w4P0n+1xxBFdj6/H/JRIrXl6bRrd9rFcxcqhdBh20Y/Y9WHVjUFm\n\tgRugSvXt4paSjrLCR/NTJdSWDQgw/t26ziPQM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=kGOIpyVb8rLtevdPcAnClUbOQz6sMO+W84Zf7wBl4hw=;\n\tb=Rlyu0g1ebtnYULKtNLssMTHNJiMvCI3uN/WVPvUlw1Y9RAyPVzV3ANn14lZ8SmP4N8\n\tfUYWQCYIbyv5DrDujH2aqvglEZl+8l2z08SD7nC6Mum8gvliS9euVUf32j8gR+OiQn7v\n\tMHFK3dRiUNNsW0LxFXT6ZQR7QE1J03xXXiUBrCoQdpPQJOXUFS9xIG4pLeHx3cStaXmw\n\t1M+HLKm5k927dgp9LkMmrdzdJUWhL4OSz3AhG+orPrZpAYLU6PhdfkjVaYAv04m8O0s1\n\tSMI0Rf5yT65pHAM6D+Or/zYgb0rH23oovbTHp4tJeBqlB1ZRAd6KDPwoca8qgtgLxPPO\n\tZjsg==","X-Gm-Message-State":"AOAM5302cXmylNfYHBLObPhhWVpfvBls+Hbv+8o/XUAb2w0FE4AQe8Ge\n\tRpy7h+ubXlU2l0vhuj5T9xOTNxMV855FEw==","X-Google-Smtp-Source":"ABdhPJz6WrNfAMXo+2QyM164XZczoJTbUNFlbF2Hn75ldHjPZHaVB4d8kjJShJral74B76maU5O5Pg==","X-Received":"by 2002:a17:90b:3909:: with SMTP id\n\tob9mr2063382pjb.181.1616569684584; \n\tWed, 24 Mar 2021 00:08:04 -0700 (PDT)","From":"Hirokazu Honda <hiroh@chromium.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 24 Mar 2021 16:07:49 +0900","Message-Id":"<20210324070757.3530377-1-hiroh@chromium.org>","X-Mailer":"git-send-email 2.31.0.291.g576ba9dcdaf-goog","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 0/8] Improve pointer types in android\n\tHAL adaptation layer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"This patch series is intended to clarify the ownership of objects\nand omit manual new/delete code by improving pointer types in\nandroid HAL adaptation layer.\n\nThe changes in v2:\n- Address Laurent's review comments.\n\nHirokazu Honda (8):\n  android: CameraHalManager: Hold CameraDevice with std::unique_ptr\n  android: CameraHalManager: Hold CameraManager with std::unique_ptr\n  android: CameraHalManager: Fix a function call of a moved Camera\n  android: CameraDevice: Take shared_ptr in constructor\n  android: CameraDevice: Return const shared_ptr& by camera()\n  android: Camera3RequestDescriptor: Manage buffers with std::vector\n  android: CameraDevice: Manage staticMetadata_ with std::unique_ptr\n  android: CameraDevice: Manage requestTemplates_ with std::unique_ptr\n\n src/android/camera_device.cpp      | 92 ++++++++++++------------------\n src/android/camera_device.h        | 19 +++---\n src/android/camera_hal_manager.cpp | 25 +++-----\n src/android/camera_hal_manager.h   |  4 +-\n 4 files changed, 57 insertions(+), 83 deletions(-)\n\n--\n2.31.0.291.g576ba9dcdaf-goog"}