[{"id":15787,"web_url":"https://patchwork.libcamera.org/comment/15787/","msgid":"","date":"2021-03-22T08:56:57","subject":"Re: [libcamera-devel] [PATCH 0/7] Raspberry Pi: ipa::init()\n\trestructuring","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for all these patches. I did have a look through them but\ndidn't really have anything significant to comment on. However, can I\nplease add\n\nTested-by: David Plowman \n\nfor the whole set?\n\nThanks!\nDavid\n\nOn Wed, 17 Mar 2021 at 10:02, Naushir Patuck wrote:\n>\n> Hi,\n>\n> This series uses Paul's recent work and moves some initialisation code from ipa::configure()\n> into ipa::init(). As a consequence, the pipeline handler is now able to selectively open\n> the Unicam embedded data node in pipeline_handler::match(), removing some of the existing\n> ugliness in dealing with opening this node.\n>\n> Brief patch breakdown:\n>\n> Patch 1/7: Adds the sensor model string to IPASettings.\n> Patch 2/7: Moves the CamHelper initialise to ipa::init().\n> Patch 3/7: Conditionally open the embedded data node in pipeline_handler::match().\n> Patch 4/7: Move controller initialise to ipa::init().\n> Patches 5/7 - 7/7: Some tidy-ups (remove unused member variables, some renaming) after the above refactoring.\n>\n> Thanks,\n> Naush\n>\n> Naushir Patuck (7):\n> ipa: Add sensor model string to IPASettings\n> pipeline: ipa: raspberrypi: Open the CamHelper on ipa::init()\n> pipeline: raspberrypi: Conditionally open the embedded data node\n> ipa: raspberrypi: Move the controller initialise to ipa::init()\n> ipa: raspberrypi: Remove unused member variables\n> ipa: raspberrypi: Rationalise parameters to ipa::start()\n> ipa: raspberrypi: Rationalise parameters to ipa::configure()\n>\n> include/libcamera/ipa/core.mojom | 8 ++\n> include/libcamera/ipa/raspberrypi.mojom | 27 ++--\n> src/ipa/raspberrypi/raspberrypi.cpp | 110 +++++++--------\n> .../pipeline/raspberrypi/raspberrypi.cpp | 128 ++++++++----------\n> src/libcamera/pipeline/vimc/vimc.cpp | 2 +-\n> test/ipa/ipa_interface_test.cpp | 2 +-\n> 6 files changed, 119 insertions(+), 158 deletions(-)\n>\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34207C32E1\n\tfor ;\n\tMon, 22 Mar 2021 08:57:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1A70E68D58;\n\tMon, 22 Mar 2021 09:57:13 +0100 (CET)","from mail-ot1-x336.google.com (mail-ot1-x336.google.com\n\t[IPv6:2607:f8b0:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BC816051E\n\tfor ;\n\tMon, 22 Mar 2021 09:57:10 +0100 (CET)","by mail-ot1-x336.google.com with SMTP id\n\t68-20020a9d0f4a0000b02901b663e6258dso15170880ott.13\n\tfor ;\n\tMon, 22 Mar 2021 01:57:10 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"QadpLWJt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=D2IB+d/jBk79dbOsst332Op4c3h9Hh8KAW+UVd9KyxQ=;\n\tb=QadpLWJtTCt4rzsYjWugTM7bkZLOoOKGvC7PQdWnXMp2sObQhh98VEkO8kWiGQdIWk\n\tbKCspM0lzU6CHCfHf2/K0L8i9YgxVhBkX9QVbNM99WAI0+vJ0zFrhR/ZIlK9sdVwxabL\n\tvX583IAzYuHwMo0crH1fyYoozMpJcs4Os6hUBF4Sh+KIfBK/R/YGkZoHZwLehqfiVXQ8\n\tDwo0fztxR7qAGq061WHOy9pwaBH/xMxgofVr6dBOYO2iiW3QvBJwUl+ARiYqil0T7oqJ\n\tOORjWdz+oYV4QDOVm7iw9HXuqy8YW1sMg7m6fu3qnXpMY+P0XxMEDOzb0q82z2MH33gd\n\tUnIQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=D2IB+d/jBk79dbOsst332Op4c3h9Hh8KAW+UVd9KyxQ=;\n\tb=If8nYefkrDxaYROPMWePHXlevDYXTCSK28GMAy1loDLtqNQHKZUH4dsL+SauKwaIva\n\tUh/s+68oneGiopFWdF989181jydcmF6K4z4ScdFDe0hVMJl/rl3VNCz5Y9M6VauBnXDJ\n\t6eFSPMjXHMo+gGCMcKVyd0Sped1Y9x7qKDdb+OR52od0xkOW64jnosTgmkWTUmH4Xqto\n\tyJPGCYPkl8YAYkoqEASZLRT4HPws8rgfZxsTs6ZZYAJQon2QVnspYkQ7X3TueFresrym\n\tHBGJ0pUdF/XBLmeLZf3ZAMXthHrCentVPoff3X5zzjH4GDsMAH4kw4jAJiGoaHMNJxI5\n\tj+9w==","X-Gm-Message-State":"AOAM532vHLXAopGotqQ1TLYrZlgkaQ6wwx5Yt5K42LJlcWIX/esAjGT2\n\toOt+iYa+8YlB5QVShorbkCdjyB0373e1iV7av2jr2A==","X-Google-Smtp-Source":"ABdhPJzr/QgOfUB7piviIcqLA8BKGrfbqxnOTn2JAmAm/si7Xv0phalCM0hAZtPmhuxd2Fztgr2YTQhn99CZZ7XEoB0=","X-Received":"by 2002:a9d:6ad6:: with SMTP id\n\tm22mr10365871otq.160.1616403428787; \n\tMon, 22 Mar 2021 01:57:08 -0700 (PDT)","MIME-Version":"1.0","References":"<20210317100211.1067585-1-naush@raspberrypi.com>","In-Reply-To":"<20210317100211.1067585-1-naush@raspberrypi.com>","From":"David Plowman ","Date":"Mon, 22 Mar 2021 08:56:57 +0000","Message-ID":"","To":"Naushir Patuck ","Subject":"Re: [libcamera-devel] [PATCH 0/7] Raspberry Pi: ipa::init()\n\trestructuring","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]