{"id":11580,"url":"https://patchwork.libcamera.org/api/covers/11580/?format=json","web_url":"https://patchwork.libcamera.org/cover/11580/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210316101842.18674-1-jeanmichel.hautbois@ideasonboard.com>","date":"2021-03-16T10:18:37","name":"[libcamera-devel,v2,0/2] Prepare IPU3 pipeline to pass BDS to IPA","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/11580/mbox/","series":[{"id":1793,"url":"https://patchwork.libcamera.org/api/series/1793/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1793","date":"2021-03-16T10:18:37","name":"Prepare IPU3 pipeline to pass BDS to IPA","version":2,"mbox":"https://patchwork.libcamera.org/series/1793/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/11580/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 85A5FBD80C\n\tfor ;\n\tTue, 16 Mar 2021 10:18:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D21A68D48;\n\tTue, 16 Mar 2021 11:18:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4CB7602E8\n\tfor ;\n\tTue, 16 Mar 2021 11:18:44 +0100 (CET)","from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:f840:1816:ba68:a009])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 59456D8B;\n\tTue, 16 Mar 2021 11:18:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BB+p5IzP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615889924;\n\tbh=VdKmdfqc2Stxcm50y2CSO546uxh9z15AxPdXCBv9MUE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=BB+p5IzPhc1gu9p8wwU66hidIA9Zdr+2oLPZYuS+q6ZTNRNS0sk4w6werQKzjc0N9\n\tdpolxEfX3043XecRzULSCW+WmNDcLfjNQRo4D06HBvqp9Noo559xbMFajjw9Bsui45\n\t3WhNLh57A1vR+uDZD2PzLBmBS0jQjm72hE7W76YE=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 16 Mar 2021 11:18:37 +0100","Message-Id":"<20210316101842.18674-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 0/2] Prepare IPU3 pipeline to pass BDS\n\tto IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"As said in patch [1/2] the IPA will need to use the BDS configuration\nbecause it configures a grid to get AWB statistics from the firmware.\nThose statistics are then used to apply a bunch of parameters.\n\nThe IPU3 pipe configuration was done in validate(), so moved it to\nconfigure(). And the ipa was configured at start(), configuring when all\nthe pipeline is configured sounds better.\n\nJean-Michel Hautbois (2):\n libcamera: ipu3: Move Imgu configuration to IPU3CameraData\n libcamera: ipu3: Pass the BDS rectangle at IPA configure call\n\n include/libcamera/ipa/ipu3.mojom | 2 +-\n src/ipa/ipu3/ipu3.cpp | 7 +++--\n src/libcamera/pipeline/ipu3/ipu3.cpp | 46 +++++++++++++---------------\n 3 files changed, 27 insertions(+), 28 deletions(-)"}