[{"id":15643,"web_url":"https://patchwork.libcamera.org/comment/15643/","msgid":"<20210313091837.f5las5l2dnewva3p@uno.localdomain>","date":"2021-03-13T09:18:37","subject":"Re: [libcamera-devel] [PATCH v2 0/8] IPU3 Stability","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran\n\nOn Fri, Mar 12, 2021 at 05:47:19AM +0000, Kieran Bingham wrote:\n> This series continues the investigation and resolution of stability\n> issues identified on the IPU3 platform and pipeline handler.\n>\n> Patches [1/8] and [2/8] are split from a test patch provided to me by\n> Laurent, where I have added the commit messages.\n>\n> These ensure that messages sent by the IPA are handled correctly and do\n> not race at stop() time\n>\n> Patch [3/8] was identified by valgrind and fixes an issue related to\n> uninitialised accesses on the buffers.\n>\n> Patch [4/8] extends the state machine checks of the Camera to ensure\n> that the pipeline handler does not queue requests out of state.\n>\n> Patch [5/8] is techincally the only remaining patch from v1 of the IPU3\n> stability series but now makes this condtion a fatal error to catch\n> incorrect usages in pipeline handlers.\n>\n> Patch [6/8] has already been posted separately and is key to the\n> resolution of the IPU3 IPA shutdown procedure fixes.\n>\n> Patch [7/8] adds a guarantee that all requests have completed before\n> releasing buffers. This guarantee would fail before this series. It\n> may be helpful to add this assertion to a common call in the pipeline\n> handler base class, or to the CameraData as part of future developments.\n>\n> Patch [8/8] adds further assertions that the FrameInfo can be found\n> during event handling from the IPA. This also would have failed before\n> this series.\n>\n\nNo regressions noticed when running CTS\nTested-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Kieran Bingham (6):\n> libcamera: buffer: Initialise status\n> libcamera: camera: Validate requests are completed in Running state\n> libcamera: v4l2_videodevice: Prevent queueing buffers without a cache\n> libcamera: pipeline: ipu3: Stop IPA before stopping devices\n> libcamera: pipeline: ipu3: Ensure no requests are pending at stop()\n> libcamera: pipeline: ipu3: Fail if the FrameInfo can't be found\n>\n> Laurent Pinchart (2):\n> utils: ipc: proxy: Assert asynchronous calls execute in the running\n> state\n> utils: ipc: proxy: Process pending messages\n>\n> include/libcamera/buffer.h | 4 ++--\n> src/libcamera/camera.cpp | 10 ++++++++--\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 18 +++++++++++++++---\n> src/libcamera/v4l2_videodevice.cpp | 10 ++++++++++\n> .../module_ipa_proxy.cpp.tmpl | 2 ++\n> .../libcamera_templates/proxy_functions.tmpl | 6 ++++--\n> 6 files changed, 41 insertions(+), 9 deletions(-)\n>\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1132CBD80C\n\tfor ;\n\tSat, 13 Mar 2021 09:18:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 429D168C67;\n\tSat, 13 Mar 2021 10:18:08 +0100 (CET)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08079602E3\n\tfor ;\n\tSat, 13 Mar 2021 10:18:07 +0100 (CET)","from uno.localdomain (host-79-22-58-175.retail.telecomitalia.it\n\t[79.22.58.175]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 46447100003;\n\tSat, 13 Mar 2021 09:18:06 +0000 (UTC)"],"Date":"Sat, 13 Mar 2021 10:18:37 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20210313091837.f5las5l2dnewva3p@uno.localdomain>","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 0/8] IPU3 Stability","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]