{"id":11551,"url":"https://patchwork.libcamera.org/api/covers/11551/?format=json","web_url":"https://patchwork.libcamera.org/cover/11551/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>","date":"2021-03-12T05:47:19","name":"[libcamera-devel,v2,0/8] IPU3 Stability","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/11551/mbox/","series":[{"id":1785,"url":"https://patchwork.libcamera.org/api/series/1785/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1785","date":"2021-03-12T05:47:19","name":"IPU3 Stability","version":2,"mbox":"https://patchwork.libcamera.org/series/1785/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/11551/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0582BD1F1\n\tfor ;\n\tFri, 12 Mar 2021 05:47:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D527868C6C;\n\tFri, 12 Mar 2021 06:47:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA19E60106\n\tfor ;\n\tFri, 12 Mar 2021 06:47:31 +0100 (CET)","from localhost.localdomain\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2F52588F;\n\tFri, 12 Mar 2021 06:47:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HaPVGNwr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615528051;\n\tbh=XBxq67T/2f0IlEX9MkVUO/1oCLtNl6E1w3ob5hedNls=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=HaPVGNwrvyD6kvie4HYtxmz6UDg6XUO21dMLLkdqLPjbcH5OQiQo5b9tqe8RQ6c3Z\n\t3EUBK+MCUk2Y5YvwHhikeMjKmyslu3XGJ28dhFMRt02r1xyrETvELW0T7cD/yD71c8\n\tkLZgjG2K3/mgym5yd296n0iojm8tQAFtYr6YaQoc=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 12 Mar 2021 05:47:19 +0000","Message-Id":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 0/8] IPU3 Stability","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This series continues the investigation and resolution of stability\nissues identified on the IPU3 platform and pipeline handler.\n\nPatches [1/8] and [2/8] are split from a test patch provided to me by\nLaurent, where I have added the commit messages.\n\nThese ensure that messages sent by the IPA are handled correctly and do\nnot race at stop() time\n\nPatch [3/8] was identified by valgrind and fixes an issue related to\nuninitialised accesses on the buffers.\n\nPatch [4/8] extends the state machine checks of the Camera to ensure\nthat the pipeline handler does not queue requests out of state.\n\nPatch [5/8] is techincally the only remaining patch from v1 of the IPU3\nstability series but now makes this condtion a fatal error to catch\nincorrect usages in pipeline handlers.\n\nPatch [6/8] has already been posted separately and is key to the\nresolution of the IPU3 IPA shutdown procedure fixes.\n\nPatch [7/8] adds a guarantee that all requests have completed before\nreleasing buffers. This guarantee would fail before this series. It\nmay be helpful to add this assertion to a common call in the pipeline\nhandler base class, or to the CameraData as part of future developments.\n\nPatch [8/8] adds further assertions that the FrameInfo can be found\nduring event handling from the IPA. This also would have failed before\nthis series.\n\n\nKieran Bingham (6):\n libcamera: buffer: Initialise status\n libcamera: camera: Validate requests are completed in Running state\n libcamera: v4l2_videodevice: Prevent queueing buffers without a cache\n libcamera: pipeline: ipu3: Stop IPA before stopping devices\n libcamera: pipeline: ipu3: Ensure no requests are pending at stop()\n libcamera: pipeline: ipu3: Fail if the FrameInfo can't be found\n\nLaurent Pinchart (2):\n utils: ipc: proxy: Assert asynchronous calls execute in the running\n state\n utils: ipc: proxy: Process pending messages\n\n include/libcamera/buffer.h | 4 ++--\n src/libcamera/camera.cpp | 10 ++++++++--\n src/libcamera/pipeline/ipu3/ipu3.cpp | 18 +++++++++++++++---\n src/libcamera/v4l2_videodevice.cpp | 10 ++++++++++\n .../module_ipa_proxy.cpp.tmpl | 2 ++\n .../libcamera_templates/proxy_functions.tmpl | 6 ++++--\n 6 files changed, 41 insertions(+), 9 deletions(-)"}