[{"id":15539,"web_url":"https://patchwork.libcamera.org/comment/15539/","msgid":"","date":"2021-03-08T23:07:26","subject":"Re: [libcamera-devel] [PATCH v2 0/3] Raspberry Pi support for new\n\tsensors","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patches.\n\nOn Mon, Mar 08, 2021 at 10:39:36PM +0000, David Plowman wrote:\n> Hi again everyone\n> \n> Thanks to Laurent for reviewing the previous version of this\n> set. Here's a version 2, taking account of his comments. The\n> differences are:\n> \n> 1. In the first patch some stray comment lines have been deleted.\n> \n> 2. In the second patch, files have been ordered alphabetically.\n> \n> 3. There's a new 3rd patch, which edits the raspberrypi.mojom file so\n> that the vblank field in the SensorConfig is more accurately named\n> vblankDelay.\n\nFor the whole series,\n\nReviewed-by: Laurent Pinchart \n\n> David Plowman (3):\n> ipa: raspberrypi: Make CamHelpers return the frame delay for vblanking\n> ipa: raspberrypi: Add support for imx290/imx327 sensors\n> ipa: raspberrypi: Rename vblank field in SensorConfig to vblankDelay\n> \n> include/libcamera/ipa/raspberrypi.mojom | 2 +-\n> src/ipa/raspberrypi/cam_helper.cpp | 4 +-\n> src/ipa/raspberrypi/cam_helper.hpp | 11 +-\n> src/ipa/raspberrypi/cam_helper_imx290.cpp | 67 +++++++\n> src/ipa/raspberrypi/cam_helper_imx477.cpp | 7 +-\n> src/ipa/raspberrypi/cam_helper_ov5647.cpp | 7 +-\n> src/ipa/raspberrypi/data/imx290.json | 165 ++++++++++++++++++\n> src/ipa/raspberrypi/data/meson.build | 1 +\n> src/ipa/raspberrypi/meson.build | 1 +\n> src/ipa/raspberrypi/raspberrypi.cpp | 6 +-\n> .../pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> 11 files changed, 258 insertions(+), 15 deletions(-)\n> create mode 100644 src/ipa/raspberrypi/cam_helper_imx290.cpp\n> create mode 100644 src/ipa/raspberrypi/data/imx290.json","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F3CABD80C\n\tfor ;\n\tMon, 8 Mar 2021 23:08:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A45CC68A9F;\n\tTue, 9 Mar 2021 00:08:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B56C6051F\n\tfor ;\n\tTue, 9 Mar 2021 00:07:59 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A3C8E99;\n\tTue, 9 Mar 2021 00:07:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mhQnrdRy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615244879;\n\tbh=uaWcT4sQWrJ0Gc9/tVFzYMkFUTxmRPYlcQsLzTCcSIY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mhQnrdRy3JOHLdBmrNLsp+cOu/jKJxR/vytNIRsrRe4hPSsD4hDgXE/k6bZGtvy+S\n\tiHcSJqmbKN92TKs979jU6xcMkNdOL5Awx5SLapp25R7umcmFT6tg94whA3nUnTbFXP\n\tWubRz/i/VCR3r2ktb+97kNBIn8/HmzJRBDMIPv7k=","Date":"Tue, 9 Mar 2021 01:07:26 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20210308223939.2088-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210308223939.2088-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 0/3] Raspberry Pi support for new\n\tsensors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15553,"web_url":"https://patchwork.libcamera.org/comment/15553/","msgid":"","date":"2021-03-09T07:29:41","subject":"Re: [libcamera-devel] [PATCH v2 0/3] Raspberry Pi support for new\n\tsensors","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nOn Mon, 8 Mar 2021 at 22:39, David Plowman \nwrote:\n\n> Hi again everyone\n>\n> Thanks to Laurent for reviewing the previous version of this\n> set. Here's a version 2, taking account of his comments. The\n> differences are:\n>\n> 1. In the first patch some stray comment lines have been deleted.\n>\n> 2. In the second patch, files have been ordered alphabetically.\n>\n> 3. There's a new 3rd patch, which edits the raspberrypi.mojom file so\n> that the vblank field in the SensorConfig is more accurately named\n> vblankDelay.\n>\n> Thanks and best regards\n>\n> David\n\n\n> David Plowman (3):\n> ipa: raspberrypi: Make CamHelpers return the frame delay for vblanking\n> ipa: raspberrypi: Add support for imx290/imx327 sensors\n> ipa: raspberrypi: Rename vblank field in SensorConfig to vblankDelay\n>\n>\nFor all three patches:\nReviewed-by: Naushir Patuck \n\n\n> include/libcamera/ipa/raspberrypi.mojom | 2 +-\n> src/ipa/raspberrypi/cam_helper.cpp | 4 +-\n> src/ipa/raspberrypi/cam_helper.hpp | 11 +-\n> src/ipa/raspberrypi/cam_helper_imx290.cpp | 67 +++++++\n> src/ipa/raspberrypi/cam_helper_imx477.cpp | 7 +-\n> src/ipa/raspberrypi/cam_helper_ov5647.cpp | 7 +-\n> src/ipa/raspberrypi/data/imx290.json | 165 ++++++++++++++++++\n> src/ipa/raspberrypi/data/meson.build | 1 +\n> src/ipa/raspberrypi/meson.build | 1 +\n> src/ipa/raspberrypi/raspberrypi.cpp | 6 +-\n> .../pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> 11 files changed, 258 insertions(+), 15 deletions(-)\n> create mode 100644 src/ipa/raspberrypi/cam_helper_imx290.cpp\n> create mode 100644 src/ipa/raspberrypi/data/imx290.json\n>\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13F3ABD1F1\n\tfor ;\n\tTue, 9 Mar 2021 07:30:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C13C56051F;\n\tTue, 9 Mar 2021 08:29:59 +0100 (CET)","from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40F9B602E4\n\tfor ;\n\tTue, 9 Mar 2021 08:29:58 +0100 (CET)","by mail-lj1-x22b.google.com with SMTP id a17so19403930ljq.2\n\tfor ;\n\tMon, 08 Mar 2021 23:29:58 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"N5NEFKDI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=76aFcvyxcSGNIFXX4ngjdw1l/UfEfKjobLe3SepHxbg=;\n\tb=N5NEFKDIIckgKqPIemEYb0M1bVRjq1kCu3VoPDBpjYLoMN3hin+tL4glVtmda3BUGX\n\t3Sc1cD/V3EMmiQJ8f1gnmkd0gqpdjmtv6Y/MY15zYKn6gtnbsYgxExvyTra77Cy0C2sk\n\t2e73J89jg6kP5BwHLflJeoPITHyVJTaEUwHLQLruToRbhvkydhbIcXzRhzHAk0xwYHvd\n\t8+uCjZj9+/UySGTUzbM+r51u7rf/ePxDw4UiZ1+2xBtpOujwRn7VfsNKI/ixN7zXinwh\n\tt64J6Uzr+MjxnYWRPHf8TCsmJd3JJJJy2cDy2RFIPUVATfleAihnp1roUWuZtkB14+4z\n\tnJ7g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=76aFcvyxcSGNIFXX4ngjdw1l/UfEfKjobLe3SepHxbg=;\n\tb=uXgTA8a9zFLImuPndhO3cDvRoEaVqXJjRuVT443p82YyKQV7+Rvmjf3eB0dY/+CACF\n\t6rQjRYxUUWaRVSd2Y0yjebhwWnryNKnmQffGmwHAteWqGeovwb+orjg3kNMna3KSRSe9\n\t+gqXjIdjhzolEFaHpgnifjpfAdLGdaFjkDMgy6Mkzntjc9612l8UUnBy4YJ7pnPIrUWt\n\tbe0bdHMpgqhDjqxv42X+Xo/iAAhZ9vanvNDXLUVwH85Sr7wrUM48C26fY8U/kENOwdMv\n\tLJQDlNLNwL7IZVH5ryWq6y2gZh3KN5O1ZUSPwydYSxndjFvXiqXdy4uEgEaJ1mfGCl9T\n\tmkDw==","X-Gm-Message-State":"AOAM533zqHkp2Yt8vB2xG+TF4g4EwVU0Cg6bAOae52yTE+A/Khw5lx3F\n\tO5sxeubW8EEG/AEflv5Az3OVYHSYA2iqbaCE3wPuBnfCLE1hIO0M","X-Google-Smtp-Source":"ABdhPJzg5SJ/Zcms5k6/8m0lVNvom/53GrKKHtf+YH4za5vGxQmpgHtSvxo77Hx5mFQs2PnCq8BLXPntnTVBIm7pM0E=","X-Received":"by 2002:a2e:534a:: with SMTP id\n\tt10mr16242323ljd.499.1615274997638; \n\tMon, 08 Mar 2021 23:29:57 -0800 (PST)","MIME-Version":"1.0","References":"<20210308223939.2088-1-david.plowman@raspberrypi.com>","In-Reply-To":"<20210308223939.2088-1-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Tue, 9 Mar 2021 07:29:41 +0000","Message-ID":"","To":"David Plowman ","Subject":"Re: [libcamera-devel] [PATCH v2 0/3] Raspberry Pi support for new\n\tsensors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============8407488340206655840==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]