[{"id":1555,"web_url":"https://patchwork.libcamera.org/comment/1555/","msgid":"<20190503171319.GD4903@pendragon.ideasonboard.com>","date":"2019-05-03T17:13:19","subject":"Re: [libcamera-devel] [PATCH 0/2] V4L2Device Try format support","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patches.\n\nOn Fri, May 03, 2019 at 04:34:01PM +0100, Kieran Bingham wrote:\n> Extend V4L2Device to provide a tryFormat function. This can be used to check a\n> format against a V4L2 Device to determine a suitable configuration.\n> \n> Utilise this in the UVC pipeline handler so that we can provide a valid default\n> configuration on any UVC web cam.\n\nI think this should be handled through format enumeration though, but\nmaybe also confirmed by trying it out. Niklas has developed patches that\nare based on a series I haven't posted yet. I'll try to finalise it\nASAP so you can have a look.\n\n> Kieran Bingham (2):\n> libcamera: v4l2_device: Add tryFormat support\n> libcamera: pipeline: uvc: Try a default format against the device\n> \n> src/libcamera/include/v4l2_device.h | 7 +++++--\n> src/libcamera/pipeline/uvcvideo.cpp | 11 +++++++++--\n> src/libcamera/v4l2_device.cpp | 29 +++++++++++++++++++++++------\n> 3 files changed, 37 insertions(+), 10 deletions(-)\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD7F460003\n\tfor ;\n\tFri, 3 May 2019 19:13:32 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2F2A831E;\n\tFri, 3 May 2019 19:13:32 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556903612;\n\tbh=v75MSS7na1sy20GtzrzdeV2J9l97XxZh8nOZsnU9JRw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LjbLiyLl1WLmEHnHvhJ7+3nXsTNRVoP7gfaJAg2f7+m66PzhudzhxzygKY7i8G8ux\n\t8OSnFjWuKLfsDCbSz7WmcS0GBTaPZMMIsR0zJYIuB6a/tTT3m780K/YWSoa5U0mN0X\n\tXxgHqf+ZDaYbpHxnbA2UXJPSIwyNrwL9WJ3cvn0k=","Date":"Fri, 3 May 2019 20:13:19 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190503171319.GD4903@pendragon.ideasonboard.com>","References":"<20190503153403.8728-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190503153403.8728-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 0/2] V4L2Device Try format support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 03 May 2019 17:13:33 -0000"}},{"id":1683,"web_url":"https://patchwork.libcamera.org/comment/1683/","msgid":"<40663e5e-17bd-1ef8-0306-24390d9118cf@ideasonboard.com>","date":"2019-05-23T13:47:16","subject":"Re: [libcamera-devel] [PATCH 0/2] V4L2Device Try format support","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 03/05/2019 18:13, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patches.\n> \n> On Fri, May 03, 2019 at 04:34:01PM +0100, Kieran Bingham wrote:\n>> Extend V4L2Device to provide a tryFormat function. This can be used to check a\n>> format against a V4L2 Device to determine a suitable configuration.\n>>\n>> Utilise this in the UVC pipeline handler so that we can provide a valid default\n>> configuration on any UVC web cam.\n> \n> I think this should be handled through format enumeration though, but\n> maybe also confirmed by trying it out. Niklas has developed patches that\n> are based on a series I haven't posted yet. I'll try to finalise it\n> ASAP so you can have a look.\n\nOk, but I still think a tryFormat() has it's uses in V4L2Device.\n\nI've just rebased this series on top of your CameraConfiguration\nchanges, and you added a Todo: to validate the configuration against the\ndevice.\n\nI've updated this series to use that, and instead perform the\ntryFormat() in UVCCameraConfiguration::validate()\n\nPosting to follow...\n\n\n> \n>> Kieran Bingham (2):\n>> libcamera: v4l2_device: Add tryFormat support\n>> libcamera: pipeline: uvc: Try a default format against the device\n>>\n>> src/libcamera/include/v4l2_device.h | 7 +++++--\n>> src/libcamera/pipeline/uvcvideo.cpp | 11 +++++++++--\n>> src/libcamera/v4l2_device.cpp | 29 +++++++++++++++++++++++------\n>> 3 files changed, 37 insertions(+), 10 deletions(-)\n>>\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CA4760DE9\n\tfor ;\n\tThu, 23 May 2019 15:47:20 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6F7A4583;\n\tThu, 23 May 2019 15:47:19 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1558619239;\n\tbh=Y/tOzna7EjPBH2xXUj74jCmEEE7KiY6NueV0McK1xaE=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=d3kzAHzu6FTJkc95uUZvDim3gkRy7BmPNTLj52bLVusxyjNgqAtmYL+9idyd10RD5\n\tBkVjjA9Y/KzoYqhZRSNNLQ62eCPuCeB6RgLCiGm+fjB8+wSZX0QQ3VzFhMa8z5PpDx\n\tvuOyAiOMhaZ4He1JYyf/5S+TGKCT85Xn9TgVsaFE=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"LibCamera Devel ","References":"<20190503153403.8728-1-kieran.bingham@ideasonboard.com>\n\t<20190503171319.GD4903@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<40663e5e-17bd-1ef8-0306-24390d9118cf@ideasonboard.com>","Date":"Thu, 23 May 2019 14:47:16 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.6.1","MIME-Version":"1.0","In-Reply-To":"<20190503171319.GD4903@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 0/2] V4L2Device Try format support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 23 May 2019 13:47:20 -0000"}}]