{"id":11370,"url":"https://patchwork.libcamera.org/api/covers/11370/?format=json","web_url":"https://patchwork.libcamera.org/cover/11370/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210224094833.24219-1-paul.elder@ideasonboard.com>","date":"2021-02-24T09:48:30","name":"[libcamera-devel,v3,0/2] Fix camera location","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/11370/mbox/","series":[{"id":1723,"url":"https://patchwork.libcamera.org/api/series/1723/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1723","date":"2021-02-24T09:48:30","name":"Fix camera location","version":3,"mbox":"https://patchwork.libcamera.org/series/1723/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/11370/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03D4ABD808\n\tfor ;\n\tWed, 24 Feb 2021 09:48:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 40B8C68A33;\n\tWed, 24 Feb 2021 10:48:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F4796040F\n\tfor ;\n\tWed, 24 Feb 2021 10:48:47 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0C72C8A1;\n\tWed, 24 Feb 2021 10:48:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Pz7N2Ag0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614160127;\n\tbh=HeNOBuQ+2FVi3QzJNGuQ5nSH7S9TKwQC2ZSSriyFzTg=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Pz7N2Ag0VTa4nCja9VO3btdNcfHnD+OpPJT0SK86eHT5LCO3igJ+A3ccXq3Qh7fH2\n\tQdxGjGCbykqCZ8NGI+ybqd5s35Kns6s67BcLyFhb8zku0EAKzS77ITO+JqG19/3ty5\n\tcOT9s0iCQWIgOSuKpmt4cAHO3u2teIYs4bAImQG8=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 24 Feb 2021 18:48:30 +0900","Message-Id":"<20210224094833.24219-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 0/2] Fix camera location","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"libcamera defaults the location of cameras with no V4L2 camera\norientation control to external.\n\nOur android HAL implementation currently doesn't support external\ncameras, so the CTS test\n\"android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList\"\nwill fail when cameras have a location of external.\n\nThe long-term solution is to make sure that the orientation is declared\nin the firmware. In the meantime, this patch series makes libcamera\nprint a warning when the location is defaulted to external, and makes\nthe HAL implementation change it to front.\n\nPaul Elder (2):\n libcamera: camera_sensor: Print warning when orientation is unknown\n android: camera_device: Set the camera location to Front if External\n\n src/android/camera_device.cpp | 6 +++++-\n src/libcamera/camera_sensor.cpp | 23 +++++++++++++++++++++--\n 2 files changed, 26 insertions(+), 3 deletions(-)"}