{"id":11351,"url":"https://patchwork.libcamera.org/api/covers/11351/?format=json","web_url":"https://patchwork.libcamera.org/cover/11351/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210222080112.72521-1-paul.elder@ideasonboard.com>","date":"2021-02-22T08:01:10","name":"[libcamera-devel,v2,0/2] Fix camera location","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/11351/mbox/","series":[{"id":1714,"url":"https://patchwork.libcamera.org/api/series/1714/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1714","date":"2021-02-22T08:01:10","name":"Fix camera location","version":2,"mbox":"https://patchwork.libcamera.org/series/1714/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/11351/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0EB8BD1F6\n\tfor ;\n\tMon, 22 Feb 2021 08:01:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E246689F9;\n\tMon, 22 Feb 2021 09:01:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AE41689EA\n\tfor ;\n\tMon, 22 Feb 2021 09:01:30 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C012C344;\n\tMon, 22 Feb 2021 09:01:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aI3SxTWo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613980890;\n\tbh=KhD+xQZVfBUc04sF7JtRzdoTt8bBDez5DTwfL5KgwT4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=aI3SxTWohbUv1axg11teiwWBWzkDrmXYsnRdsebWbMs/2NoEdwqlOTfEpGgYR7FUk\n\tSuB4vvfpkrALyPoL27RUZBaFNz6vC8DESrBHP8A6dqfoKOzHW5ET/S0p7GK0g7vsJD\n\tGFMQ0hHb9Ec270qSNW/UceNvdM+MS6C/xXHol8lQ=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 22 Feb 2021 17:01:10 +0900","Message-Id":"<20210222080112.72521-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 0/2] Fix camera location","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"libcamera defaults the location of cameras with no V4L2 camera\norientation control to external.\n\nOur android HAL implementation currently doesn't support external\ncameras, so the CTS test\n\"android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList\"\nwill fail when cameras have a location of external.\n\nThe long-term solution is to make sure that the orientation is declared\nin the firmware. In the meantime, this patch series makes libcamera\nprint a warning when the location is defaulted to external, and makes\nthe HAL implementation change it to front.\n\nPaul Elder (2):\n libcamera: camera_sensor: Print warning when orientation is unknown\n android: camera_device: Set the camera location to Front if External\n\n src/android/camera_device.cpp | 6 +++++-\n src/libcamera/camera_sensor.cpp | 6 ++++++\n 2 files changed, 11 insertions(+), 1 deletion(-)"}