[{"id":15270,"web_url":"https://patchwork.libcamera.org/comment/15270/","msgid":"","date":"2021-02-22T02:28:45","subject":"Re: [libcamera-devel] [RFC PATCH 0/2] Implement IPA algorithms and\n\tdemo with IPU3","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nOn Fri, Feb 19, 2021 at 06:22:22PM +0100, Jean-Michel Hautbois wrote:\n> This RFC is really meant to start discussions.\n\nThat's what RFCs are for :-) Thanks for sending it, I'll reply to the\ntwo patches.\n\n> It demonstrates on IPU3 a conjunction of automatic exposure (AGC)\n> and automatic white balance (AWB).\n> \n> The skeleton are extracted from RPi controller and probably subject to\n> modifications and discussions :\n> - are the mandatory methods really those ?\n> - how to exchange data between algorithms ?\n> - metadata like RPi?\n> - IPC ?\n> - public methods?\n> - controller API ?\n> - is the controller needed at all ?\n> \n> The implementation in IPU3 is tested on SGo2.\n> It is not perfect but shows a really better behaviour than default ;-).\n> \n> Jean-Michel Hautbois (2):\n> WIP: ipa: Add Controller and Algorithm skeleton\n> WIP: ipa: ipu3: Add support for IPU3 AWB algorithm\n> \n> include/libcamera/ipa/agc_algorithm.h | 32 ++++\n> include/libcamera/ipa/awb_algorithm.h | 27 ++++\n> include/libcamera/ipa/ipa_algorithm.h | 46 ++++++\n> include/libcamera/ipa/ipa_controller.h | 39 +++++\n> include/libcamera/ipa/meson.build | 4 +\n> src/ipa/ipu3/ipu3.cpp | 31 +++-\n> src/ipa/ipu3/ipu3_agc.cpp | 195 +++++++++++++++++++++++++\n> src/ipa/ipu3/ipu3_agc.h | 96 ++++++++++++\n> src/ipa/ipu3/ipu3_awb.cpp | 182 +++++++++++++++++++++++\n> src/ipa/ipu3/ipu3_awb.h | 130 +++++++++++++++++\n> src/ipa/ipu3/meson.build | 8 +-\n> src/ipa/libipa/ipa_algorithm.cpp | 20 +++\n> src/ipa/libipa/ipa_controller.cpp | 45 ++++++\n> src/ipa/libipa/meson.build | 2 +\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +\n> 15 files changed, 853 insertions(+), 5 deletions(-)\n> create mode 100644 include/libcamera/ipa/agc_algorithm.h\n> create mode 100644 include/libcamera/ipa/awb_algorithm.h\n> create mode 100644 include/libcamera/ipa/ipa_algorithm.h\n> create mode 100644 include/libcamera/ipa/ipa_controller.h\n> create mode 100644 src/ipa/ipu3/ipu3_agc.cpp\n> create mode 100644 src/ipa/ipu3/ipu3_agc.h\n> create mode 100644 src/ipa/ipu3/ipu3_awb.cpp\n> create mode 100644 src/ipa/ipu3/ipu3_awb.h\n> create mode 100644 src/ipa/libipa/ipa_algorithm.cpp\n> create mode 100644 src/ipa/libipa/ipa_controller.cpp","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ED1F4BD1F6\n\tfor ;\n\tMon, 22 Feb 2021 02:29:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7327D689F1;\n\tMon, 22 Feb 2021 03:29:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 923D6602F1\n\tfor ;\n\tMon, 22 Feb 2021 03:29:12 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 99070344;\n\tMon, 22 Feb 2021 03:29:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sxbrikoQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613960951;\n\tbh=URH8BekxA78mf/uZDXNwUuXzWqcl3LItezKWKXxRFvc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sxbrikoQ5Lt0bbWrvqY0xsvB35kl15fNGZMvGNtUuvS4t+Qxxq/o1Ru//HqxuSMHD\n\tDO+Pl71x6h3xGq46jXcm/CMikKqqRansIMsLFvi7qBIAmwB6aS2dfLZR8g2zRRvS5Z\n\tO37j6kcDzHgLP5BWiXVBGj8cBdO2E8QWAOL1tEGY=","Date":"Mon, 22 Feb 2021 04:28:45 +0200","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210219172224.69862-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210219172224.69862-1-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 0/2] Implement IPA algorithms and\n\tdemo with IPU3","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]